Skip to contentSkip to conversation

drm/amdgpu: set gfx_v9_0_ip_funcs as static

PATCH In review Huang Rui 2 participants 2 messages Aug 4, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

PATCH 1/1 drm/amdgpu: set gfx_v9_0_ip_funcs as static

We won't use this member in other files, so set it static.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
index 6a36a5b..faad8a5 100644
@@ -4096,7 +4096,7 @@ static int gfx_v9_0_kiq_irq(struct amdgpu_device *adev,
 	return 0;
 }
 
-const struct amd_ip_funcs gfx_v9_0_ip_funcs = {
+static const struct amd_ip_funcs gfx_v9_0_ip_funcs = {
 	.name = "gfx_v9_0",
 	.early_init = gfx_v9_0_early_init,
 	.late_init = gfx_v9_0_late_init,
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.h +0 -1
index 56ef652..fa5a3fb 100644
@@ -24,7 +24,6 @@
 #ifndef __GFX_V9_0_H__
 #define __GFX_V9_0_H__
 
-extern const struct amd_ip_funcs gfx_v9_0_ip_funcs;
 extern const struct amdgpu_ip_block_version gfx_v9_0_ip_block;
 
 void gfx_v9_0_select_se_sh(struct amdgpu_device *adev, u32 se_num, u32 sh_num);
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1501838414-21904-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw

Am 04.08.2017 um 11:20 schrieb Huang Rui:

Quoted 3 lines

We won't use this member in other files, so set it static.

Quoted 23 lines
---
  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
  drivers/gpu/drm/amd/amdgpu/gfx_v9_0.h | 1 -
  2 files changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +1 -1
index 6a36a5b..faad8a5 100644
@@ -4096,7 +4096,7 @@ static int gfx_v9_0_kiq_irq(struct amdgpu_device *adev,
  	return 0;
  }
 
-const struct amd_ip_funcs gfx_v9_0_ip_funcs = {
+static const struct amd_ip_funcs gfx_v9_0_ip_funcs = {
  	.name = "gfx_v9_0",
  	.early_init = gfx_v9_0_early_init,
  	.late_init = gfx_v9_0_late_init,
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.h +0 -0
index 56ef652..fa5a3fb 100644

drivers/gpu/drm/amd/amdgpu/gfx_v9_0.h line 29

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.h +0 -1
@@ -24,7 +24,6 @@
  #ifndef __GFX_V9_0_H__
  #define __GFX_V9_0_H__
 
-extern const struct amd_ip_funcs gfx_v9_0_ip_funcs;
  extern const struct amdgpu_ip_block_version gfx_v9_0_ip_block;
 
  void gfx_v9_0_select_se_sh(struct amdgpu_device *adev, u32 se_num, u32 sh_num);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx