Skip to contentSkip to conversation

kms_busy: Fix basic-modeset-* name format parameters

PATCH In review Petri Latvala 2 participants 3 messages Aug 4, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kms_busy: Fix basic-modeset-* name format parameters

Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used engines to only the default engine, dropping the engine name from subtest names, but left over the format parameter.

Fixes 37b06eb9b526 ("tests/kms_busy: Only test against one engine")
CC Daniel Vetter <[email protected]>
---
 tests/kms_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_busy.c +1 -1
index 16ab891..dc00214 100644
@@ -342,7 +342,7 @@ igt_main
 			test_flip(&display, e->exec_id | e->flags, n, false);
 		}
 		igt_subtest_f("basic-modeset-%s",
-			      e->name, kmstest_pipe_name(n)) {
+			      kmstest_pipe_name(n)) {
 			igt_require(gem_has_ring(display.drm_fd,
 						e->exec_id | e->flags));
 
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Thanks Petri, now I can run testlists again!

Quoted 37 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Petri Latvala
Sent: Friday, August 4, 2017 2:45 PM
To: [email protected]
Cc: Daniel Vetter <[email protected]>
Subject: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name format parameters

Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used engines to only the default engine, dropping the engine name from subtest names, but left over the format parameter.

Fixes 37b06eb9b526 ("tests/kms_busy: Only test against one engine")
CC Daniel Vetter <[email protected]>
---
 tests/kms_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_busy.c index 16ab891..dc00214 renamed from tests/kms_busy.c +0 -0

100644

tests/kms_busy.c +1 -1
@@ -342,7 +342,7 @@ igt_main
 			test_flip(&display, e->exec_id |
 e->flags, n, false);
 		}
 		igt_subtest_f("basic-modeset-%s",
-			      e->name,
 kmstest_pipe_name(n)) {
+			      kmstest_pipe_name(n)) {
 
	igt_require(gem_has_ring(display.drm_fd,

	e->exec_id | e->flags));
Quoted 7 lines

--
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Petri Latvala
Quoted 48 lines

-----Original Message-----
From: Lofstedt, Marta
Sent: Friday, August 4, 2017 3:05 PM
To: 'Petri Latvala' <[email protected]>; [email protected]
Cc: Daniel Vetter <[email protected]>
Subject: RE: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name format parameters

Thanks Petri, now I can run testlists again!

Quoted 38 lines

-----Original Message-----
From: Intel-gfx [mailto:[email protected]] On Behalf Of Petri Latvala
Sent: Friday, August 4, 2017 2:45 PM
To: [email protected]
Cc: Daniel Vetter <[email protected]>
Subject: [Intel-gfx] [PATCH i-g-t] kms_busy: Fix basic-modeset-* name format parameters

Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used engines to only the default engine, dropping the engine name from subtest names, but left over the format parameter.

Fixes 37b06eb9b526 ("tests/kms_busy: Only test against one engine")
CC Daniel Vetter <[email protected]>
---
 tests/kms_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_busy.c index renamed from tests/kms_busy.c +0 -0

16ab891..dc00214
100644

tests/kms_busy.c +1 -1
@@ -342,7 +342,7 @@ igt_main
 			test_flip(&display, e->exec_id |
 e->flags, n, false);
 		}
 		igt_subtest_f("basic-modeset-%s",
-			      e->name,
 kmstest_pipe_name(n)) {
+			      kmstest_pipe_name(n)) {
 
	igt_require(gem_has_ring(display.drm_fd,

	e->exec_id | e->flags));
Quoted 7 lines
Quoted 7 lines

--
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx