Skip to contentSkip to conversation

Patch "scsi: lpfc: fix linking against modular NVMe support" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Aug 7, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

scsi: lpfc: fix linking against modular NVMe support

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
scsi-lpfc-fix-linking-against-modular-nvme-support.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From cd069bb9f9ff13b23492fda6ccdb458ac4f641ca Mon Sep 17 00:00:00 2001

From: Arnd Bergmann <[email protected]>
Date: Fri, 21 Jul 2017 22:53:46 +0200
Subject: scsi: lpfc: fix linking against modular NVMe support

From: Arnd Bergmann <[email protected]>

commit cd069bb9f9ff13b23492fda6ccdb458ac4f641ca upstream.

When LPFC is built-in but NVMe is a loadable module, we fail to link the kernel:

drivers/scsi/built-in.o: In function `lpfc_nvme_create_localport':
(.text+0x156a82): undefined reference to nvme_fc_register_localport' drivers/scsi/built-in.o: In function lpfc_nvme_destroy_localport':
(.text+0x156eaa): undefined reference to `nvme_fc_unregister_remoteport'

We can avoid this either by forcing lpfc to be a module, or by disabling NVMe support in this case. This implements the former.

Fixes 7d7080335f8d ("scsi: lpfc: Finalize Kconfig options for nvme")
---
 drivers/scsi/Kconfig |    2 ++
 1 file changed, 2 insertions(+)
drivers/scsi/Kconfig +2 -0
@@ -1241,6 +1241,8 @@ config SCSI_LPFC
 	tristate "Emulex LightPulse Fibre Channel Support"
 	depends on PCI && SCSI
 	depends on SCSI_FC_ATTRS
+	depends on NVME_TARGET_FC || NVME_TARGET_FC=n
+	depends on NVME_FC || NVME_FC=n
 	select CRC_T10DIF
 	---help---
           This lpfc driver supports the Emulex LightPulse

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/scsi-lpfc-fix-linking-against-modular-nvme-support.patch