Skip to contentSkip to conversation

drm/bridge: make drm_bridge_funcs const

PATCH Applied Bhumika Goyal 3 participants 3 messages Aug 8, 2017 – Aug 9, 2017

Subsystems (3)
DRM drivers DRM misc DRM drivers for bridge chips
lore
Share & tools
lore

Bhumika Goyal

author
#0 lore raw

PATCH 1/1 drm/bridge: make drm_bridge_funcs const

Make these structures const as they are only stored in the funcs field of drm_bridge structure, which is of type const.
Done using Coccinelle.

Signed-off-by Bhumika Goyal <[email protected]>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +1 -1
index ee16635..58b4fb2 100644
@@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge *bridge)
 	return ret;
 }
 
-static struct drm_bridge_funcs adv7511_bridge_funcs = {
+static const struct drm_bridge_funcs adv7511_bridge_funcs = {
 	.enable = adv7511_bridge_enable,
 	.disable = adv7511_bridge_disable,
 	.mode_set = adv7511_bridge_mode_set,
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1 -1
index 36f5ccb..63c7a01 100644
@@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge *bridge)
 	return drm_bridge_attach(bridge->encoder, dsi->panel_bridge, bridge);
 }
 
-static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
+static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
 	.mode_set     = dw_mipi_dsi_bridge_mode_set,
 	.enable	      = dw_mipi_dsi_bridge_enable,
 	.post_disable = dw_mipi_dsi_bridge_post_disable,
Signature · 1 line
1.9.1
reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Bhumika,

Thank you for the patch.

Quoted 5 lines · On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote:

Make these structures const as they are only stored in the funcs field of drm_bridge structure, which is of type const.
Done using Coccinelle.

Signed-off-by Bhumika Goyal <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>
Quoted 33 lines
---
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
 drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2 100644

drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +1 -1
@@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge
 *bridge) return ret;
 }
 
-static struct drm_bridge_funcs adv7511_bridge_funcs = {
+static const struct drm_bridge_funcs adv7511_bridge_funcs = {
 	.enable = adv7511_bridge_enable,
 	.disable = adv7511_bridge_disable,
 	.mode_set = adv7511_bridge_mode_set,
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01 100644

drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1 -1
@@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge
 *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge,
 bridge); }
 
-static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
+static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
 	.mode_set     = dw_mipi_dsi_bridge_mode_set,
 	.enable	      = dw_mipi_dsi_bridge_enable,
 	.post_disable = dw_mipi_dsi_bridge_post_disable,
Signature · 3 lines
Regards,

Laurent Pinchart
Applied
#2 lore raw
Quoted 4 lines · Laurent Pinchart

Hi Bhumika,

Thank you for the patch.

Quoted 8 lines
Quoted 5 lines · On Tuesday 08 Aug 2017 21:24:10 Bhumika Goyal wrote:

Make these structures const as they are only stored in the funcs field of drm_bridge structure, which is of type const.
Done using Coccinelle.

Signed-off-by Bhumika Goyal <[email protected]>
Reviewed-by Laurent Pinchart <[email protected]>

queued to drm-misc-next

Thanks,
Archit

Quoted 35 lines
Quoted 34 lines
---
  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c  | 2 +-
  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ee16635..58b4fb2 100644

drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +1 -1
@@ -857,7 +857,7 @@ static int adv7511_bridge_attach(struct drm_bridge
 *bridge) return ret;
  }
 
-static struct drm_bridge_funcs adv7511_bridge_funcs = {
+static const struct drm_bridge_funcs adv7511_bridge_funcs = {
  	.enable = adv7511_bridge_enable,
  	.disable = adv7511_bridge_disable,
  	.mode_set = adv7511_bridge_mode_set,
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01 100644

drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c +1 -1
@@ -811,7 +811,7 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge
 *bridge) return drm_bridge_attach(bridge->encoder, dsi->panel_bridge,
 bridge); }
 
-static struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
+static const struct drm_bridge_funcs dw_mipi_dsi_bridge_funcs = {
  	.mode_set     = dw_mipi_dsi_bridge_mode_set,
  	.enable	      = dw_mipi_dsi_bridge_enable,
  	.post_disable = dw_mipi_dsi_bridge_post_disable,
Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project