Skip to contentSkip to conversation

Patch "wireless: wext: terminate ifr name coming from userspace" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

wireless: wext: terminate ifr name coming from userspace

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
wireless-wext-terminate-ifr-name-coming-from-userspace.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Tue Aug 8 16:27:29 PDT 2017

From: "Levin, Alexander" <[email protected]>
Date: Tue, 18 Jul 2017 04:23:16 +0000
Subject: wireless: wext: terminate ifr name coming from userspace

From: "Levin, Alexander" <[email protected]>

[ Upstream commit 98de4e0ea47d106846fc0e30ce4e644283fa7fc2 ]

ifr name is assumed to be a valid string by the kernel, but nothing was forcing username to pass a valid string.

In turn, this would cause panics as we tried to access the string past it's valid memory.

---
 net/core/dev_ioctl.c |    2 ++
 1 file changed, 2 insertions(+)
net/core/dev_ioctl.c +2 -0
@@ -423,6 +423,8 @@ int dev_ioctl(struct net *net, unsigned
 		if (copy_from_user(&iwr, arg, sizeof(iwr)))
 			return -EFAULT;
 
+		iwr.ifr_name[sizeof(iwr.ifr_name) - 1] = 0;
+
 		return wext_handle_ioctl(net, &iwr, cmd, arg);
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/packet-fix-use-after-free-in-prb_retire_rx_blk_timer_expired.patch queue-4.12/wireless-wext-terminate-ifr-name-coming-from-userspace.patch