Skip to contentSkip to conversation

Patch "ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Aug 9, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ipv4-make-tcp_notsent_lowat-sysctl-knob-behave-as-true-unsigned-int.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Wed Aug 9 10:32:06 PDT 2017

From: Pavel Tikhomirov <[email protected]>
Date: Mon, 9 Jan 2017 10:45:49 +0300
Subject: ipv4: make tcp_notsent_lowat sysctl knob behave as true unsigned int

From: Pavel Tikhomirov <[email protected]>

[ Upstream commit b007f09072ca8afa118ade333e717ba443e8d807 ]

Quoted 1 line

cat /proc/sys/net/ipv4/tcp_notsent_lowat

-1

Quoted 1 line

echo 4294967295 > /proc/sys/net/ipv4/tcp_notsent_lowat

-bash: echo: write error: Invalid argument

Quoted 2 lines

echo -2147483648 > /proc/sys/net/ipv4/tcp_notsent_lowat cat /proc/sys/net/ipv4/tcp_notsent_lowat

-2147483648

but in documentation we have "tcp_notsent_lowat - UNSIGNED INTEGER"

v2: simplify to just proc_douintvec

---
 net/ipv4/sysctl_net_ipv4.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/sysctl_net_ipv4.c +1 -1
@@ -958,7 +958,7 @@ static struct ctl_table ipv4_net_table[]
 		.data		= &init_net.ipv4.sysctl_tcp_notsent_lowat,
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_douintvec,
 	},
 #ifdef CONFIG_IP_ROUTE_MULTIPATH
 	{

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/ipv4-make-tcp_notsent_lowat-sysctl-knob-behave-as-true-unsigned-int.patch