hwmon: (occ): Add error thresholding back in

PATCH New Eddie James 1 participant 1 message Aug 10, 2017 Hardware monitoring

lore

Share & tools

lore

Eddie James

author

2017-08-10 02:45 UTC #0 lore raw

PATCH 1/1 hwmon: (occ): Add error thresholding back in

From: "Edward A. James" <[email protected]>

Threshold communication and message errors to the OCC, such that errors are only valid after two have been observed in a row. This thresholding is required by the OCC specification. An old P8 OCC spec is available here:
https://github.com/open-power/docs/blob/master/occ/OCC_OpenPwr_FW_Interfaces.pdf

Signed-off-by Edward A. James <[email protected]>

---
 drivers/hwmon/occ/common.c | 3 ++-
 drivers/hwmon/occ/common.h | 2 ++
 drivers/hwmon/occ/p8_i2c.c | 4 +++-
 drivers/hwmon/occ/p9_sbe.c | 2 ++
 4 files changed, 9 insertions(+), 2 deletions(-)

drivers/hwmon/occ/common.c +2 -1

index a793834..3f63467 100644
@@ -166,7 +166,8 @@ void occ_parse_poll_response(struct occ *occ)
 void occ_set_error(struct occ *occ, int error)
 {
 	occ->error_count++;
-	occ->error = error;
+	if (occ->error_count > OCC_ERROR_COUNT_THRESHOLD)
+		occ->error = error;
 }
 
 void occ_reset_error(struct occ *occ)

drivers/hwmon/occ/common.h +2 -0

index ca5969c..acb50bc 100644
@@ -13,6 +13,8 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/sysfs.h>
 
+#define OCC_ERROR_COUNT_THRESHOLD	2
+
 #define OCC_UPDATE_FREQUENCY		msecs_to_jiffies(1000)
 #define OCC_RESP_DATA_BYTES		4089

drivers/hwmon/occ/p8_i2c.c +3 -1

index 05af16b..269cb91 100644
@@ -169,7 +169,7 @@ static int p8_i2c_occ_send_cmd(struct occ *occ, u8 *cmd)
 
 	data_length = get_unaligned_be16(&resp->data_length_be);
 	if (data_length > OCC_RESP_DATA_BYTES) {
-		rc = -EIO;
+		rc = -EMSGSIZE;
 		dev_warn(&client->dev, "occ bad data length:%d\n",
 			 data_length);
 		goto assign;

@@ -186,8 +186,10 @@ static int p8_i2c_occ_send_cmd(struct occ *occ, u8 *cmd)
 
 err:
 	dev_err(&client->dev, "i2c scom op failed rc:%d\n", rc);
+
 assign:
 	error = rc;
+
 done:
 	occ_set_error(occ, error);
 	return rc;

drivers/hwmon/occ/p9_sbe.c +2 -0

index 2d50a94..db30a2d 100644
@@ -86,8 +86,10 @@ static int p9_sbe_occ_send_cmd(struct occ *occ, u8 *cmd)
 err:
 	occ_drv_release(client);
 	dev_err(occ->bus_dev, "occ bus op failed rc:%d\n", rc);
+
 assign:
 	error = rc;
+
 done:
 	occ_set_error(occ, error);
 	return rc;

Signature · 1 line

1.8.3.1