xen/pci: Use acpi_noirq_set() helper
PATCH 1/1 xen/pci: Use acpi_noirq_set() helper
No need to keep an #ifdef since we have a helper (in x86 world). Use it instead.
--- arch/x86/pci/xen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/pci/xen.c +1 -3
@@ -409,10 +409,8 @@ int __init pci_xen_init(void) pcibios_enable_irq = xen_pcifront_enable_irq; pcibios_disable_irq =NULL ; -#ifdef CONFIG_ACPI /* Keep ACPI out of the picture */ - acpi_noirq =1 ; -#endif +acpi_noirq_set ();#ifdef CONFIG_PCI_MSI x86_msi.setup_msi_irqs = xen_setup_msi_irqs;
Signature · 1 line
2.11.0
Quoted 4 lines · Andy Shevchenko
No need to keep an #ifdef since we have a helper (in x86 world). Use it instead.
Signed-off-by Andy Shevchenko <[email protected]>
Looks reasonable to me, and I assume some non-PCI tree will take it.
Quoted 23 lines
--- arch/x86/pci/xen.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)arch/x86/pci/xen.c +1
-3@@ -409,10 +409,8 @@ int __init pci_xen_init(void) pcibios_enable_irq = xen_pcifront_enable_irq; pcibios_disable_irq =NULL ; -#ifdef CONFIG_ACPI /* Keep ACPI out of the picture */ - acpi_noirq =1 ; -#endif +acpi_noirq_set ();#ifdef CONFIG_PCI_MSI x86_msi.setup_msi_irqs = xen_setup_msi_irqs;Signature · 1 line
2.11.0
Quoted 7 lines · Bjorn Helgaas
Quoted 4 lines · Andy Shevchenko
No need to keep an #ifdef since we have a helper (in x86 world). Use it instead.
Signed-off-by Andy Shevchenko <[email protected]>Looks reasonable to me, and I assume some non-PCI tree will take it.
It seems either TODO list is long, or everyone from x86 is on vacation :-)
Can't you push this through your tree?
Quoted 24 lines
Quoted 24 lines
---
arch/x86/pci/xen.c | 4 +---1 file changed, 1 insertion(+), 3 deletions(-)arch/x86/pci/xen.c +0
-0@@ -409,10 +409,8 @@ int __init pci_xen_init(void) pcibios_enable_irq = xen_pcifront_enable_irq; pcibios_disable_irq = NULL;
-#ifdefCONFIG_ACPI
/* Keep ACPI out of the picture */arch/x86/pci/xen.c +1
-2- acpi_noirq =1 ; -#endif +acpi_noirq_set ();
#ifdefCONFIG_PCI_MSIx86_msi.setup_msi_irqs =xen_setup_msi_irqs; --
2.11.0
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Bjorn Helgaas
Quoted 3 lines · Andy Shevchenko
No need to keep an #ifdef since we have a helper (in x86 world). Use it instead.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Looks reasonable to me, and I assume some non-PCI tree will take it.
It seems either TODO list is long, or everyone from x86 is on vacation :-)
Can't you push this through your tree?
It might be lost in pile of mails, a gentle up.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy