ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform
Subsystems (3)
PATCH 1/1 ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform
From: Harsha Priya N <[email protected]>
Patch fixes cracking noise in rt5663 headphones for kbl platform by calling rt5663_sel_asrc_clk_src() for RT5663_AD_STEREO_FILTER to set ASRC.
The ASRC function is for asynchronous MCLK and LRCK. For RT5663 ASRC should be enabled to support special i2s clock format like Intel's 100fs. ASRC function will track i2s clock and generate corresponding system clock for codec. Calling this func helps select clock source for both RT5663_AD_STEREO_FILTER and RT5663_DA_STEREO_FILTER filters which fixes the crackling sound.
sound/soc/intel/boards/kbl_rt5663_max98927.c +5 -3
@@ -312,11 +312,13 @@ static int kabylake_rt5663_hw_params(struct snd_pcm_substream *substream,struct snd_soc_dai *codec_dai = rtd->codec_dai;int ret; - ret =snd_soc_dai_set_sysclk (codec_dai, -RT5663_SCLK_S_MCLK ,24576000 ,SND_SOC_CLOCK_IN );/* use ASRC for internal clocks, as PLL rate isn't multiple of BCLK */ -rt5663_sel_asrc_clk_src (codec_dai->codec,RT5663_DA_STEREO_FILTER ,1 ); +rt5663_sel_asrc_clk_src (codec_dai->codec, +RT5663_DA_STEREO_FILTER |RT5663_AD_STEREO_FILTER , +RT5663_CLK_SEL_I2S1_ASRC ); + ret =snd_soc_dai_set_sysclk (codec_dai, +RT5663_SCLK_S_MCLK ,24576000 ,SND_SOC_CLOCK_IN );if (ret <0 )dev_err (rtd->dev,"snd_soc_dai_set_sysclk err = %d\n" , ret);
Signature · 1 line
1.9.1
Quoted 8 lines · Naveen M
From: Harsha Priya N <[email protected]>
Patch fixes cracking noise in rt5663 headphones for kbl platform by calling
rt5663_sel_asrc_clk_src()forRT5663_AD_STEREO_FILTERto set ASRC.The ASRC function is for asynchronous MCLK and LRCK. For RT5663 ASRC should be enabled to support special i2s clock format like Intel's
^^^^^^
daouble space
it is not special, it is pcm format with 100fs
Quoted 37 lines
100fs. ASRC function will track i2s clock and generate corresponding system clock for codec. Calling this func helps select clock source for both
RT5663_AD_STEREO_FILTERandRT5663_DA_STEREO_FILTERfilters which fixes the crackling sound.Signed-off-by Harsha Priya <[email protected]>Signed-off-by Shruthi Sudhakar <[email protected]>Signed-off-by Naveen M <[email protected]>sound/soc/intel/boards/kbl_rt5663_max98927.c +5
-3@@ -312,11 +312,13 @@ static int kabylake_rt5663_hw_params(struct snd_pcm_substream *substream,struct snd_soc_dai *codec_dai = rtd->codec_dai;int ret; - ret =snd_soc_dai_set_sysclk (codec_dai, -RT5663_SCLK_S_MCLK ,24576000 ,SND_SOC_CLOCK_IN );/* use ASRC for internal clocks, as PLL rate isn't multiple of BCLK */ -rt5663_sel_asrc_clk_src (codec_dai->codec,RT5663_DA_STEREO_FILTER ,1 ); +rt5663_sel_asrc_clk_src (codec_dai->codec, +RT5663_DA_STEREO_FILTER |RT5663_AD_STEREO_FILTER , +RT5663_CLK_SEL_I2S1_ASRC ); + ret =snd_soc_dai_set_sysclk (codec_dai, +RT5663_SCLK_S_MCLK ,24576000 ,SND_SOC_CLOCK_IN );if (ret <0 )dev_err (rtd->dev,"snd_soc_dai_set_sysclk err = %d\n" , ret);Signature · 6 lines
1.9.1 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Signature · 1 line
~Vinod
Mark Brown
maintainerApplied "ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform" to the asoc tree
In reply to Naveen MThe patch
ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake platform
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
d46b1828406f74bc2d9ffe15e9a7b76ddbffbf7fMon Sep 17 00:00:00 2001
From: Harsha Priya N <[email protected]>
Date: Wed, 16 Aug 2017 16:19:55 +0530
Subject: [PATCH] ASoC: Intel: kbl: Enabling ASRC for RT5663 codec on kabylake
platform
Patch fixes cracking noise in rt5663 headphones for kbl platform by calling rt5663_sel_asrc_clk_src() for RT5663_AD_STEREO_FILTER to set ASRC.
The ASRC function is for asynchronous MCLK and LRCLK. For RT5663 ASRC should be enabled to support pcm format with 100fs.
ASRC function will track i2s clock and generate corresponding system clock for codec. Calling this func helps select clock source for both RT5663_AD_STEREO_FILTER and RT5663_DA_STEREO_FILTER filters which fixes the crackling sound.
--- sound/soc/intel/boards/kbl_rt5663_max98927.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
sound/soc/intel/boards/kbl_rt5663_max98927.c +5 -3
@@ -356,11 +356,13 @@ static int kabylake_rt5663_hw_params(struct snd_pcm_substream *substream,struct snd_soc_dai *codec_dai = rtd->codec_dai;int ret; - ret =snd_soc_dai_set_sysclk (codec_dai, -RT5663_SCLK_S_MCLK ,24576000 ,SND_SOC_CLOCK_IN );/* use ASRC for internal clocks, as PLL rate isn't multiple of BCLK */ -rt5663_sel_asrc_clk_src (codec_dai->codec,RT5663_DA_STEREO_FILTER ,1 ); +rt5663_sel_asrc_clk_src (codec_dai->codec, +RT5663_DA_STEREO_FILTER |RT5663_AD_STEREO_FILTER , +RT5663_CLK_SEL_I2S1_ASRC ); + ret =snd_soc_dai_set_sysclk (codec_dai, +RT5663_SCLK_S_MCLK ,24576000 ,SND_SOC_CLOCK_IN );if (ret <0 )dev_err (rtd->dev,"snd_soc_dai_set_sysclk err = %d\n" , ret);
Signature · 1 line
2.13.3