Skip to contentSkip to conversation

Patch "xfs: Fix leak of discard bio" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Aug 14, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

xfs: Fix leak of discard bio

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
xfs-fix-leak-of-discard-bio.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ea7bd56fa309d10a41b1041827a63c0746c47554 Mon Sep 17 00:00:00 2001

From: Jan Kara <[email protected]>
Date: Wed, 2 Aug 2017 12:37:16 -0700
Subject: xfs: Fix leak of discard bio

From: Jan Kara <[email protected]>

commit ea7bd56fa309d10a41b1041827a63c0746c47554 upstream.

The bio describing discard operation is allocated by __blkdev_issue_discard() which returns us a reference to it. That reference is never released and thus we leak this bio. Drop the bio reference once it completes in xlog_discard_endio().

Fixes 4560e78f40cb55bd2ea8f1ef4001c5baa88531c7
---
 fs/xfs/xfs_log_cil.c |    1 +
 1 file changed, 1 insertion(+)
fs/xfs/xfs_log_cil.c +1 -0
@@ -519,6 +519,7 @@ xlog_discard_endio(
 
 	INIT_WORK(&ctx->discard_endio_work, xlog_discard_endio_work);
 	queue_work(xfs_discard_wq, &ctx->discard_endio_work);
+	bio_put(bio);
 }
 
 static void

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/xfs-fix-leak-of-discard-bio.patch