Skip to contentSkip to conversation

drm/ttm:fix missing inc bo_count

PATCH In review Monk Liu 3 participants 4 messages Aug 14, 2017 – Aug 24, 2017 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore

Monk Liu

author
#0 lore raw

PATCH 1/1 drm/ttm:fix missing inc bo_count

From: Monk Liu <[email protected]>

Change-Id I32ed928e59db5478e429189ac8b010e336e45a94
---
 drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/ttm/ttm_bo_util.c +1 -0
index d0459b3..c934ad5 100644
@@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo,
 	 * TODO: Explicit member copy would probably be better here.
 	 */
 
+	atomic_inc(&bo->glob->bo_count);
 	INIT_LIST_HEAD(&fbo->ddestroy);
 	INIT_LIST_HEAD(&fbo->lru);
 	INIT_LIST_HEAD(&fbo->swap);
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1502682217-8920-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 14.08.2017 um 05:43 schrieb Monk Liu:

Quoted 4 lines

From: Monk Liu <[email protected]>

Change-Id I32ed928e59db5478e429189ac8b010e336e45a94

Nice catch, patch is Reviewed-by: Christian König <[email protected]>

Please ping me if those TTM patches need a whitelisting in our internal git server.

Christian.

Quoted 9 lines
---
  drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/ttm/ttm_bo_util.c +0 -0
index d0459b3..c934ad5 100644

drivers/gpu/drm/ttm/ttm_bo_util.c static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo, · line 475

Quoted 7 lines
drivers/gpu/drm/ttm/ttm_bo_util.c +1 -0
@@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct ttm_buffer_object *bo,
  	 * TODO: Explicit member copy would probably be better here.
  	 */
 
+	atomic_inc(&bo->glob->bo_count);
  	INIT_LIST_HEAD(&fbo->ddestroy);
  	INIT_LIST_HEAD(&fbo->lru);
  	INIT_LIST_HEAD(&fbo->swap);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Monk Liu
Sent: Sunday, August 13, 2017 11:44 PM
To: [email protected]
Cc: Liu, Monk
Subject: [PATCH] drm/ttm:fix missing inc bo_count

Quoted 4 lines

From: Monk Liu <[email protected]>

Change-Id I32ed928e59db5478e429189ac8b010e336e45a94

Did these ever land? I don't remember seeing them in the 4.12 branch.

Alex

Quoted 21 lines
---
 drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/ttm/ttm_bo_util.c +1 -0
index d0459b3..c934ad5 100644
@@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct
 ttm_buffer_object *bo,
 	 * TODO: Explicit member copy would probably be better here.
 	 */
 
+	atomic_inc(&bo->glob->bo_count);
 	INIT_LIST_HEAD(&fbo->ddestroy);
 	INIT_LIST_HEAD(&fbo->lru);

INIT_LIST_HEAD(&fbo->swap);
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): CY4PR12MB165398961A33FDBE93B32992F7850-rpdhrqHFk06apTa93KjAaQdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

author
#5 lore raw

Thanks,that one is somehow missed !
Just pushed

-----Original Message-----
From: Deucher, Alexander
Sent: Wednesday, August 23, 2017 9:34 PM
To: Liu, Monk <[email protected]>; [email protected]
Cc: Liu, Monk <[email protected]>
Subject: RE: [PATCH] drm/ttm:fix missing inc bo_count

Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Monk Liu
Sent: Sunday, August 13, 2017 11:44 PM
To: [email protected]
Cc: Liu, Monk
Subject: [PATCH] drm/ttm:fix missing inc bo_count

Quoted 4 lines

From: Monk Liu <[email protected]>

Change-Id I32ed928e59db5478e429189ac8b010e336e45a94

Did these ever land? I don't remember seeing them in the 4.12 branch.

Alex

Quoted 21 lines
---
 drivers/gpu/drm/ttm/ttm_bo_util.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/ttm/ttm_bo_util.c +1 -0
index d0459b3..c934ad5 100644
@@ -469,6 +469,7 @@ static int ttm_buffer_object_transfer(struct 
 ttm_buffer_object *bo,
 	 * TODO: Explicit member copy would probably be better here.
 	 */
 
+	atomic_inc(&bo->glob->bo_count);
 	INIT_LIST_HEAD(&fbo->ddestroy);
 	INIT_LIST_HEAD(&fbo->lru);

INIT_LIST_HEAD(&fbo->swap);
--
2.7.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx