drm/amdgpu/virtual_dce: Virtual display doesn't support disable vblank immediately
Subsystems (2)
PATCH 1/1 drm/amdgpu/virtual_dce: Virtual display doesn't support disable vblank immediately
For virtual display, it uses software timer to emulate the vsync interrupt, it doesn't have high precision, so doesn't support disable vblank immediately.
BUG: SWDEV-129274
Signed-off-by Emily Deng <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +5 -3
@@ -237,9 +237,11 @@ int amdgpu_irq_init(struct amdgpu_device *adev) }if (!amdgpu_device_has_dc_support (adev)) { -/* Disable vblank irqs aggressively for power-saving */ -/* XXX: can this be enabled for DC? */ - adev->ddev->vblank_disable_immediate = true; +if (!adev->enable_virtual_display) { +/* Disable vblank irqs aggressively for power-saving */ +/* XXX: can this be enabled for DC? */ + adev->ddev->vblank_disable_immediate = true; + } r =drm_vblank_init (adev->ddev, adev->mode_info.num_crtc);if (r)
Signature · 6 lines
1.9.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1503035321-28800-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org
Michel Dänzer
Reviewed-byQuoted 20 lines · Emily Deng
For virtual display, it uses software timer to emulate the vsync interrupt, it doesn't have high precision, so doesn't support disable vblank immediately.
BUG: SWDEV-129274Signed-off-by Emily Deng <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +0
-1@@ -237,9 +237,11 @@ int amdgpu_irq_init(struct amdgpu_device *adev) }if (!amdgpu_device_has_dc_support (adev)) { -/* Disable vblank irqs aggressively for power-saving */
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c int amdgpu_irq_init(struct amdgpu_device *adev) · line 247
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c +5
-2-/* XXX: can this be enabled for DC? */ - adev->ddev->vblank_disable_immediate = true; +if (!adev->enable_virtual_display) { +/* Disable vblank irqs aggressively for power-saving */ +/* XXX: can this be enabled for DC? */ + adev->ddev->vblank_disable_immediate = true; + } r =drm_vblank_init (adev->ddev, adev->mode_info.num_crtc);if (r)
Reviewed-by Michel Dänzer <[email protected]>
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx