drm/ttm: use reservation_object_trylock in ttm_bo_individualize_resv v2
Subsystems (3)
PATCH 1/1 drm/ttm: use reservation_object_trylock in ttm_bo_individualize_resv v2
From: Christian König <[email protected]>
Fixes a false positive from might_sleep(). The reservation object is freshly initialized, so nobody else can hold the mutex but the function is called from atomic context.
v2: Correctly invert the check as well.
--- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/ttm/ttm_bo.c +1 -1
@@ -403,7 +403,7 @@ static int ttm_bo_individualize_resv(struct ttm_buffer_object *bo)return 0 ;reservation_object_init (&bo->ttm_resv); -BUG_ON (reservation_object_lock (&bo->ttm_resv,NULL )); +BUG_ON (!reservation_object_trylock (&bo->ttm_resv)); r =reservation_object_copy_fences (&bo->ttm_resv, bo->resv);if (r) {
Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): 1503063097-2542-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org
Deucher, Alexander
Reviewed-by Alex DeucherQuoted 10 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Christian König
Sent: Friday, August 18, 2017 9:32 AM
To: [email protected]; [email protected]
Subject: [PATCH] drm/ttm: usereservation_object_trylockinttm_bo_individualize_resvv2From: Christian König <[email protected]>
Quoted 7 lines
Fixes a false positive from
might_sleep(). The reservation object is freshly initialized, so nobody else can hold the mutex but the function is called from atomic context.v2: Correctly invert the check as well.
Signed-off-by Christian König <[email protected]>
Quoted 21 lines
--- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/ttm/ttm_bo.c +1
-1@@ -403,7 +403,7 @@ static int ttm_bo_individualize_resv(struct ttm_buffer_object *bo)return 0 ;reservation_object_init (&bo->ttm_resv); -BUG_ON (reservation_object_lock (&bo->ttm_resv,NULL )); +BUG_ON (!reservation_object_trylock (&bo->ttm_resv)); r =reservation_object_copy_fences (&bo->ttm_resv, bo->resv);if (r) {
--
2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx