ASoC: qcom: Remove unnecessary function call
Subsystems (3)
PATCH 9/12 ASoC: qcom: Remove unnecessary function call
First of all,the address of pdev->dev is assigned to card->dev,then the function platform_set_drvdata copies the value the variable card to pdev->dev.driver_data, but when calling snd_soc_register_card,the function dev_set_drvdata(card->dev, card) will also do the same copy operation,so i think that the former copy operation can be removed.
Signed-off-by Peng Donglin <[email protected]>
--- sound/soc/qcom/storm.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/qcom/storm.c +0 -1
@@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev)return -ENOMEM ; card->dev = &pdev->dev; -platform_set_drvdata (pdev, card); ret =snd_soc_of_parse_card_name (card,"qcom,model" );if (ret) {
Signature · 1 line
1.9.1
Quoted 7 lines · Peng Donglin
First of all,the address of
pdev->devis assigned to card->dev,then the functionplatform_set_drvdatacopies the value the variable card topdev->dev.driver_data, but when calling snd_soc_register_card,the functiondev_set_drvdata(card->dev, card)will also do the same copy operation,so i think that the former copy operation can be removed.Signed-off-by Peng Donglin <[email protected]>
Acked-by Banajit Goswami <[email protected]>
Quoted 23 lines
--- sound/soc/qcom/storm.c | 1 - 1 file changed, 1 deletion(-)sound/soc/qcom/storm.c +0
-1@@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev)return -ENOMEM ; card->dev = &pdev->dev; -platform_set_drvdata (pdev, card); ret =snd_soc_of_parse_card_name (card,"qcom,model" );if (ret) {Signature · 6 lines
1.9.1 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel