drm/i915: Add more latency to avoid display flicker
Subsystems (2)
PATCH 1/1 drm/i915: Add more latency to avoid display flicker
From: "Lee, Shawn C" <[email protected]>
LFP flicker with latest drm-nightly on customer board. After increase latency value and this symptom can't be reproduced.
TEST=Reboot DUT and no flicking on LFP.
--- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +1 -1
@@ -4410,7 +4410,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, latency +=4 ;if (apply_memory_bw_wa && x_tiled) - latency +=15 ; + latency +=60 ;if (plane->id ==PLANE_CURSOR ) { width = intel_pstate->base.crtc_w;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Add more latency to avoid display flicker
== Series Details ==
== Series Details ==
Series: drm/i915: Add more latency to avoid display flicker
URL : https://patchwork.freedesktop.org/series/29136/
State : success
== Summary ==
Series 29136v1 drm/i915: Add more latency to avoid display flicker
https://patchwork.freedesktop.org/api/1.0/series/29136/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:457s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:442s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:367s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:564s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:252s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:526s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:527s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:525s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:439s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:615s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:445s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:423s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:428s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:502s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:477s fi-kbl-7260u total:279 pass:268 dwarn:1 dfail:0 fail:0 skip:10 time:500s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:485s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:600s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:594s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:527s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:472s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:479s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:487s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:440s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:484s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:558s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:414s
dbfb2f62576e1c3550d10398b097589959356db3 drm-tip: 2017y-08m-21d-08h-13m-34s UTC integration manifest f10f2264a28e drm/i915: Add more latency to avoid display flicker
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5458/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi,
Adding random latency is not a right solution for any flicker.
This will affect the configuration which can be supported in all other platforms. There are many unanswered questions here:
Which customer? which platform? changes & root-cause of the issue?
Please find what are the changes in customer board & according to root-cause of issue add WA with proper reasoning & only for affected platforms.
-Mahesh
Quoted 20 lines · Shawn C
From: "Lee, Shawn C" <[email protected]>
LFP flicker with latest drm-nightly on customer board. After increase latency value and this symptom can't be reproduced.
TEST=Reboot DUT and no flicking on LFP.
Cc Kumar, Mahesh <[email protected]>Cc Gary C Wang <[email protected]>Signed-off-by Shawn Lee <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_pm.c +0
-0
drivers/gpu/drm/i915/intel_pm.c static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, · line 4416
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.c +1
-1@@ -4410,7 +4410,7 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, latency +=4 ;if (apply_memory_bw_wa && x_tiled) - latency +=15 ; + latency +=60 ;if (plane->id ==PLANE_CURSOR ) { width = intel_pstate->base.crtc_w;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx