Skip to contentSkip to conversation

irqchip: mmp: make mmp_intc_conf const

PATCH In review Bhumika Goyal 2 participants 2 messages Aug 24, 2017 irqchip drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip: mmp: make mmp_intc_conf const

Make these const as they are only used during a copy operation. Done using Coccinelle.

@match disable optional_qualifier@
identifier s;
@@
static struct mmp_intc_conf s = {...};

@ref@
position p;
identifier match.s;
@@
s@p

@good1@
position ref.p;
identifier match.s,f,c;
expression e;
@@
(
e = s@p
|
e = [email protected]
|
c(...,[email protected],...)
|
c(...,s@p,...)
)

@bad depends on !good1@
position ref.p;
identifier match.s;
@@
s@p

@depends on forall !bad disable optional_qualifier@ identifier match.s;
@@
static
+ const
struct mmp_intc_conf s;

---
 drivers/irqchip/irq-mmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/irqchip/irq-mmp.c +2 -2
index 013fc96..25f32e1 100644
@@ -181,13 +181,13 @@ static int mmp_irq_domain_xlate(struct irq_domain *d, struct device_node *node,
 	.xlate		= mmp_irq_domain_xlate,
 };
 
-static struct mmp_intc_conf mmp_conf = {
+static const struct mmp_intc_conf mmp_conf = {
 	.conf_enable	= 0x51,
 	.conf_disable	= 0x0,
 	.conf_mask	= 0x7f,
 };
 
-static struct mmp_intc_conf mmp2_conf = {
+static const struct mmp_intc_conf mmp2_conf = {
 	.conf_enable	= 0x20,
 	.conf_disable	= 0x0,
 	.conf_mask	= 0x7f,
Signature · 1 line
1.9.1
#1 lore raw
Quoted 35 lines · Bhumika Goyal

Make these const as they are only used during a copy operation. Done using Coccinelle.

@match disable optional_qualifier@
identifier s;
@@
static struct mmp_intc_conf s = {...};

@ref@
position p;
identifier match.s;
@@
s@p

@good1@
position ref.p;
identifier match.s,f,c;
expression e;
@@
(
e = s@p
|
e = [email protected]
|
c(...,[email protected],...)
|
c(...,s@p,...)
)

@bad depends on !good1@
position ref.p;
identifier match.s;
@@
s@p

Quoted 8 lines

@depends on forall !bad disable optional_qualifier@ identifier match.s;
@@
static
+ const
struct mmp_intc_conf s;

Can you please post these fixes as a series instead of individual patches? It would make the maintainers' life much easier. I'll apply this patch anyway, but please keep this in mind for the future.

Thanks,

	M.
Signature · 1 line
Jazz is not dead, it just smell funny.