Skip to contentSkip to conversation

icorem6: Fix to find MMC devices

PATCH New Jagan Teki 2 participants 4 messages Aug 25, 2017 – Aug 29, 2017 Arm i.MX and Layerscape

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/1 icorem6: Fix to find MMC devices

From: Jagan Teki <[email protected]>

U-Boot proper is using DM_MMC so, enable CONFIG_BLK otherwise find_mmc_device failed to detect MMC device.

Signed-off-by Jagan Teki <[email protected]>
---
 configs/imx6qdl_icore_mmc_defconfig | 1 -
 configs/imx6qdl_icore_rqs_defconfig | 1 -
 2 files changed, 2 deletions(-)
configs/imx6qdl_icore_mmc_defconfig +0 -1
index ec39d09..9d61c48 100644
@@ -36,7 +36,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore imx6dl-icore"
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_SMSC=y
configs/imx6qdl_icore_rqs_defconfig +0 -1
index ba3ac1b..319a88d 100644
@@ -34,7 +34,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore-rqs imx6dl-icore-rqs"
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 icorem6: Fix to find MMC devices

Hi Jagan,

Quoted 16 lines · Jagan Teki

From: Jagan Teki <[email protected]>

U-Boot proper is using DM_MMC so, enable CONFIG_BLK otherwise find_mmc_device failed to detect MMC device.

Signed-off-by Jagan Teki <[email protected]>
---
 configs/imx6qdl_icore_mmc_defconfig | 1 -
 configs/imx6qdl_icore_rqs_defconfig | 1 -
 2 files changed, 2 deletions(-)
configs/imx6qdl_icore_mmc_defconfig +0 -0
index ec39d09..9d61c48 100644

configs/imx6qdl_icore_mmc_defconfig CONFIG_CMD_EXT4_WRITE=y · line 39

Quoted 4 lines
configs/imx6qdl_icore_mmc_defconfig +0 -1
@@ -36,7 +36,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore imx6dl-icore"
-# CONFIG_BLK is not set

OT: it is quite strange that removing a "commented" line we change the behaviour, but that is in this case !

Quoted 9 lines
configs/imx6qdl_icore_mmc_defconfig +0 -0
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_SMSC=y
configs/imx6qdl_icore_rqs_defconfig +0 -0
index ba3ac1b..319a88d 100644

configs/imx6qdl_icore_rqs_defconfig CONFIG_CMD_EXT4_WRITE=y · line 39

Quoted 7 lines
configs/imx6qdl_icore_rqs_defconfig +0 -1
@@ -34,7 +34,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore-rqs imx6dl-icore-rqs"
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y
Reviewed-by Stefano Babic <[email protected]>

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
author
#2 lore raw

PATCH 1/1 icorem6: Fix to find MMC devices

Quoted 14 lines · Stefano Babic

Hi Jagan,

Quoted 11 lines · Jagan Teki

From: Jagan Teki <[email protected]>

U-Boot proper is using DM_MMC so, enable CONFIG_BLK otherwise find_mmc_device failed to detect MMC device.

Signed-off-by Jagan Teki <[email protected]>
---
 configs/imx6qdl_icore_mmc_defconfig | 1 -
 configs/imx6qdl_icore_rqs_defconfig | 1 -
 2 files changed, 2 deletions(-)
Quoted 12 lines

configs/imx6qdl_icore_mmc_defconfig CONFIG_CMD_EXT4_WRITE=y · line 39

Quoted 9 lines
configs/imx6qdl_icore_mmc_defconfig +0 -1
index ec39d09..9d61c48 100644
@@ -36,7 +36,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore imx6dl-icore"
-# CONFIG_BLK is not set

OT: it is quite strange that removing a "commented" line we change the behaviour, but that is in this case !

Yeah, this is forcing to use mmc_legacy even with DM_MMC because of SPL need. _BLK will enabled by default with DM_MMC so this make U-Boot proper not to use mmc_legacy and go with BLK.

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#3 lore raw

PATCH 1/1 icorem6: Fix to find MMC devices

In reply to Jagan Teki
Quoted 29 lines · Jagan Teki

From: Jagan Teki <[email protected]>

U-Boot proper is using DM_MMC so, enable CONFIG_BLK otherwise find_mmc_device failed to detect MMC device.

Signed-off-by Jagan Teki <[email protected]>
---
 configs/imx6qdl_icore_mmc_defconfig | 1 -
 configs/imx6qdl_icore_rqs_defconfig | 1 -
 2 files changed, 2 deletions(-)
configs/imx6qdl_icore_mmc_defconfig +0 -1
index ec39d09..9d61c48 100644
@@ -36,7 +36,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore imx6dl-icore"
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_SMSC=y
configs/imx6qdl_icore_rqs_defconfig +0 -0
index ba3ac1b..319a88d 100644

configs/imx6qdl_icore_rqs_defconfig CONFIG_CMD_EXT4_WRITE=y · line 39

Quoted 7 lines
configs/imx6qdl_icore_rqs_defconfig +0 -1
@@ -34,7 +34,6 @@ CONFIG_CMD_EXT4_WRITE=y
 CONFIG_CMD_FAT=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_OF_LIST="imx6q-icore-rqs imx6dl-icore-rqs"
-# CONFIG_BLK is not set
 CONFIG_SYS_I2C_MXC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_MICREL=y

Applied to u-boot-imx, -master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================