Patch "netfilter: expect: fix crash when putting uninited expectation" has been added to the 4.12-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
netfilter: expect: fix crash when putting uninited expectation
to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
netfilter-expect-fix-crash-when-putting-uninited-expectation.patch
and it can be found in the queue-4.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
36ac344e16e04e3e55e8fed7446095a6458c64e6Mon Sep 17 00:00:00 2001
From: Florian Westphal <[email protected]>
Date: Mon, 10 Jul 2017 13:53:53 +0200
Subject: netfilter: expect: fix crash when putting uninited expectation
From: Florian Westphal <[email protected]>
commit 36ac344e16e04e3e55e8fed7446095a6458c64e6 upstream.
We crash in __nf_ct_expect_check, it calls nf_ct_remove_expect on the uninitialised expectation instead of existing one, so del_timer chokes on random memory address.
--- net/netfilter/nf_conntrack_expect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nf_conntrack_expect.c +1 -1
@@ -422,7 +422,7 @@ static inline int __nf_ct_expect_check(s h =nf_ct_expect_dst_hash (net, &expect->tuple);hlist_for_each_entry_safe (i, next, &nf_ct_expect_hash[h], hnode) {if (expect_matches (i, expect)) { -if (nf_ct_remove_expect (expect)) +if (nf_ct_remove_expect (i))break ; }else if (expect_clash (i, expect)) { ret = -EBUSY ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.12/netfilter-nfnetlink-improve-input-length-sanitization-in-nfnetlink_rcv.patch queue-4.12/netfilter-expect-fix-crash-when-putting-uninited-expectation.patch queue-4.12/netfilter-nat-fix-src-map-lookup.patch