Skip to contentSkip to conversation

Patch "ASoC: rsnd: Add missing initialization of ADG req_rate" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Aug 28, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ASoC: rsnd: Add missing initialization of ADG req_rate

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
asoc-rsnd-add-missing-initialization-of-adg-req_rate.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 8b27418f300cafbdbbb8cfa9c29d398ed34d6723 Mon Sep 17 00:00:00 2001

From: Geert Uytterhoeven <[email protected]>
Date: Wed, 28 Oct 2015 16:03:48 +0100
Subject: ASoC: rsnd: Add missing initialization of ADG req_rate

From: Geert Uytterhoeven <[email protected]>

commit 8b27418f300cafbdbbb8cfa9c29d398ed34d6723 upstream.

If the "clock-frequency" DT property is not found, req_rate is used uninitialized, and the "audio_clkout" clock will be created with an arbitrary clock rate.

This uninitialized kernel stack data may leak to userspace through /sys/kernel/debug/clk/clk_summary, cfr. the value in the "rate" column:

clock enable_cnt prepare_cnt rate accuracy phase
--------------------------------------------------------------------
audio_clkout 0 0 4001836240 0 0

---
 sound/soc/sh/rcar/adg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/sh/rcar/adg.c +1 -1
@@ -437,7 +437,7 @@ static void rsnd_adg_get_clkout(struct r
 	struct device *dev = rsnd_priv_to_dev(priv);
 	struct device_node *np = dev->of_node;
 	u32 ckr, rbgx, rbga, rbgb;
-	u32 rate, req_rate, div;
+	u32 rate, req_rate = 0, div;
 	uint32_t count = 0;
 	unsigned long req_48kHz_rate, req_441kHz_rate;
 	int i;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/asoc-rsnd-add-missing-initialization-of-adg-req_rate.patch