Patch "ntb: transport shouldn't disable link due to bogus values in SPADs" has been added to the 4.12-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
ntb: transport shouldn't disable link due to bogus values in SPADs
to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ntb-transport-shouldn-t-disable-link-due-to-bogus-values-in-spads.patch
and it can be found in the queue-4.12 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f3fd2afed8eee91620d05b69ab94c14793c849d7Mon Sep 17 00:00:00 2001
From: Dave Jiang <[email protected]>
Date: Fri, 28 Jul 2017 15:10:48 -0700
Subject: ntb: transport shouldn't disable link due to bogus values in SPADs
From: Dave Jiang <[email protected]>
commit f3fd2afed8eee91620d05b69ab94c14793c849d7 upstream.
It seems that under certain scenarios the SPAD can have bogus values caused by an agent (i.e. BIOS or other software) that is not the kernel driver, and that causes memory window setup failure. This should not cause the link to be disabled because if we do that, the driver will never recover again. We have verified in testing that this issue happens and prevents proper link recovery.
--- drivers/ntb/ntb_transport.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/ntb/ntb_transport.c +1 -3
@@ -920,10 +920,8 @@ out1:ntb_free_mw (nt, i);/* if there's an actual failure, we should just bail */ -if (rc <0 ) { -ntb_link_disable (ndev); +if (rc <0 )return ; - } out:if (ntb_link_is_up (ndev,NULL ,NULL ) ==1 )
Patches currently in stable-queue which might be from [email protected] are
queue-4.12/ntb-transport-shouldn-t-disable-link-due-to-bogus-values-in-spads.patch