tests/kms_atomic: subtest atomic_invalid_params requires CRTC
PATCH 1/1 tests/kms_atomic: subtest atomic_invalid_params requires CRTC
Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_params. This leads to segfault on machines where the subtest should be skipped.
--- tests/kms_atomic.c | 1 + 1 file changed, 1 insertion(+)
tests/kms_atomic.c +1 -0
@@ -1596,6 +1596,7 @@ igt_mainstruct kms_atomic_connector_state *conn =find_connector (scratch, crtc); +igt_require (crtc);igt_require (plane);igt_require (conn);atomic_invalid_params (crtc, plane, conn);
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
In my view, this is a valid check.
Quoted 22 lines · Marta Lofstedt
Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para ms.
This leads to segfault on machines where the subtest should be skipped.Signed-off-by Marta Lofstedt <[email protected]>---
tests/kms_atomic.c | 1 +1 file changed, 1 insertion(+)tests/kms_atomic.c +0
-0@@ -1596,6 +1596,7 @@ igt_mainstruct
kms_atomic_connector_state*conn =find_connector(scratch, crtc);tests/kms_atomic.c +1
-0+igt_require (crtc);
igt_require(plane);igt_require(conn);atomic_invalid_params(crtc, plane, conn);
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Mika Kahola
In my view, this is a valid check.
Reviewed-by Mika Kahola <[email protected]>Quoted 6 lines · Marta Lofstedt
Check for valid crtc is missing in igt@kms_atomic@atomic_invalid_para ms.
This leads to segfault on machines where the subtest should be skipped.Signed-off-by Marta Lofstedt <[email protected]>
pushed
thanks for the patch and the review :-)
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for tests/kms_atomic: subtest atomic_invalid_params requires CRTC
In reply to Marta Lofstedt== Series Details ==
== Series Details ==
Series: tests/kms_atomic: subtest atomic_invalid_params requires CRTC
URL : https://patchwork.freedesktop.org/series/29464/
State : success
== Summary ==
IGT patchset tested on top of latest successful build bf45d253648250fc402eee02237366c8882b2053 igt: Add gem_close
with latest DRM-Tip kernel build CI_DRM_3014627598734e5e drm-tip: 2017y-08m-29d-09h-52m-12s UTC integration manifest
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215 +1fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:459s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:444s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:361s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:557s fi-bwr-2160 total:279 pass:184 dwarn:0 dfail:0 fail:0 skip:95 time:254s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:523s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:525s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:516s fi-elk-e7500 total:279 pass:230 dwarn:0 dfail:0 fail:0 skip:49 time:443s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:612s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:448s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:423s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:423s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:498s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:480s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:600s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:600s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:525s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:481s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:488s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:446s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:489s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:552s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:404s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_116/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for tests/kms_atomic: subtest atomic_invalid_params requires CRTC
In reply to Marta Lofstedt== Series Details ==
== Series Details ==
Series: tests/kms_atomic: subtest atomic_invalid_params requires CRTC
URL : https://patchwork.freedesktop.org/series/29464/
State : success
== Summary ==
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-C-planes:
skip -> PASS (shard-hsw)
Subgroup plane-position-hole-dpms-pipe-C-planes:
skip -> PASS (shard-hsw)
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test kms_setmode:
Subgroup basic:
pass -> FAIL (shard-hsw) fdo#99912
Test kms_properties:
Subgroup plane-properties-legacy:
skip -> PASS (shard-hsw)
Test kms_atomic_transition:
Subgroup plane-all-transition-fencing:
skip -> PASS (shard-hsw)fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
shard-hsw total:2230 pass:1230 dwarn:0 dfail:0 fail:18 skip:982 time:9693s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_116/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx