Skip to contentSkip to conversation

rk3288: Add Vyasa initial board support

PATCH Superseded Jagan Teki 2 participants 8 messages Aug 29, 2017 – Sep 12, 2017

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Rockchip

v3 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

From: Jagan Teki <[email protected]>

This patch adds support for Vyasa RK3288 initial board from Amarula Solutions.

Boot from SDMMC:
---------------
U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45) Trying to boot from MMC1

U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)

Model: Amarula Vyasa-RK3288
DRAM:  2 GiB
MMC:   dwmmc at ff0c0000: 1

*** Warning - bad CRC, using default environment

In:    serial at ff690000
Out:   serial at ff690000
Err:   serial at ff690000
Model: Amarula Vyasa-RK3288
Net:   Net Initialization Skipped

No ethernet found.
Hit any key to stop autoboot: 0
=>

Reviewed-by Simon Glass <[email protected]>
Signed-off-by Jagan Teki <[email protected]>

---
Changes for v3:
- Remove CONFIG_ENV_IS_IN_MMC from include file
- Update commit message with company name
- Fix proper board name on MAINTAINERS file
Changes for v2:
- Fix commit message
- Move CONFIG_ENV_IS_IN_MMC to configs

 arch/arm/dts/Makefile                     |   1 +
 arch/arm/dts/rk3288-vyasa.dts             | 327 ++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/rk3288/Kconfig     |  11 +
 board/amarula/vyasa-rk3288/Kconfig        |  12 ++
 board/amarula/vyasa-rk3288/MAINTAINERS    |   6 +
 board/amarula/vyasa-rk3288/Makefile       |   7 +
 board/amarula/vyasa-rk3288/vyasa-rk3288.c |   7 +
 configs/vyasa-rk3288_defconfig            |  63 ++++++
 include/configs/vyasa-rk3288.h            |  22 ++
 9 files changed, 456 insertions(+)
 create mode 100644 arch/arm/dts/rk3288-vyasa.dts
 create mode 100644 board/amarula/vyasa-rk3288/Kconfig
 create mode 100644 board/amarula/vyasa-rk3288/MAINTAINERS
 create mode 100644 board/amarula/vyasa-rk3288/Makefile
 create mode 100644 board/amarula/vyasa-rk3288/vyasa-rk3288.c
 create mode 100644 configs/vyasa-rk3288_defconfig
 create mode 100644 include/configs/vyasa-rk3288.h
arch/arm/dts/Makefile +1 -0
index d07715f..371511b 100644
@@ -41,6 +41,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += \
 	rk3288-veyron-jerry.dtb \
 	rk3288-veyron-mickey.dtb \
 	rk3288-veyron-minnie.dtb \
+	rk3288-vyasa.dtb \
 	rk3328-evb.dtb \
 	rk3368-lion.dtb \
 	rk3368-sheep.dtb \
arch/arm/dts/rk3288-vyasa.dts new file +327 -0

327 lines not on this page · raw message

arch/arm/mach-rockchip/rk3288/Kconfig +11 -0
index 53cc9a0..4ad2940 100644
@@ -84,6 +84,15 @@ config TARGET_POPMETAL_RK3288
 	  2GB DDR3. Expansion connectors provide access to I2C, SPI, UART,
 	  GPIOs and display interface.
 
+config TARGET_VYASA_RK3288
+	bool "Vyasa-RK3288"
+	select BOARD_LATE_INIT
+	help
+	  Vyasa is a RK3288-based development board with 2 USB ports,
+	  HDMI, VGA, micro-SD card, audio, WiFi  and Gigabit Ethernet, It
+	  also includes on-board eMMC and 2GB of SDRAM. Expansion connectors
+	  provide access to display pins, I2C, SPI, UART and GPIOs.
+
 config TARGET_ROCK2
 	bool "Radxa Rock 2"
 	select BOARD_LATE_INIT

@@ -129,6 +138,8 @@ config SPL_LIBGENERIC_SUPPORT
 config SPL_SERIAL_SUPPORT
 	default y
 
+source "board/amarula/vyasa-rk3288/Kconfig"
+
 source "board/chipspark/popmetal_rk3288/Kconfig"
 
 source "board/firefly/firefly-rk3288/Kconfig"
board/amarula/vyasa-rk3288/Kconfig new file +12 -0
new file mode 100644
index 0000000..8b8c308
@@ -0,0 +1,12 @@
+if TARGET_VYASA_RK3288
+
+config SYS_BOARD
+	default "vyasa-rk3288"
+
+config SYS_VENDOR
+	default "amarula"
+
+config SYS_CONFIG_NAME
+	default "vyasa-rk3288"
+
+endif
board/amarula/vyasa-rk3288/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000..10397fc
@@ -0,0 +1,6 @@
+VYASA RK3288
+M:	Jagan Teki <[email protected]>
+S:	Maintained
+F:	board/amarula/vyasa-rk3288
+F:	include/configs/vyasa-rk3288.h
+F:	configs/vyasa-rk3288_defconfig
board/amarula/vyasa-rk3288/Makefile new file +7 -0
new file mode 100644
index 0000000..7c0d5c0
@@ -0,0 +1,7 @@
+#
+# Copyright (C) 2017 Amarula Solutions
+#
+# SPDX-License-Identifier:     GPL-2.0+
+#
+
+obj-y	+= vyasa-rk3288.o
board/amarula/vyasa-rk3288/vyasa-rk3288.c new file +7 -0
new file mode 100644
index 0000000..ceee42c
@@ -0,0 +1,7 @@
+/*
+ * Copyright (C) 2017 Amarula Solutions
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#include <common.h>
configs/vyasa-rk3288_defconfig new file +63 -0

63 lines not on this page · raw message

include/configs/vyasa-rk3288.h new file +22 -0
new file mode 100644
index 0000000..40e9486
@@ -0,0 +1,22 @@
+/*
+ * Copyright (C) 2017 Amarula Solutions
+ *
+ * Configuration settings for Amarula Vyasa RK3288.
+ *
+ * SPDX-License-Identifier:     GPL-2.0+
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+#define ROCKCHIP_DEVICE_SETTINGS
+#include <configs/rk3288_common.h>
+
+#undef BOOT_TARGET_DEVICES
+
+#define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 1) \
+
+#define CONFIG_SYS_MMC_ENV_DEV 1
+
+#endif
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

Quoted 22 lines · Jagan Teki

From: Jagan Teki <[email protected]>

This patch adds support for Vyasa RK3288 initial board from Amarula Solutions.

Boot from SDMMC:
---------------
U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45) Trying to boot from MMC1

U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)

Model: Amarula Vyasa-RK3288
DRAM:  2 GiB
MMC:   dwmmc at ff0c0000: 1

*** Warning - bad CRC, using default environment

In:    serial at ff690000
Out:   serial at ff690000
Err:   serial at ff690000
Model: Amarula Vyasa-RK3288
Net:   Net Initialization Skipped
Quoted 6 lines

No ethernet found.
Hit any key to stop autoboot: 0
=>

Reviewed-by Simon Glass <[email protected]>
Signed-off-by Jagan Teki <[email protected]>

fyi: DTS was recently applied in linux tree [1]

[1] https://kernel.googlesource.com/pub/scm/linux/kernel/git/mmind/linux-rockchip/+/113a15652348161e8a7071bfba4946ce4a59e990%5E%21/

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#2 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

In reply to Jagan Teki
Quoted 46 lines

From: Jagan Teki <[email protected]>

This patch adds support for Vyasa RK3288 initial board from Amarula Solutions.

Boot from SDMMC:
---------------
U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45) Trying to boot from MMC1

U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)

Model: Amarula Vyasa-RK3288
DRAM:  2 GiB
MMC:   dwmmc at ff0c0000: 1

*** Warning - bad CRC, using default environment

In:    serial at ff690000
Out:   serial at ff690000
Err:   serial at ff690000
Model: Amarula Vyasa-RK3288
Net:   Net Initialization Skipped

No ethernet found.
Hit any key to stop autoboot: 0
=>

Reviewed-by Simon Glass <[email protected]>
Signed-off-by Jagan Teki <[email protected]>

---
Changes for v3:
- Remove CONFIG_ENV_IS_IN_MMC from include file
- Update commit message with company name
- Fix proper board name on MAINTAINERS file
Changes for v2:
- Fix commit message
- Move CONFIG_ENV_IS_IN_MMC to configs

 arch/arm/dts/Makefile                     |   1 +
 arch/arm/dts/rk3288-vyasa.dts             | 327 ++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/rk3288/Kconfig     |  11 +
 board/amarula/vyasa-rk3288/Kconfig        |  12 ++
 board/amarula/vyasa-rk3288/MAINTAINERS    |   6 +
 board/amarula/vyasa-rk3288/Makefile       |   7 +
 board/amarula/vyasa-rk3288/vyasa-rk3288.c |   7 +
 configs/vyasa-rk3288_defconfig            |  63 ++++++
 include/configs/vyasa-rk3288.h            |  22 ++
Quoted 9 lines
 9 files changed, 456 insertions(+)
 create mode 100644 arch/arm/dts/rk3288-vyasa.dts
 create mode 100644 board/amarula/vyasa-rk3288/Kconfig
 create mode 100644 board/amarula/vyasa-rk3288/MAINTAINERS
 create mode 100644 board/amarula/vyasa-rk3288/Makefile
 create mode 100644 board/amarula/vyasa-rk3288/vyasa-rk3288.c
 create mode 100644 configs/vyasa-rk3288_defconfig
 create mode 100644 include/configs/vyasa-rk3288.h
Reviewed-by Philipp Tomsich <[email protected]>
#3 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

In reply to Jagan Teki
Quoted 47 lines

From: Jagan Teki <[email protected]>

This patch adds support for Vyasa RK3288 initial board from Amarula Solutions.

Boot from SDMMC:
---------------
U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45) Trying to boot from MMC1

U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)

Model: Amarula Vyasa-RK3288
DRAM:  2 GiB
MMC:   dwmmc at ff0c0000: 1

*** Warning - bad CRC, using default environment

In:    serial at ff690000
Out:   serial at ff690000
Err:   serial at ff690000
Model: Amarula Vyasa-RK3288
Net:   Net Initialization Skipped

No ethernet found.
Hit any key to stop autoboot: 0
=>

Reviewed-by Simon Glass <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>

---
Changes for v3:
- Remove CONFIG_ENV_IS_IN_MMC from include file
- Update commit message with company name
- Fix proper board name on MAINTAINERS file
Changes for v2:
- Fix commit message
- Move CONFIG_ENV_IS_IN_MMC to configs

 arch/arm/dts/Makefile                     |   1 +
 arch/arm/dts/rk3288-vyasa.dts             | 327 ++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/rk3288/Kconfig     |  11 +
 board/amarula/vyasa-rk3288/Kconfig        |  12 ++
 board/amarula/vyasa-rk3288/MAINTAINERS    |   6 +
 board/amarula/vyasa-rk3288/Makefile       |   7 +
 board/amarula/vyasa-rk3288/vyasa-rk3288.c |   7 +
 configs/vyasa-rk3288_defconfig            |  63 ++++++
 include/configs/vyasa-rk3288.h            |  22 ++
Quoted 9 lines
 9 files changed, 456 insertions(+)
 create mode 100644 arch/arm/dts/rk3288-vyasa.dts
 create mode 100644 board/amarula/vyasa-rk3288/Kconfig
 create mode 100644 board/amarula/vyasa-rk3288/MAINTAINERS
 create mode 100644 board/amarula/vyasa-rk3288/Makefile
 create mode 100644 board/amarula/vyasa-rk3288/vyasa-rk3288.c
 create mode 100644 configs/vyasa-rk3288_defconfig
 create mode 100644 include/configs/vyasa-rk3288.h
Acked-by Philipp Tomsich <[email protected]>
#4 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

In reply to Jagan Teki
Quoted 47 lines

From: Jagan Teki <[email protected]>

This patch adds support for Vyasa RK3288 initial board from Amarula Solutions.

Boot from SDMMC:
---------------
U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45) Trying to boot from MMC1

U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)

Model: Amarula Vyasa-RK3288
DRAM:  2 GiB
MMC:   dwmmc at ff0c0000: 1

*** Warning - bad CRC, using default environment

In:    serial at ff690000
Out:   serial at ff690000
Err:   serial at ff690000
Model: Amarula Vyasa-RK3288
Net:   Net Initialization Skipped

No ethernet found.
Hit any key to stop autoboot: 0
=>

Reviewed-by Simon Glass <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
Reviewed-by Philipp Tomsich <[email protected]>

---
Changes for v3:
- Remove CONFIG_ENV_IS_IN_MMC from include file
- Update commit message with company name
- Fix proper board name on MAINTAINERS file
Changes for v2:
- Fix commit message
- Move CONFIG_ENV_IS_IN_MMC to configs

 arch/arm/dts/Makefile                     |   1 +
 arch/arm/dts/rk3288-vyasa.dts             | 327 ++++++++++++++++++++++++++++++
 arch/arm/mach-rockchip/rk3288/Kconfig     |  11 +
 board/amarula/vyasa-rk3288/Kconfig        |  12 ++
 board/amarula/vyasa-rk3288/MAINTAINERS    |   6 +
 board/amarula/vyasa-rk3288/Makefile       |   7 +
 board/amarula/vyasa-rk3288/vyasa-rk3288.c |   7 +
 configs/vyasa-rk3288_defconfig            |  63 ++++++
 include/configs/vyasa-rk3288.h            |  22 ++
Quoted 9 lines
 9 files changed, 456 insertions(+)
 create mode 100644 arch/arm/dts/rk3288-vyasa.dts
 create mode 100644 board/amarula/vyasa-rk3288/Kconfig
 create mode 100644 board/amarula/vyasa-rk3288/MAINTAINERS
 create mode 100644 board/amarula/vyasa-rk3288/Makefile
 create mode 100644 board/amarula/vyasa-rk3288/vyasa-rk3288.c
 create mode 100644 configs/vyasa-rk3288_defconfig
 create mode 100644 include/configs/vyasa-rk3288.h
Acked-by Philipp Tomsich <[email protected]>
#5 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

Jagan,

please revise — after applying this patch, the build fails with:

Quoted 6 lines
       arm:  +   vyasa-rk3288
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_usb_mass_storage':
+cmd/usb_mass_storage.c:164: undefined reference to `board_usb_init'
+cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
+cmd/usb_mass_storage.c:177: undefined reference to `g_dnl_register'
+cmd/usb_mass_storage.c:187: undefined reference to `g_dnl_board_usb_cable_connected'

Review

Quoted 10 lines
(quoted diff) +10 -0
+cmd/usb_mass_storage.c:194: undefined reference to `g_dnl_board_usb_cable_connected'
+cmd/usb_mass_storage.c:215: undefined reference to `usb_gadget_handle_interrupts'
+cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
+cmd/usb_mass_storage.c:233: undefined reference to `g_dnl_unregister'
+cmd/usb_mass_storage.c:235: undefined reference to `board_usb_cleanup'
+arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion fail /home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696
+arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' not found in the linker script
+arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation
+make[1]: *** [u-boot] Error 1
+make: *** [sub-make] Error 2

Thanks,
Philipp.

Quoted 64 lines · Philipp Tomsich
Quoted 49 lines

From: Jagan Teki <[email protected]>

This patch adds support for Vyasa RK3288 initial board from Amarula Solutions.

Boot from SDMMC:
---------------
U-Boot SPL 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45) Trying to boot from MMC1

U-Boot 2017.09-rc1-00111-g3656991-dirty (Aug 10 2017 - 11:40:45 +0530)

Model: Amarula Vyasa-RK3288
DRAM:  2 GiB
MMC:   dwmmc at ff0c0000: 1

*** Warning - bad CRC, using default environment

In:    serial at ff690000
Out:   serial at ff690000
Err:   serial at ff690000
Model: Amarula Vyasa-RK3288
Net:   Net Initialization Skipped

No ethernet found.
Hit any key to stop autoboot: 0
=>

Reviewed-by Simon Glass <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
Reviewed-by Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:[email protected]>>

---
Changes for v3:
- Remove CONFIG_ENV_IS_IN_MMC from include file
- Update commit message with company name
- Fix proper board name on MAINTAINERS file
Changes for v2:
- Fix commit message
- Move CONFIG_ENV_IS_IN_MMC to configs

arch/arm/dts/Makefile                     |   1 +
arch/arm/dts/rk3288-vyasa.dts             | 327 ++++++++++++++++++++++++++++++
arch/arm/mach-rockchip/rk3288/Kconfig     |  11 +
board/amarula/vyasa-rk3288/Kconfig        |  12 ++
board/amarula/vyasa-rk3288/MAINTAINERS    |   6 +
board/amarula/vyasa-rk3288/Makefile       |   7 +
board/amarula/vyasa-rk3288/vyasa-rk3288.c |   7 +
configs/vyasa-rk3288_defconfig            |  63 ++++++
include/configs/vyasa-rk3288.h            |  22 ++
9 files changed, 456 insertions(+)
Quoted 8 lines

create mode 100644 arch/arm/dts/rk3288-vyasa.dts create mode 100644 board/amarula/vyasa-rk3288/Kconfig create mode 100644 board/amarula/vyasa-rk3288/MAINTAINERS create mode 100644 board/amarula/vyasa-rk3288/Makefile create mode 100644 board/amarula/vyasa-rk3288/vyasa-rk3288.c create mode 100644 configs/vyasa-rk3288_defconfig create mode 100644 include/configs/vyasa-rk3288.h

Acked-by Philipp Tomsich <philipp.tomsich at theobroma-systems.com <mailto:[email protected]>>

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de <mailto:[email protected]>
https://lists.denx.de/listinfo/u-boot <https://lists.denx.de/listinfo/u-boot>

author
#6 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

Quoted 22 lines · Dr. Philipp Tomsich

Jagan,

please revise — after applying this patch, the build fails with:

       arm:  +   vyasa-rk3288
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_usb_mass_storage':
+cmd/usb_mass_storage.c:164: undefined reference to `board_usb_init'
+cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
+cmd/usb_mass_storage.c:177: undefined reference to `g_dnl_register'
+cmd/usb_mass_storage.c:187: undefined reference to

g_dnl_board_usb_cable_connected' +cmd/usb_mass_storage.c:194: undefined reference to g_dnl_board_usb_cable_connected' +cmd/usb_mass_storage.c:215: undefined reference to `usb_gadget_handle_interrupts'

(quoted diff) +4 -0
+cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
+cmd/usb_mass_storage.c:233: undefined reference to `g_dnl_unregister'
+cmd/usb_mass_storage.c:235: undefined reference to `board_usb_cleanup'
+arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion fail

/home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696 +arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' not found in the linker script

Review

Quoted 3 lines
(quoted diff) +3 -0
+arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation
+make[1]: *** [u-boot] Error 1
+make: *** [sub-make] Error 2

commit[1] from Tom, as moved USB configs to defconfig, this patch missed that since Tom pushed after this patch.
will send v4 by including updated changes.

[1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=ecad7051b07b11fb17196ce45ed0cbe2f1c3234e

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.
#7 lore raw

PATCH v3 1/1 rk3288: Add Vyasa initial board support

Quoted 26 lines · Jagan Teki
Quoted 21 lines · On Tue, Sep 12, 2017 at 2:23 PM, Dr. Philipp Tomsich <philipp.tomsich at…

Jagan,

please revise — after applying this patch, the build fails with:

      arm:  +   vyasa-rk3288
(quoted diff) +5 -0
+cmd/built-in.o: In function `do_usb_mass_storage':
+cmd/usb_mass_storage.c:164: undefined reference to `board_usb_init'
+cmd/usb_mass_storage.c:170: undefined reference to `fsg_init'
+cmd/usb_mass_storage.c:177: undefined reference to `g_dnl_register'
+cmd/usb_mass_storage.c:187: undefined reference to

g_dnl_board_usb_cable_connected' +cmd/usb_mass_storage.c:194: undefined reference to g_dnl_board_usb_cable_connected' +cmd/usb_mass_storage.c:215: undefined reference to `usb_gadget_handle_interrupts'

(quoted diff) +4 -0
+cmd/usb_mass_storage.c:217: undefined reference to `fsg_main_thread'
+cmd/usb_mass_storage.c:233: undefined reference to `g_dnl_unregister'
+cmd/usb_mass_storage.c:235: undefined reference to `board_usb_cleanup'
+arm-unknown-linux-gnueabi-ld.bfd: BFD (GNU Binutils) 2.24 assertion fail

/home/tony/buildall/src/binutils/bfd/elf32-arm.c:7696 +arm-unknown-linux-gnueabi-ld.bfd: error: required section '.rel.plt' not

Quoted 8 lines

Review

Quoted 4 lines

found in the linker script

(quoted diff) +3 -0
+arm-unknown-linux-gnueabi-ld.bfd: final link failed: Invalid operation
+make[1]: *** [u-boot] Error 1
+make: *** [sub-make] Error 2

commit[1] from Tom, as moved USB configs to defconfig, this patch missed that since Tom pushed after this patch.
will send v4 by including updated changes.

Thanks for revising/rebasing. I am trying to get as much of my backlog into an early PR and this is among those patches.

Quoted 9 lines

[1] http://git.denx.de/?p=u-boot.git;a=commitdiff;h=ecad7051b07b11fb17196ce45ed0cbe2f1c3234e <http://git.denx.de/?p=u-boot.git;a=commitdiff;h=ecad7051b07b11fb17196ce45ed0cbe2f1c3234e>

thanks!

Signature · 4 lines
Jagan Teki
Free Software Engineer | www.openedev.com <http://www.openedev.com/>
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.