Skip to contentSkip to conversation

imx: mx7: Add support for USB and normal boot modes

PATCH Superseded Eric Nelson 4 participants 16 messages Aug 30, 2017 – Oct 2, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

---
V2 adds "normal" mode as suggested by Troy Kisky

 arch/arm/mach-imx/mx7/soc.c | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/mx7/soc.c +3 -0
index 87bf105..15be42a 100644
@@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
  * to SBMR1, which will determine the boot device.
  */
 const struct boot_mode soc_boot_modes[] = {
+	{"normal",	MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
+	{"usb",		MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
+
 	{"ecspi1:0",	MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)},
 	{"ecspi1:1",	MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)},
 	{"ecspi1:2",	MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Sorry for the spam.

I resent this by mistake.

Quoted 28 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

---
V2 adds "normal" mode as suggested by Troy Kisky

  arch/arm/mach-imx/mx7/soc.c | 3 +++
  1 file changed, 3 insertions(+)
arch/arm/mach-imx/mx7/soc.c +3 -0
index 87bf105..15be42a 100644
@@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
   * to SBMR1, which will determine the boot device.
   */
  const struct boot_mode soc_boot_modes[] = {
+	{"normal",	MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
+	{"usb",		MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
+
  	{"ecspi1:0",	MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)},
  	{"ecspi1:1",	MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)},
  	{"ecspi1:2",	MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},
reviewer
#2 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

In reply to Eric Nelson

Hi Eric,

Quoted 8 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.

I also did:

configs/mx7dsabresd_defconfig +0 -1
index 8f2e33a..c70fde8 100644
@@ -5,7 +5,6 @@ CONFIG_VIDEO=y
 # CONFIG_ARMV7_VIRT is not set
 CONFIG_IMX_RDC=y
 CONFIG_IMX_BOOTAUX=y
-# CONFIG_CMD_BMODE is not set
 CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb"
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg"
 CONFIG_BOOTDELAY=3

so that bmode command can be added.

However I am getting:

=> bmode usb
bmode - <NULL>

Usage:
bmode
=> bmode normal
bmode - <NULL>

Usage:
bmode
=>

Any ideas?

Thanks

reviewer
#3 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 30 lines · Fabio Estevam

Hi Eric,

Quoted 8 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.

I also did:

configs/mx7dsabresd_defconfig +0 -1
index 8f2e33a..c70fde8 100644
@@ -5,7 +5,6 @@ CONFIG_VIDEO=y
 # CONFIG_ARMV7_VIRT is not set
 CONFIG_IMX_RDC=y
 CONFIG_IMX_BOOTAUX=y
-# CONFIG_CMD_BMODE is not set
 CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb"
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg"
 CONFIG_BOOTDELAY=3
Quoted 6 lines

so that bmode command can be added.

However I am getting:

=> bmode usb
bmode - <NULL>

I missed to add 'add_board_boot_modes(board_boot_modes);'

Now I get:

=> bmode usb
resetting ...

U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 41C
Reset cause: POR
Model: Freescale i.MX7 SabreSD Board
Board: i.MX7D SABRESD in non-secure mode
DRAM:  1 GiB
PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11

MMC:
MMC Device 0 not found
*** Warning - No MMC card found, using default environment

Video: 480x272x24
In:    serial
Out:   serial
Err:   serial
Net:   FEC0
Hit any key to stop autoboot:  0

=>

So the board is resetting instead of going into serial download mode.

Any ideas?

Thanks

#4 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Hi Fabio,

Quoted 65 lines · Fabio Estevam
Quoted 30 lines · Fabio Estevam

Hi Eric,

Quoted 8 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.

I also did:

configs/mx7dsabresd_defconfig +0 -1
index 8f2e33a..c70fde8 100644
@@ -5,7 +5,6 @@ CONFIG_VIDEO=y
  # CONFIG_ARMV7_VIRT is not set
  CONFIG_IMX_RDC=y
  CONFIG_IMX_BOOTAUX=y
-# CONFIG_CMD_BMODE is not set
  CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb"
  CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg"
  CONFIG_BOOTDELAY=3
Quoted 6 lines

so that bmode command can be added.

However I am getting:

=> bmode usb
bmode - <NULL>

I missed to add 'add_board_boot_modes(board_boot_modes);'

Now I get:

=> bmode usb
resetting ...

U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 41C
Reset cause: POR
Model: Freescale i.MX7 SabreSD Board
Board: i.MX7D SABRESD in non-secure mode
DRAM:  1 GiB
PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11

MMC:
MMC Device 0 not found
*** Warning - No MMC card found, using default environment

Video: 480x272x24
In:    serial
Out:   serial
Err:   serial
Net:   FEC0
Hit any key to stop autoboot:  0
Quoted 6 lines

=>

So the board is resetting instead of going into serial download mode.

Any ideas?

I'm not sure. Since I'm currently working with a board with no fuses blown, I'm getting USB mode either way ;)...

I have an MX7 SABRE SD and I'll try it out there.

Regards,

Eric

#5 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

In reply to Fabio Estevam
Quoted 65 lines · Fabio Estevam
Quoted 30 lines · Fabio Estevam

Hi Eric,

Quoted 8 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.

I also did:

configs/mx7dsabresd_defconfig +0 -1
index 8f2e33a..c70fde8 100644
@@ -5,7 +5,6 @@ CONFIG_VIDEO=y
 # CONFIG_ARMV7_VIRT is not set
 CONFIG_IMX_RDC=y
 CONFIG_IMX_BOOTAUX=y
-# CONFIG_CMD_BMODE is not set
 CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb"
 CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg"
 CONFIG_BOOTDELAY=3
Quoted 6 lines

so that bmode command can be added.

However I am getting:

=> bmode usb
bmode - <NULL>

I missed to add 'add_board_boot_modes(board_boot_modes);'

Now I get:

=> bmode usb
resetting ...

U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 41C
Reset cause: POR
Model: Freescale i.MX7 SabreSD Board
Board: i.MX7D SABRESD in non-secure mode
DRAM:  1 GiB
PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x11

MMC:
MMC Device 0 not found
*** Warning - No MMC card found, using default environment

Video: 480x272x24
In:    serial
Out:   serial
Err:   serial
Net:   FEC0
Hit any key to stop autoboot:  0
Quoted 7 lines

=>

So the board is resetting instead of going into serial download mode.

Any ideas?

I got this response from Peng when I asked him back in March of last year.

Quoted 4 lines

For now, bmode does not work. Since bmode use warm reset, but we now use wdog to directly reset pmic. So bmode will not work.

Please check your code to see whether your board connect WDOG_B to pmic reset pin and have wdog

pinmux settings.

Quoted 3 lines

Thanks,
Peng.

Maybe if you change the WDOG pinmux it might work ?

Troy

#6 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 4 lines · Troy Kisky

Maybe if you change the WDOG pinmux it might work ?

Worked for me

=> mm.l 302c0000
302c0000: 00000003 ? 0
302c0004: 00000001 ? q
=> bmod usb
resetting ...

#7 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 7 lines · Troy Kisky
Quoted 4 lines · Troy Kisky

Maybe if you change the WDOG pinmux it might work ?

Quoted 8 lines

Worked for me

=> mm.l 302c0000
302c0000: 00000003 ? 0
302c0004: 00000001 ? q
=> bmod usb
resetting ...

Hmm...

On SABRE-SD or Nitrogen7?

#8 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 17 lines · Eric Nelson
Quoted 7 lines · Troy Kisky
Quoted 4 lines · Troy Kisky

Maybe if you change the WDOG pinmux it might work ?

Quoted 8 lines

Worked for me

=> mm.l 302c0000
302c0000: 00000003 ? 0
302c0004: 00000001 ? q
=> bmod usb
resetting ...

Quoted 4 lines

Hmm...

On SABRE-SD or Nitrogen7?

Nitrogen7,

It does show up in lsusb afterwards
Bus 003 Device 100: ID 15a2:0076 Freescale Semiconductor, Inc.

But imx_usb gets errors afterwards

== work item
filename /tftpboot/u-boot.nitrogen7
load_size 0 bytes
load_addr 0x00000000
dcd 1
clear_dcd 0
plug 1
jump_mode 2
jump_addr 0x00000000
== end work item
loading DCD table @0x910000

<<<-564, 1024 bytes>>>
report 3 in err=-7, last_trans=0 c4 34 03 32
report 4 in err=-7, last_trans=0 c4 34 03 32
failed (status 0x320334c4)
________________

So, close but no cigar.

#9 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 42 lines · Troy Kisky
Quoted 17 lines · Eric Nelson
Quoted 7 lines · Troy Kisky
Quoted 4 lines · Troy Kisky

Maybe if you change the WDOG pinmux it might work ?

Quoted 8 lines

Worked for me

=> mm.l 302c0000
302c0000: 00000003 ? 0
302c0004: 00000001 ? q
=> bmod usb
resetting ...

Quoted 4 lines

Hmm...

On SABRE-SD or Nitrogen7?

Nitrogen7,

It does show up in lsusb afterwards
Bus 003 Device 100: ID 15a2:0076 Freescale Semiconductor, Inc.

But imx_usb gets errors afterwards

== work item
filename /tftpboot/u-boot.nitrogen7
load_size 0 bytes
load_addr 0x00000000
dcd 1
clear_dcd 0
plug 1
jump_mode 2
jump_addr 0x00000000
== end work item
loading DCD table @0x910000

Quoted 9 lines

<<<-564, 1024 bytes>>>
report 3 in err=-7, last_trans=0 c4 34 03 32
report 4 in err=-7, last_trans=0 c4 34 03 32
failed (status 0x320334c4)
________________

So, close but no cigar.

FYI

=> mw.l 302c0000 0
=> reset
resetting ...
___________________

Also just hangs. So, it is not "bmode" specify.

reviewer
#10 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

In reply to Troy Kisky

Troy,

Quoted 7 lines · Troy Kisky
Quoted 4 lines · Troy Kisky

Maybe if you change the WDOG pinmux it might work ?

Quoted 8 lines

Worked for me

=> mm.l 302c0000
302c0000: 00000003 ? 0
302c0004: 00000001 ? q
=> bmod usb
resetting ...

Ok, but did you manage to successfully transfer u-boot via imx_usb_loader?

It did not work for me.

Thanks

#11 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 20 lines · Fabio Estevam

Troy,

Quoted 7 lines · Troy Kisky
Quoted 4 lines · Troy Kisky

Maybe if you change the WDOG pinmux it might work ?

Quoted 8 lines

Worked for me

=> mm.l 302c0000
302c0000: 00000003 ? 0
302c0004: 00000001 ? q
=> bmod usb
resetting ...

Quoted 4 lines

Ok, but did you manage to successfully transfer u-boot via imx_usb_loader?

It did not work for me.

Ditto here. The OTG port didn't re-enumerate.

#12 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

In reply to Troy Kisky

Thanks Troy (and Peng),

Quoted 41 lines · Troy Kisky
Quoted 40 lines · Fabio Estevam
Quoted 28 lines · Fabio Estevam
Quoted 8 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

I tried testing your patch on a imx7d sabresd, but it seems there is an issue with bmode that is unrelated to your patch.

I also did:

configs/mx7dsabresd_defconfig +0 -1
index 8f2e33a..c70fde8 100644
@@ -5,7 +5,6 @@ CONFIG_VIDEO=y
  # CONFIG_ARMV7_VIRT is not set
  CONFIG_IMX_RDC=y
  CONFIG_IMX_BOOTAUX=y
-# CONFIG_CMD_BMODE is not set
  CONFIG_DEFAULT_DEVICE_TREE="imx7d-sdb"
  CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/freescale/mx7dsabresd/imximage.cfg"
  CONFIG_BOOTDELAY=3
Quoted 6 lines

so that bmode command can be added.

However I am getting:

=> bmode usb
bmode - <NULL>

I missed to add 'add_board_boot_modes(board_boot_modes);'

Now I get:

Quoted 8 lines
Quoted 8 lines

=> bmode usb
resetting ...

U-Boot 2017.09-rc2-36996-g63af4b0-dirty (Aug 31 2017 - 10:53:12 -0300)

CPU:   Freescale i.MX7D rev1.2 1000 MHz (running at 792 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 41C

Note the POR here (I would expect it to be WDOG).

Quoted 4 lines
Quoted 4 lines

Reset cause: POR
Model: Freescale i.MX7 SabreSD Board
Board: i.MX7D SABRESD in non-secure mode
DRAM: 1 GiB

<snip>

Quoted 6 lines

I got this response from Peng when I asked him back in March of last year.

Quoted 3 lines

For now, bmode does not work. Since bmode use warm reset, but we now use wdog to directly reset pmic. So bmode will not work.

Quoted 8 lines
Quoted 1 line

Please check your code to see whether your board connect WDOG_B to pmic reset pin and have wdog

pinmux settings.

Quoted 3 lines

Thanks,
Peng.

Maybe if you change the WDOG pinmux it might work ?

The mx7dsabresd has GPIO1_IO00 configured for WDOG, and overriding it does get rid of the POR.

Unfortunately, it also doesn't allow "bmode usb" to function.

=> mm 302c0000
302c0000: 00000003 ? 0
302c0004: 00000000 ? x
=> bmode usb
resetting ...

(crickets here)

Based on this:

#13 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

In reply to Eric Nelson
Quoted 19 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

---
V2 adds "normal" mode as suggested by Troy Kisky

 arch/arm/mach-imx/mx7/soc.c | 3 +++
 1 file changed, 3 insertions(+)
arch/arm/mach-imx/mx7/soc.c +0 -0
index 87bf105..15be42a 100644

arch/arm/mach-imx/mx7/soc.c void set_wdog_reset(struct wdog_regs *wdog) · line 380

Quoted 9 lines
arch/arm/mach-imx/mx7/soc.c +3 -0
@@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
  * to SBMR1, which will determine the boot device.
  */
 const struct boot_mode soc_boot_modes[] = {
+	{"normal",	MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
+	{"usb",		MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
+
 	{"ecspi1:0",	MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)},
 	{"ecspi1:1",	MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)},
 	{"ecspi1:2",	MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},

Sorry, it was for a long time in the queue - discussion in thread is spreading away from the original review (I had errouneosly set it to Changes requested).

Applied to u-boot-imx, -master, thanks !

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#14 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Hi Stefano,

Quoted 34 lines · Stefano Babic
Quoted 19 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

---
V2 adds "normal" mode as suggested by Troy Kisky

  arch/arm/mach-imx/mx7/soc.c | 3 +++
  1 file changed, 3 insertions(+)
arch/arm/mach-imx/mx7/soc.c +0 -0
index 87bf105..15be42a 100644

arch/arm/mach-imx/mx7/soc.c void set_wdog_reset(struct wdog_regs *wdog) · line 380

Quoted 9 lines
arch/arm/mach-imx/mx7/soc.c +3 -0
@@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
   * to SBMR1, which will determine the boot device.
   */
  const struct boot_mode soc_boot_modes[] = {
+	{"normal",	MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
+	{"usb",		MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
+
  	{"ecspi1:0",	MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)},
  	{"ecspi1:1",	MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)},
  	{"ecspi1:2",	MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},

Sorry, it was for a long time in the queue - discussion in thread is spreading away from the original review (I had errouneosly set it to Changes requested).

Quoted 2 lines

Applied to u-boot-imx, -master, thanks !

Sorry, but we rejected this patch (because it doesn't work).

https://patchwork.ozlabs.org/patch/807934/

Regards,

Eric

#15 lore raw

PATCH v2 1/1 imx: mx7: Add support for USB and normal boot modes

Quoted 37 lines · Eric Nelson

Hi Stefano,

Quoted 34 lines · Stefano Babic
Quoted 19 lines · Eric Nelson

This adds support for two additional boot modes on the i.MX7D SoC, which is most useful when doing U-Boot development on this chip.

1. "bmode usb" can be used to force the ROM boot loader's serial
2. "bmode normal" can be used to revert to the normal boot mode as specified by fuses and BOOT_MODE pins

---
V2 adds "normal" mode as suggested by Troy Kisky
  arch/arm/mach-imx/mx7/soc.c | 3 +++

  1 file changed, 3 insertions(+)
arch/arm/mach-imx/mx7/soc.c +0 -0
index 87bf105..15be42a 100644

arch/arm/mach-imx/mx7/soc.c void set_wdog_reset(struct wdog_regs *wdog) · line 380

Quoted 9 lines
arch/arm/mach-imx/mx7/soc.c +3 -0
@@ -372,6 +372,9 @@ void set_wdog_reset(struct wdog_regs *wdog)
    * to SBMR1, which will determine the boot device.
    */
   const struct boot_mode soc_boot_modes[] = {
+    {"normal",    MAKE_CFGVAL(0x00, 0x00, 0x00, 0x00)},
+    {"usb",        MAKE_CFGVAL(0x01, 0x00, 0x00, 0x00)},
+
       {"ecspi1:0",    MAKE_CFGVAL(0x00, 0x60, 0x00, 0x00)},
       {"ecspi1:1",    MAKE_CFGVAL(0x40, 0x62, 0x00, 0x00)},
       {"ecspi1:2",    MAKE_CFGVAL(0x80, 0x64, 0x00, 0x00)},

Sorry, it was for a long time in the queue - discussion in thread is spreading away from the original review (I had errouneosly set it to Changes requested).

Quoted 6 lines
Quoted 2 lines

Applied to u-boot-imx, -master, thanks !

Sorry, but we rejected this patch (because it doesn't work).

https://patchwork.ozlabs.org/patch/807934/

Thanks, I have not seen it - I drop it.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================