Skip to contentSkip to conversation

staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

PATCH In review Janani Sankara Babu 3 participants 3 messages Sep 5, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

This patch solves the following warning shown by checkpatch script
Warning: msleep < 20ms can sleep for up to 20ms

---
 drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +1 -1
index f86c9ce..78edc15 100644
@@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
 			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
 			break;
 		}
-		msleep(1);
+		usleep_range(0, 1000);
 	}
 
 	return err;
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 13 lines · Janani Sankara Babu

This patch solves the following warning shown by checkpatch script
Warning: msleep < 20ms can sleep for up to 20ms

---
 drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +0 -0
index f86c9ce..78edc15 100644

drivers/staging/rtl8188eu/core/rtw_pwrctrl.c s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) · line 439

Quoted 5 lines
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +1 -1
@@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
 			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
 			break;
 		}
-		msleep(1);
+		usleep_range(0, 1000);

How do you know this is a valid range to sleep for?

#2 lore raw
In reply to Janani Sankara Babu
Quoted 2 lines · Janani Sankara Babu

This patch solves the following warning shown by checkpatch script
Warning: msleep < 20ms can sleep for up to 20ms

[]

drivers/staging/rtl8188eu/core/rtw_pwrctrl.c

Quoted 1 line
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +0 -0

[]

drivers/staging/rtl8188eu/core/rtw_pwrctrl.c s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) · line 439

Quoted 6 lines
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c +1 -1
@@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
 			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
 			break;
 		}
-		msleep(1);
+		usleep_range(0, 1000);

No, that would sleep a random time up to 1 ms.

usleep_range(1000, 2000) might be OK but please
check the value passed as delay_ms.

It's only used as LPS_LEAVE_TIMEOUT_MS (100 here)
so it seems just fine to keep using msleep.