Skip to contentSkip to conversation

drm/amdgpu: add new asic callbacks for HDP flush/invalidation

PATCH In review Samuel Li 2 participants 2 messages Sep 6, 2017 – Sep 7, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Samuel Li

author
#0 lore raw

PATCH 1/6 drm/amdgpu: add new asic callbacks for HDP flush/invalidation

From: Alex Deucher <[email protected]>

Needed to properly flush the HDP cache with the CPU from rather than the GPU.

---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +6 -0
index d2aaad7..6f262ce 100644
@@ -1279,6 +1279,10 @@ struct amdgpu_asic_funcs {
 	void (*set_pcie_lanes)(struct amdgpu_device *adev, int lanes);
 	/* get config memsize register */
 	u32 (*get_config_memsize)(struct amdgpu_device *adev);
+	/* flush hdp write queue */
+	void (*flush_hdp)(struct amdgpu_device *adev);
+	/* invalidate hdp read cache */
+	void (*invalidate_hdp)(struct amdgpu_device *adev);
 };
 
 /*
@@ -1737,6 +1741,8 @@ amdgpu_get_sdma_instance(struct amdgpu_ring *ring)
 #define amdgpu_asic_read_bios_from_rom(adev, b, l) (adev)->asic_funcs->read_bios_from_rom((adev), (b), (l))
 #define amdgpu_asic_read_register(adev, se, sh, offset, v)((adev)->asic_funcs->read_register((adev), (se), (sh), (offset), (v)))
 #define amdgpu_asic_get_config_memsize(adev) (adev)->asic_funcs->get_config_memsize((adev))
+#define amdgpu_asic_flush_hdp(adev) (adev)->asic_funcs->flush_hdp((adev))
+#define amdgpu_asic_invalidate_hdp(adev) (adev)->asic_funcs->invalidate_hdp((adev))
 #define amdgpu_gart_flush_gpu_tlb(adev, vmid) (adev)->gart.gart_funcs->flush_gpu_tlb((adev), (vmid))
 #define amdgpu_gart_set_pte_pde(adev, pt, idx, addr, flags) (adev)->gart.gart_funcs->set_pte_pde((adev), (pt), (idx), (addr), (flags))
 #define amdgpu_gart_get_vm_pde(adev, addr) (adev)->gart.gart_funcs->get_vm_pde((adev), (addr))
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1504735491-30920-1-git-send-email-Samuel.Li-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 07.09.2017 um 00:04 schrieb Samuel Li:

Quoted 7 lines

From: Alex Deucher <[email protected]>

Needed to properly flush the HDP cache with the CPU from rather than the GPU.

Patches #1-#5 are unnecessary for gem_prime_mmap support() (but don't completely drop them, we could use them for CPU based VM page table updates).

Patch #6 looks pretty good to me, just a few notes about the HDP flush/invalidate.

Regards,
Christian.

Quoted 20 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 ++++++
  1 file changed, 6 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu.h +4 -0
index d2aaad7..6f262ce 100644
@@ -1279,6 +1279,10 @@ struct amdgpu_asic_funcs {
  	void (*set_pcie_lanes)(struct amdgpu_device *adev, int lanes);
  	/* get config memsize register */
  	u32 (*get_config_memsize)(struct amdgpu_device *adev);
+	/* flush hdp write queue */
+	void (*flush_hdp)(struct amdgpu_device *adev);
+	/* invalidate hdp read cache */
+	void (*invalidate_hdp)(struct amdgpu_device *adev);
  };
 
  /*

drivers/gpu/drm/amd/amdgpu/amdgpu.h amdgpu_get_sdma_instance(struct amdgpu_ring *ring) · line 1748

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu.h +2 -0
@@ -1737,6 +1741,8 @@ amdgpu_get_sdma_instance(struct amdgpu_ring *ring)
  #define amdgpu_asic_read_bios_from_rom(adev, b, l) (adev)->asic_funcs->read_bios_from_rom((adev), (b), (l))
  #define amdgpu_asic_read_register(adev, se, sh, offset, v)((adev)->asic_funcs->read_register((adev), (se), (sh), (offset), (v)))
  #define amdgpu_asic_get_config_memsize(adev) (adev)->asic_funcs->get_config_memsize((adev))
+#define amdgpu_asic_flush_hdp(adev) (adev)->asic_funcs->flush_hdp((adev))
+#define amdgpu_asic_invalidate_hdp(adev) (adev)->asic_funcs->invalidate_hdp((adev))
  #define amdgpu_gart_flush_gpu_tlb(adev, vmid) (adev)->gart.gart_funcs->flush_gpu_tlb((adev), (vmid))
  #define amdgpu_gart_set_pte_pde(adev, pt, idx, addr, flags) (adev)->gart.gart_funcs->set_pte_pde((adev), (pt), (idx), (addr), (flags))
  #define amdgpu_gart_get_vm_pde(adev, addr) (adev)->gart.gart_funcs->get_vm_pde((adev), (addr))

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx