Skip to contentSkip to conversation

drivers/staging/rtl8188eu: cleanup crc32_init logic

PATCH In review Pushkar Jambhlekar 2 participants 2 messages Sep 7, 2017 Staging

lore
Share & tools
lore

Pushkar Jambhlekar

author
#0 lore raw

PATCH 1/1 drivers/staging/rtl8188eu: cleanup crc32_init logic

crc32_init is using unnecessary else condition. Cleaningup this function

Signed-off-by Pushkar Jambhlekar <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++--------------
 1 file changed, 21 insertions(+), 21 deletions(-)
drivers/staging/rtl8188eu/core/rtw_security.c +21 -21
index b283a490..9d17204 100644
@@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data)
 
 static void crc32_init(void)
 {
-	if (bcrc32initialized == 1) {
+	if (bcrc32initialized == 1)
 		return;
-	} else {
-		int i, j;
-		u32 c;
-		u8 *p = (u8 *)&c, *p1;
-		u8 k;
-
-		c = 0x12340000;
-
-		for (i = 0; i < 256; ++i) {
-			k = crc32_reverseBit((u8)i);
-			for (c = ((u32)k) << 24, j = 8; j > 0; --j)
-				c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
-			p1 = (u8 *)&crc32_table[i];
-
-			p1[0] = crc32_reverseBit(p[3]);
-			p1[1] = crc32_reverseBit(p[2]);
-			p1[2] = crc32_reverseBit(p[1]);
-			p1[3] = crc32_reverseBit(p[0]);
-		}
-		bcrc32initialized = 1;
+
+	int i, j;
+	u32 c;
+	u8 *p = (u8 *)&c, *p1;
+	u8 k;
+
+	c = 0x12340000;
+
+	for (i = 0; i < 256; ++i) {
+		k = crc32_reverseBit((u8)i);
+		for (c = ((u32)k) << 24, j = 8; j > 0; --j)
+			c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
+		p1 = (u8 *)&crc32_table[i];
+
+		p1[0] = crc32_reverseBit(p[3]);
+		p1[1] = crc32_reverseBit(p[2]);
+		p1[2] = crc32_reverseBit(p[1]);
+		p1[3] = crc32_reverseBit(p[0]);
 	}
+
+	bcrc32initialized = 1;
 }
 
 static __le32 getcrc32(u8 *buf, int len)
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 52 lines · Pushkar Jambhlekar

crc32_init is using unnecessary else condition. Cleaningup this function

Signed-off-by Pushkar Jambhlekar <[email protected]>
---
 drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++--------------
 1 file changed, 21 insertions(+), 21 deletions(-)
drivers/staging/rtl8188eu/core/rtw_security.c +15 -21
index b283a490..9d17204 100644
@@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data)
 
 static void crc32_init(void)
 {
-	if (bcrc32initialized == 1) {
+	if (bcrc32initialized == 1)
 		return;
-	} else {
-		int i, j;
-		u32 c;
-		u8 *p = (u8 *)&c, *p1;
-		u8 k;
-
-		c = 0x12340000;
-
-		for (i = 0; i < 256; ++i) {
-			k = crc32_reverseBit((u8)i);
-			for (c = ((u32)k) << 24, j = 8; j > 0; --j)
-				c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
-			p1 = (u8 *)&crc32_table[i];
-
-			p1[0] = crc32_reverseBit(p[3]);
-			p1[1] = crc32_reverseBit(p[2]);
-			p1[2] = crc32_reverseBit(p[1]);
-			p1[3] = crc32_reverseBit(p[0]);
-		}
-		bcrc32initialized = 1;
+
+	int i, j;
+	u32 c;
+	u8 *p = (u8 *)&c, *p1;
+	u8 k;
+
+	c = 0x12340000;
+
+	for (i = 0; i < 256; ++i) {
+		k = crc32_reverseBit((u8)i);
+		for (c = ((u32)k) << 24, j = 8; j > 0; --j)
+			c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
+		p1 = (u8 *)&crc32_table[i];
+

drivers/staging/rtl8188eu/core/rtw_security.c static u8 crc32_reverseBit(u8 data) · line 122

Quoted 10 lines
drivers/staging/rtl8188eu/core/rtw_security.c +6 -0
+		p1[0] = crc32_reverseBit(p[3]);
+		p1[1] = crc32_reverseBit(p[2]);
+		p1[2] = crc32_reverseBit(p[1]);
+		p1[3] = crc32_reverseBit(p[0]);
 	}
+
+	bcrc32initialized = 1;
 }
 
 static __le32 getcrc32(u8 *buf, int len)

Always test build your code and ensure that you did not add any new build warnings or errors :(