Skip to contentSkip to conversation

Staging: ccree: Remove unused variable.

PATCH In review Srishti Sharma 4 participants 5 messages Sep 7, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v5 1/1 Staging: ccree: Remove unused variable.

Remove the local variable inflight_counter as it is never used.

---
Changes in v5:
- Correct the format of the subject.

 drivers/staging/ccree/ssi_cipher.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/ccree/ssi_cipher.c +0 -3
index 8d31a93..1ff3c8a 100644
@@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
 				  void __iomem *cc_base)
 {
 	int completion_error = 0;
-	u32 inflight_counter;
 	struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
 
 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-	/*Set the inflight couter value to local variable*/
-	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
 		ctx_p->drvdata->inflight_counter--;

--
2.7.4

Acked-by on v5 1/1
#2 lore raw
In reply to Srishti Sharma
Quoted 3 lines · Srishti Sharma

Remove the local variable inflight_counter as it is never used.

Quoted 34 lines

---
Changes in v5:
- Correct the format of the subject.

 drivers/staging/ccree/ssi_cipher.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/ccree/ssi_cipher.c +0 -4
index 8d31a93..1ff3c8a 100644
@@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
 				  void __iomem *cc_base)
 {
 	int completion_error = 0;
-	u32 inflight_counter;
 	struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
 
 	ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-	/*Set the inflight couter value to local variable*/
-	inflight_counter =  ctx_p->drvdata->inflight_counter;
 	/*Decrease the inflight counter*/
 	if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
 		ctx_p->drvdata->inflight_counter--;
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504770561-5554-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Acked-by on v5 1/1
#3 lore raw
In reply to Srishti Sharma

Hi,

Quoted 4 lines · Srishti Sharma

Remove the local variable inflight_counter as it is never used.

---

I've been meaning to clean that for some time now and never got around to do it. Thank you! :-)

Quoted 26 lines

Changes in v5:
- Correct the format of the subject.

 drivers/staging/ccree/ssi_cipher.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/ccree/ssi_cipher.c +0 -4
index 8d31a93..1ff3c8a 100644
@@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
                                  void __iomem *cc_base)
 {
        int completion_error = 0;
-       u32 inflight_counter;
        struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
 
        ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-       /*Set the inflight couter value to local variable*/
-       inflight_counter =  ctx_p->drvdata->inflight_counter;
        /*Decrease the inflight counter*/
        if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
                ctx_p->drvdata->inflight_counter--;
--

2.7.4

Signature · 6 lines
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru
#4 lore raw
Quoted 10 lines · Gilad Ben-Yossef

Hi,

Quoted 4 lines · Srishti Sharma

Remove the local variable inflight_counter as it is never used.

---

I've been meaning to clean that for some time now and never got around to do it. Thank you! :-)

Glad to know :)

Quoted 37 lines
Quoted 24 lines

Changes in v5:
- Correct the format of the subject.

 drivers/staging/ccree/ssi_cipher.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/staging/ccree/ssi_cipher.c +0 -4
index 8d31a93..1ff3c8a 100644
@@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
                                  void __iomem *cc_base)
 {
        int completion_error = 0;
-       u32 inflight_counter;
        struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
 
        ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
 
-       /*Set the inflight couter value to local variable*/
-       inflight_counter =  ctx_p->drvdata->inflight_counter;
        /*Decrease the inflight counter*/
        if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
                ctx_p->drvdata->inflight_counter--;
--
Quoted 2 lines

2.7.4

--
Gilad Ben-Yossef
Chief Coffee Drinker

Quoted 3 lines

"If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?"
-- Jean-Baptiste Queru

Regards,
Srishti