package/luvi: needs git submodules
PATCH 1/1 package/luvi: needs git submodules
Luvi bundles several libraries previously provided by the upstream tarball. Since the tarball is not available anymore we need to fetch the git submodules.
Fixes
http://autobuild.buildroot.net/results/26d/26d04350a761d362f40e7bd1ac09b639d61de91a/
--- package/luvi/luvi.hash | 2 +- package/luvi/luvi.mk | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
package/luvi/luvi.hash +1 -1
@@ -1,2 +1,2 @@ # Locally calculated -sha256 65d3ded5007d5bb58fc3b76013913596fd42ed7326310d67c668ddf9a017a179 luvi-v2.7.6.tar.gz +sha256 6d2297751b4d4023c1fa8b723b6f04e09584c67694958edbfa0d284f384759d5 luvi-v2.7.6.tar.gz
package/luvi/luvi.mk +2 -1
@@ -5,7 +5,8 @@ ################################################################################ LUVI_VERSION = v2.7.6 -LUVI_SITE = $(call github,luvit,luvi,$(LUVI_VERSION)) +LUVI_SITE = git://github.com/luvit/luvi.git +LUVI_GIT_SUBMODULES = YES LUVI_LICENSE = Apache-2.0 LUVI_LICENSE_FILES = LICENSE.txt LUVI_DEPENDENCIES = libuv luajit luv host-luajit
Signature · 1 line
2.11.0
PATCH 1/1 package/luvi: needs git submodules
Hello J?rg,
Since you are listed in the DEVELOPERS file for this package, could you comment/review/ack the below patch from Bernd touching luvi ?
Of course, git submodules and bundled libraries are not really nice, which is why I'm seeking your opinion.
Thanks!
Thomas
Quoted 35 lines · Bernd Kuhls
Luvi bundles several libraries previously provided by the upstream tarball. Since the tarball is not available anymore we need to fetch the git submodules.
Fixes
http://autobuild.buildroot.net/results/26d/26d04350a761d362f40e7bd1ac09b639d61de91a/Signed-off-by Bernd Kuhls <[email protected]>--- package/luvi/luvi.hash | 2 +- package/luvi/luvi.mk | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)package/luvi/luvi.hash +1
-1@@ -1,2 +1,2 @@ # Locally calculated -sha256 65d3ded5007d5bb58fc3b76013913596fd42ed7326310d67c668ddf9a017a179 luvi-v2.7.6.tar.gz +sha256 6d2297751b4d4023c1fa8b723b6f04e09584c67694958edbfa0d284f384759d5 luvi-v2.7.6.tar.gzpackage/luvi/luvi.mk +2
-1@@ -5,7 +5,8 @@ ################################################################################ LUVI_VERSION = v2.7.6 -LUVI_SITE = $(call github,luvit,luvi,$(LUVI_VERSION)) +LUVI_SITE = git://github.com/luvit/luvi.git +LUVI_GIT_SUBMODULES = YES LUVI_LICENSE = Apache-2.0 LUVI_LICENSE_FILES = LICENSE.txt LUVI_DEPENDENCIES = libuv luajit luv host-luajit
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 package/luvi: needs git submodules
Hello,
Quoted 5 lines · Thomas Petazzoni
Hello J?rg,
Since you are listed in the DEVELOPERS file for this package, could you comment/review/ack the below patch from Bernd touching luvi ?
Quoted 11 lines
Of course, git submodules and bundled libraries are not really nice, which is why I'm seeking your opinion.
Thanks!
Thomas
Quoted 3 lines · Bernd Kuhls
Luvi bundles several libraries previously provided by the upstream tarball. Since the tarball is not available anymore we need to fetch the git submodules.
I am quite sure that the maintainer simply forgot to add the release tarball (he already did before), that's why I opened an issue [1] asking for a tarball of the sources.
Quoted 2 lines
Until then, we need to fetch the git submodules to fix the build issue.
Quoted 21 lines
Quoted 21 lines
Signed-off-by Bernd Kuhls <[email protected]>--- package/luvi/luvi.hash | 2 +- package/luvi/luvi.mk | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)package/luvi/luvi.hash +1
-1@@ -1,2 +1,2 @@ # Locally calculated -sha256 65d3ded5007d5bb58fc3b76013913596fd42ed7326310d67c668ddf9a017a179 luvi-v2.7.6.tar.gz +sha256 6d2297751b4d4023c1fa8b723b6f04e09584c67694958edbfa0d284f384759d5 luvi-v2.7.6.tar.gzpackage/luvi/luvi.mk +0
-0@@ -5,7 +5,8 @@ ################################################################################
Quoted 8 lines
package/luvi/luvi.mk line 12
Quoted 7 lines
package/luvi/luvi.mk +2
-1LUVI_VERSION = v2.7.6 -LUVI_SITE = $(call github,luvit,luvi,$(LUVI_VERSION)) +LUVI_SITE = git://github.com/luvit/luvi.git +LUVI_GIT_SUBMODULES = YES LUVI_LICENSE = Apache-2.0 LUVI_LICENSE_FILES = LICENSE.txt LUVI_DEPENDENCIES = libuv luajit luv host-luajit
[1] https://github.com/luvit/luvi/issues/161
PATCH 1/1 package/luvi: needs git submodules
Quoted 15 lines · J?rg Krause
Hello,
Quoted 12 lines · Thomas Petazzoni
Hello J?rg,
Since you are listed in the DEVELOPERS file for this package, could you comment/review/ack the below patch from Bernd touching luvi ?
Of course, git submodules and bundled libraries are not really nice, which is why I'm seeking your opinion.
Thanks!
Thomas
Quoted 8 lines
Quoted 4 lines · Bernd Kuhls
Quoted 3 lines
Luvi bundles several libraries previously provided by the upstream tarball. Since the tarball is not available anymore we need to fetch the git submodules.
I am quite sure that the maintainer simply forgot to add the release tarball (he already did before), that's why I opened an issue [1] asking for a tarball of the sources.
Apparently there is still no tarball, so I applied to master, thanks.
Regards,
Arnout
Quoted 5 lines
Quoted 3 lines
Until then, we need to fetch the git submodules to fix the build issue.
[snip]
Quoted 9 lines
[1] https://github.com/luvit/luvi/issues/161
Acked-by "J?rg Krause <[email protected]>"_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF