Skip to contentSkip to conversation

Staging: ccree: Prefer using BIT macro.

PATCH In review Srishti Sharma 2 participants 3 messages Sep 7, 2017 – Sep 11, 2017

Subsystems (2)
Staging Crypto API
lore
Share & tools
lore

Srishti Sharma

author
#0 lore raw

PATCH v2 1/1 Staging: ccree: Prefer using BIT macro.

Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.

Signed-off-by Srishti Sharma <[email protected]>

---
Changes in v2:
- Add tab spaces before BIT macro.

 drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/ccree/ssi_cipher.h +5 -5
index 296b375..c9a83df 100644
@@ -27,11 +27,11 @@
 #include "ssi_buffer_mgr.h"
 
 /* Crypto cipher flags */
-#define CC_CRYPTO_CIPHER_KEY_KFDE0    (1 << 0)
-#define CC_CRYPTO_CIPHER_KEY_KFDE1    (1 << 1)
-#define CC_CRYPTO_CIPHER_KEY_KFDE2    (1 << 2)
-#define CC_CRYPTO_CIPHER_KEY_KFDE3    (1 << 3)
-#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
+#define CC_CRYPTO_CIPHER_KEY_KFDE0	BIT(0)
+#define CC_CRYPTO_CIPHER_KEY_KFDE1	BIT(1)
+#define CC_CRYPTO_CIPHER_KEY_KFDE2	BIT(2)
+#define CC_CRYPTO_CIPHER_KEY_KFDE3	BIT(3)
+#define CC_CRYPTO_CIPHER_DU_SIZE_512B	BIT(4)
 
 #define CC_CRYPTO_CIPHER_KEY_KFDE_MASK (CC_CRYPTO_CIPHER_KEY_KFDE0 | CC_CRYPTO_CIPHER_KEY_KFDE1 | CC_CRYPTO_CIPHER_KEY_KFDE2 | CC_CRYPTO_CIPHER_KEY_KFDE3)
maintainer
#1 lore raw
Quoted 9 lines · Srishti Sharma

Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.

Signed-off-by Srishti Sharma <[email protected]>

---
Changes in v2:
- Add tab spaces before BIT macro.

 drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

This change is already in my tree from someone else, sorry.

greg k-h

author
#2 lore raw
Quoted 8 lines · Greg KH
Quoted 7 lines · Srishti Sharma

Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.

Signed-off-by Srishti Sharma <[email protected]>

---
Changes in v2:
- Add tab spaces before BIT macro.

Quoted 4 lines
Quoted 2 lines
 drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

This change is already in my tree from someone else, sorry.

Oh.. It's okay !

Thanks,
Srishti

Quoted 2 lines

greg k-h