staging: rt8712: xmit_linux: Avoid multiple assignments in a single line
PATCH 1/1 staging: rt8712: xmit_linux: Avoid multiple assignments in a single line
Fixed coding style issue
--- drivers/staging/rtl8712/xmit_linux.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/rtl8712/xmit_linux.c +4 -2
@@ -49,8 +49,10 @@ static uint remainder_len(struct pkt_file *pfile)void _r8712_open_pktfile (_pkt *pktptr,struct pkt_file *pfile) { pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len; + pfile->cur_addr = pktptr->data; + pfile->buf_start = pfile->cur_addr; + pfile->pkt_len = pktptr->len; + pfile->buf_len = pfile->pkt_len; pfile->cur_buffer = pfile->buf_start; }
Signature · 1 line
1.9.1
Quoted 12 lines · harsha
Fixed coding style issue
Signed-off-by Harsha Sharma <[email protected]>--- drivers/staging/rtl8712/xmit_linux.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/staging/rtl8712/xmit_linux.c +0
-0
drivers/staging/rtl8712/xmit_linux.c static uint remainder_len(struct pkt_file *pfile) · line 53
Quoted 5 lines
drivers/staging/rtl8712/xmit_linux.c +0
-2@@ -49,8 +49,10 @@ static uint remainder_len(struct pkt_file *pfile)void _r8712_open_pktfile (_pkt *pktptr,struct pkt_file *pfile) { pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len;
I think this may be considered to be more readable as is.
julia
Quoted 17 lines
drivers/staging/rtl8712/xmit_linux.c +4
-1+ pfile->cur_addr = pktptr->data; + pfile->buf_start = pfile->cur_addr; + pfile->pkt_len = pktptr->len; + pfile->buf_len = pfile->pkt_len; pfile->cur_buffer = pfile->buf_start; } --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504859870-13153-1-git-send-email-harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Hi,
Thanks for your feedback.
I will take care about readability from next time.
With regards,
Harsha Sharma
Quoted 49 lines · Julia Lawall
Review
Quoted 8 lines · harsha
Fixed coding style issue
Signed-off-by Harsha Sharma <[email protected]>--- drivers/staging/rtl8712/xmit_linux.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/staging/rtl8712/xmit_linux.cdrivers/staging/rtl8712/xmit_linux.c static uint remainder_len(struct pkt_file *pfile) · line 53
Quoted 9 lines
index d13fd15..03c6b0c 100644
drivers/staging/rtl8712/xmit_linux.c +0
-2@@ -49,8 +49,10 @@ static uint remainder_len(struct pkt_file *pfile)void _r8712_open_pktfile (_pkt *pktptr,struct pkt_file *pfile) { pfile->pkt = pktptr; - pfile->cur_addr = pfile->buf_start = pktptr->data; - pfile->pkt_len = pfile->buf_len = pktptr->len;I think this may be considered to be more readable as is.
julia
Quoted 10 lines
drivers/staging/rtl8712/xmit_linux.c +4
-1+ pfile->cur_addr = pktptr->data; + pfile->buf_start = pfile->cur_addr; + pfile->pkt_len = pktptr->len; + pfile->buf_len = pfile->pkt_len; pfile->cur_buffer = pfile->buf_start; } --1.9.1
Quoted 2 lines
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/
msgid/outreachy-kernel/1504859870-13153-1-git-send-email-harshasharmaiitr% 40gmail.com.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Quoted 2 lines · Harsha Sharma
Hi,Thanks for your feedback.
I will take care about readability from next time.
Don't top post. You should respond to comments underneath the comment you are responding to. The person will have to go find that anyway, to understand what your comment is about. Please read the tutorial again, in particular the following:
https://kernelnewbies.org/PatchPhilosophy
https://kernelnewbies.org/CheckpatchTips
and everything starting from Responding to emails on
https://kernelnewbies.org/Outreachyfirstpatch
thanks,
julia
Quoted 59 lines
With regards,
Harsha SharmaOn Fri, Sep 8, 2017 at 2:16 PM, Julia Lawall <[email protected]> wrote:
On Fri, 8 Sep 2017, harsha wrote: > Fixed coding style issue > > Signed-off-by: Harsha Sharma <[email protected]> > --- >ᅵ drivers/staging/rtl8712/xmit_linux.c | 6 ++++-- >ᅵ 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8712/xmit_linux.c b/drivers/staging/rtl8712/xmit_linux.c > index d13fd15..03c6b0c 100644 > --- a/drivers/staging/rtl8712/xmit_linux.c > +++ b/drivers/staging/rtl8712/xmit_linux.c > @@ -49,8 +49,10 @@ static uint remainder_len(struct pkt_file *pfile) >ᅵ void _r8712_open_pktfile(_pkt *pktptr, struct pkt_file *pfile) >ᅵ { >ᅵ ᅵ ᅵ ᅵpfile->pkt = pktptr; > -ᅵ ᅵ ᅵpfile->cur_addr = pfile->buf_start = pktptr->data; > -ᅵ ᅵ ᅵpfile->pkt_len = pfile->buf_len = pktptr->len; I think this may be considered to be more readable as is. julia > +ᅵ ᅵ ᅵpfile->cur_addr = pktptr->data; > +ᅵ ᅵ ᅵpfile->buf_start = pfile->cur_addr; > +ᅵ ᅵ ᅵpfile->pkt_len = pktptr->len; > +ᅵ ᅵ ᅵpfile->buf_len = pfile->pkt_len; >ᅵ ᅵ ᅵ ᅵpfile->cur_buffer = pfile->buf_start; >ᅵ } > > -- > 1.9.1 >Quoted 2 lines
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
Quoted 1 line
To post to this group, send email to
Quoted 1 line
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/1504859870-13153-1-git-s
end-email-harshasharmaiitr%40gmail.com.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.