Skip to contentSkip to conversation

staging: typec: tcpm: Comparison to NULL changed as "!port->partner_altmode[pmdata->altmodes]"

PATCH In review Harsha Sharma 2 participants 2 messages Sep 8, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: typec: tcpm: Comparison to NULL changed as "!port->partner_altmode[pmdata->altmodes]"

Fixes coding style issue

---
 drivers/staging/typec/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/typec/tcpm.c +1 -1
index 630fe75..9f4a5a5 100644
@@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload,
 	}
 	port->partner_altmode[pmdata->altmodes] =
 		typec_partner_register_altmode(port->partner, paltmode);
-	if (port->partner_altmode[pmdata->altmodes] == NULL) {
+	if (!port->partner_altmode[pmdata->altmodes]) {
 		tcpm_log(port,
 			 "Failed to register alternate modes for SVID 0x%04x",
 			 paltmode->svid);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Harsha Sharma

Fixes coding style issue

Good job on getting the From issue sorted out.

The subject line change description is a bit verbose. One doesn't want to see the whole code, but rather the concept of what has changed. If you were going to tell someone about your patch, maybe someone ho knows about C but not about the Linux kernel, what is the first thing you would say?

Afterwards, there is perhaps not so much to say about such a change, but try to come up with something less generic for the log message, preferably something that doesn't use "fix". What is the purpose of doing the change. Just because a tool said to do it is not the best answer. How does it make the code better?

julia

Quoted 29 lines
---
 drivers/staging/typec/tcpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/typec/tcpm.c +1 -2
index 630fe75..9f4a5a5 100644
@@ -982,7 +982,7 @@ static void svdm_consume_modes(struct tcpm_port *port, const __le32 *payload,
 	}
 	port->partner_altmode[pmdata->altmodes] =
 		typec_partner_register_altmode(port->partner, paltmode);
-	if (port->partner_altmode[pmdata->altmodes] == NULL) {
+	if (!port->partner_altmode[pmdata->altmodes]) {
 		tcpm_log(port,
 			 "Failed to register alternate modes for SVID 0x%04x",
 			 paltmode->svid);
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504881248-26515-1-git-send-email-harshasharmaiitr%40gmail.com.
For more options, visit https://groups.google.com/d/optout.