Skip to contentSkip to conversation

ALSA: msnd: Optimize / harden DSP and MIDI loops

PATCH In review grygorii tertychnyi 3 participants 8 messages Sep 8, 2017 – Sep 12, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: msnd: Optimize / harden DSP and MIDI loops

Hi Greg,

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

Takashi Iwai (1):
ALSA: msnd: Optimize / harden DSP and MIDI loops

 sound/isa/msnd/msnd_midi.c     | 30 +++++++++++++++---------------
 sound/isa/msnd/msnd_pinnacle.c | 23 ++++++++++++-----------
 2 files changed, 27 insertions(+), 26 deletions(-)
Signature · 1 line
2.10.3.dirty
#2 lore raw
In reply to grygorii tertychnyi
Quoted 5 lines · grygorii tertychnyi

Hi Greg,

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

This vulnerability is just non-issue. You can't get it working practically; it requires a modified hardware of the decade old ISA sound card, and yet the system has to load / set up the module beforehand. We should withdraw it from CVE, IMO.

thanks,

Takashi

Quoted 11 lines

Takashi Iwai (1):
ALSA: msnd: Optimize / harden DSP and MIDI loops

 sound/isa/msnd/msnd_midi.c     | 30 +++++++++++++++---------------
 sound/isa/msnd/msnd_pinnacle.c | 23 ++++++++++++-----------
 2 files changed, 27 insertions(+), 26 deletions(-)
Signature · 1 line
2.10.3.dirty
#3 lore raw
Quoted 10 lines
Quoted 5 lines

Hi Greg,

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

This vulnerability is just non-issue. You can't get it working practically; it requires a modified hardware of the decade old ISA sound card, and yet the system has to load / set up the module beforehand. We should withdraw it from CVE, IMO.

I think it is worth having it in 4.4, 4.9 and 4.12 also.

Quoted 8 lines
Quoted 8 lines

Takashi Iwai (1):
ALSA: msnd: Optimize / harden DSP and MIDI loops

 sound/isa/msnd/msnd_midi.c     | 30 +++++++++++++++---------------
 sound/isa/msnd/msnd_pinnacle.c | 23 ++++++++++++-----------
 2 files changed, 27 insertions(+), 26 deletions(-)
#4 lore raw
Quoted 7 lines · Grygorii Tertychnyi (gtertych)
Quoted 7 lines
Quoted 6 lines

Hi Greg,

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

Quoted 6 lines
Quoted 4 lines

This vulnerability is just non-issue. You can't get it working practically; it requires a modified hardware of the decade old ISA sound card, and yet the system has to load / set up the module beforehand. We should withdraw it from CVE, IMO.

I think it is worth having it in 4.4, 4.9 and 4.12 also.

... even though the code has never been tested on the real hardware? That doesn't sound good for stable kernels at all. That's why I didn't put Cc to stable in the patch.

Takashi

#5 lore raw
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Grygorii Tertychnyi (gtertych)
Quoted 11 lines
Quoted 6 lines

Hi Greg,

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

This vulnerability is just non-issue. You can't get it working practically; it requires a modified hardware of the decade old ISA sound card, and yet the system has to load / set up the module beforehand. We should withdraw it from CVE, IMO.

Quoted 5 lines
Quoted 1 line

I think it is worth having it in 4.4, 4.9 and 4.12 also.

... even though the code has never been tested on the real hardware? That doesn't sound good for stable kernels at all. That's why I didn't put Cc to stable in the patch.

Oh, I didn't know that, want me to drop the patch from the stable queues now?

thanks,

greg k-h

#6 lore raw
Quoted 16 lines · On Tue, 12 Sep 2017 14:34:18 +0200, [email protected] wrote:
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Grygorii Tertychnyi (gtertych)
Quoted 11 lines
Quoted 6 lines

Hi Greg,

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

This vulnerability is just non-issue. You can't get it working practically; it requires a modified hardware of the decade old ISA sound card, and yet the system has to load / set up the module beforehand. We should withdraw it from CVE, IMO.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

I think it is worth having it in 4.4, 4.9 and 4.12 also.

... even though the code has never been tested on the real hardware? That doesn't sound good for stable kernels at all. That's why I didn't put Cc to stable in the patch.

Oh, I didn't know that, want me to drop the patch from the stable queues now?

Honestly, I don't mind. The patch should work, and even if it doesn't, it would be harmless as no one can see the breakage in practice :)

It's just ridiculous that people urge such commit for stable kernels even though they never tested / care the real cases but only look at the CVE entry.

thanks,

Takashi

#7 lore raw
In reply to Takashi Iwai
Quoted 5 lines · Takashi Iwai
Quoted 3 lines · grygorii tertychnyi

Hi Greg,

Quoted 7 lines
Quoted 2 lines

Could you please apply it for 4.4-stable.
This fixes https://nvd.nist.gov/vuln/detail/CVE-2017-9985

This vulnerability is just non-issue. You can't get it working practically; it requires a modified hardware of the decade old ISA sound card, and yet the system has to load / set up the module beforehand. We should withdraw it from CVE, IMO.

Hah, good luck trying to get a CVE withdrawn, people seem to love the foolish things...