Patch "mm/memory.c: fix mem_cgroup_oom_disable() call missing" has been added to the 4.13-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
mm/memory.c: fix mem_cgroup_oom_disable() call missing
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mm-memory.c-fix-mem_cgroup_oom_disable-call-missing.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
de0c799bba2610a8e1e9a50d76a28614520a4cd4Mon Sep 17 00:00:00 2001
From: Laurent Dufour <[email protected]>
Date: Fri, 8 Sep 2017 16:13:12 -0700
Subject: mm/memory.c: fix mem_cgroup_oom_disable() call missing
From: Laurent Dufour <[email protected]>
commit de0c799bba2610a8e1e9a50d76a28614520a4cd4 upstream.
Seen while reading the code, in handle_mm_fault(), in the case arch_vma_access_permitted() is failing the call to mem_cgroup_oom_disable() is not made.
To fix that, move the call to mem_cgroup_oom_enable() after calling arch_vma_access_permitted() as it should not have entered the memcg OOM.
--- mm/memory.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
mm/memory.c +5 -5
@@ -3888,6 +3888,11 @@ int handle_mm_fault(struct vm_area_struc/* do counter updates before entering really critical section. */ check_sync_rss_stat (current); +if (!arch_vma_access_permitted (vma, flags &FAULT_FLAG_WRITE , + flags &FAULT_FLAG_INSTRUCTION , + flags &FAULT_FLAG_REMOTE )) +return VM_FAULT_SIGSEGV ; +/* * Enable the memcg OOM handling for faults triggered in user * space. Kernel faults are handled more gracefully.
@@ -3895,11 +3900,6 @@ int handle_mm_fault(struct vm_area_strucif (flags &FAULT_FLAG_USER )mem_cgroup_oom_enable (); -if (!arch_vma_access_permitted (vma, flags &FAULT_FLAG_WRITE , - flags &FAULT_FLAG_INSTRUCTION , - flags &FAULT_FLAG_REMOTE )) -return VM_FAULT_SIGSEGV ; -if (unlikely (is_vm_hugetlb_page (vma))) ret =hugetlb_fault (vma->vm_mm, vma, address, flags);else
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/mm-memory.c-fix-mem_cgroup_oom_disable-call-missing.patch