Skip to contentSkip to conversation

Patch "mtd: nand: qcom: fix config error for BCH" has been added to the 4.9-stable tree

PATCH [email protected] 1 participant 1 message Sep 10, 2017

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mtd: nand: qcom: fix config error for BCH

to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mtd-nand-qcom-fix-config-error-for-bch.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 10777de570016471fd929869c7830a7772893e39 Mon Sep 17 00:00:00 2001

From: Abhishek Sahu <[email protected]>
Date: Thu, 3 Aug 2017 17:56:39 +0200
Subject: mtd: nand: qcom: fix config error for BCH

From: Abhishek Sahu <[email protected]>

commit 10777de570016471fd929869c7830a7772893e39 upstream.

The configuration for BCH is not correct in the current driver. The ECC_CFG_ECC_DISABLE bit defines whether to enable or disable the BCH ECC in which

	0x1 : BCH_DISABLED
	0x0 : BCH_ENABLED

But currently host->bch_enabled is being assigned to BCH_DISABLED.

Fixes c76b78d8ec05a ("mtd: nand: Qualcomm NAND controller driver")
---
 drivers/mtd/nand/qcom_nandc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/qcom_nandc.c +1 -1
@@ -1900,7 +1900,7 @@ static int qcom_nand_host_setup(struct q
 				| wide_bus << WIDE_FLASH
 				| 1 << DEV0_CFG1_ECC_DISABLE;
 
-	host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE
+	host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE
 				| 0 << ECC_SW_RESET
 				| host->cw_data << ECC_NUM_DATA_BYTES
 				| 1 << ECC_FORCE_CLK_OPEN

Patches currently in stable-queue which might be from [email protected] are

queue-4.9/mtd-nand-qcom-fix-config-error-for-bch.patch queue-4.9/mtd-nand-qcom-fix-read-failure-without-complete-bootchain.patch