Patch "Revert "firmware: add sanity check on shutdown/suspend"" has been added to the 4.13-stable tree

This is a note to let you know that I've just added the patch titled

Revert "firmware: add sanity check on shutdown/suspend"

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
revert-firmware-add-sanity-check-on-shutdown-suspend.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From: Linus Torvalds <[email protected]>
Date: Sun, 10 Sep 2017 21:19:06 -0700
Subject: Revert "firmware: add sanity check on shutdown/suspend"

From: Linus Torvalds <[email protected]>

commit f007cad159e99fa2acd3b2e9364fbb32ad28b971 upstream.

This reverts commit 81f95076281fdd3bc382e004ba1bce8e82fccbce.

It causes random failures of firmware loading at resume time (well, random for me, it seems to be more reliable for others) because the firmware disabling is not actually synchronous with any particular resume event, and at least the btusb driver that uses a workqueue to load the firmware at resume seems to occasionally hit the "firmware loading is disabled" logic because the firmware loader hasn't gotten the resume event yet.

Some kind of sanity check for not trying to load firmware when it's not possible might be a good thing, but this commit was not it.

Greg seems to have silently suffered the same issue, and pointed to the likely culprit, and Gabriel C verified the revert fixed it for him too.

---
 Documentation/driver-api/firmware/request_firmware.rst |   11 -
 drivers/base/firmware_class.c                          |   99 -----------------
 2 files changed, 110 deletions(-)

@@ -44,17 +44,6 @@ request_firmware_nowait
 .. kernel-doc:: drivers/base/firmware_class.c
    :functions: request_firmware_nowait
 
-Considerations for suspend and resume
-=====================================
-
-During suspend and resume only the built-in firmware and the firmware cache
-elements of the firmware API can be used. This is managed by fw_pm_notify().
-
-fw_pm_notify
-------------
-.. kernel-doc:: drivers/base/firmware_class.c
-   :functions: fw_pm_notify
-
 request firmware API expected driver use
 ========================================
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/mm-memory.c-fix-mem_cgroup_oom_disable-call-missing.patch queue-4.13/revert-firmware-add-sanity-check-on-shutdown-suspend.patch queue-4.13/mm-sparse.c-fix-typo-in-online_mem_sections.patch queue-4.13/mm-swapfile.c-fix-swapon-frontswap_map-memory-leak-on-error.patch queue-4.13/mm-kvfree-the-swap-cluster-info-if-the-swap-file-is-unsatisfactory.patch queue-4.13/selftests-x86-fsgsbase-test-selectors-1-2-and-3.patch queue-4.13/radix-tree-must-check-__radix_tree_preload-return-value.patch