Skip to contentSkip to conversation

ls1088ardb: Enable USB command RDB qspi-boot

PATCH New Ashish Kumar 3 participants 6 messages Sep 13, 2017 – Sep 14, 2017

Subsystems (2)
Arm (32-bit) USB
lore
Share & tools
lore

Ashish Kumar

author
#0 lore raw

PATCH 1/2 ls1088ardb: Enable USB command RDB qspi-boot

Signed-off-by Ashish Kumar <[email protected]>
Signed-off-by Amrita Kumari <[email protected]>

---

v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 arch/arm/dts/fsl-ls1088a.dtsi     | 14 ++++++++++++++
 configs/ls1088ardb_qspi_defconfig |  8 ++++++++
 include/configs/ls1088ardb.h      |  5 +++++
 include/linux/usb/xhci-fsl.h      |  2 +-
 4 files changed, 28 insertions(+), 1 deletion(-)
arch/arm/dts/fsl-ls1088a.dtsi +14 -0
index d943a9e..46ac475 100644
@@ -123,4 +123,18 @@
 		ranges = <0x81000000 0x0 0x00000000 0x30 0x00020000 0x0 0x00010000   /* downstream I/O */
 			  0x82000000 0x0 0x40000000 0x30 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
 	};
+
+	usb0: usb3 at 3100000 {
+		compatible = "fsl,layerscape-dwc3";
+		reg = <0x0 0x3100000 0x0 0x10000>;
+		interrupts = <0 80 0x4>; /* Level high type */
+		dr_mode = "host";
+	};
+
+	usb1: usb3 at 3110000 {
+		compatible = "fsl,layerscape-dwc3";
+		reg = <0x0 0x3110000 0x0 0x10000>;
+		interrupts = <0 81 0x4>; /* Level high type */
+		dr_mode = "host";
+	};
 };
configs/ls1088ardb_qspi_defconfig +8 -0
index 2d5a134..3034f50 100644
@@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
include/configs/ls1088ardb.h +5 -0
index 3223278..47ee527 100644
@@ -296,6 +296,11 @@
 #define CONFIG_PHY_GIGE
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT		2
+
 /*  MMC  */
 #ifdef CONFIG_MMC
 #define CONFIG_FSL_ESDHC
include/linux/usb/xhci-fsl.h +1 -1
index bd54089..a916afb 100644
@@ -58,7 +58,7 @@ struct fsl_xhci {
 #define CONFIG_SYS_FSL_XHCI_USB1_ADDR CONFIG_SYS_XHCI_USB1_ADDR
 #define CONFIG_SYS_FSL_XHCI_USB2_ADDR 0
 #define CONFIG_SYS_FSL_XHCI_USB3_ADDR 0
-#elif defined(CONFIG_ARCH_LS2080A)
+#elif defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LS1088A)
 #define CONFIG_SYS_FSL_XHCI_USB1_ADDR CONFIG_SYS_XHCI_USB1_ADDR
 #define CONFIG_SYS_FSL_XHCI_USB2_ADDR CONFIG_SYS_XHCI_USB2_ADDR
 #define CONFIG_SYS_FSL_XHCI_USB3_ADDR 0
Signature · 1 line
2.7.4
author
#1 lore raw

PATCH 2/2 ls1088aqds: Enable USB command on QDS for qspi-boot

Signed-off-by Amrita Kumari <[email protected]>
Signed-off-by Ashish Kumar <[email protected]>

---
v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 configs/ls1088aqds_qspi_defconfig | 8 ++++++++
 include/configs/ls1088aqds.h      | 5 +++++
 2 files changed, 13 insertions(+)
configs/ls1088aqds_qspi_defconfig +8 -0
index 4b0d604..a24a601 100644
@@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
include/configs/ls1088aqds.h +5 -0
index 3547b0b..c57e1f5 100644
@@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);
 	"mcmemsize=0x70000000 \0"
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL
+#define CONFIG_USB_MAX_CONTROLLER_COUNT                2
+
 #ifdef CONFIG_FSL_MC_ENET
 #define CONFIG_FSL_MEMAC
 #define	CONFIG_PHYLIB
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 ls1088aqds: Enable USB command on QDS for qspi-boot

Quoted 32 lines · Ashish Kumar
Signed-off-by Amrita Kumari <[email protected]>
Signed-off-by Ashish Kumar <[email protected]>

---
v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 configs/ls1088aqds_qspi_defconfig | 8 ++++++++
 include/configs/ls1088aqds.h      | 5 +++++
 2 files changed, 13 insertions(+)
configs/ls1088aqds_qspi_defconfig +8 -0
index 4b0d604..a24a601 100644
@@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
include/configs/ls1088aqds.h +0 -0
index 3547b0b..c57e1f5 100644

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 368

Quoted 6 lines
include/configs/ls1088aqds.h +3 -0
@@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);
        "mcmemsize=0x70000000 \0"
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL

Please convert this as a Kconfig option.

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 369

Quoted 1 line
include/configs/ls1088aqds.h +1 -0
+#define CONFIG_USB_MAX_CONTROLLER_COUNT                2

CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB. Please remove.

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void);

Quoted 5 lines
include/configs/ls1088aqds.h +1 -1
+
 #ifdef CONFIG_FSL_MC_ENET
 #define CONFIG_FSL_MEMAC
 #define        CONFIG_PHYLIB
--

Regards,
Bin

author
#3 lore raw

PATCH 2/2 ls1088aqds: Enable USB command on QDS for qspi-boot

Hello Ran,

Could you please help here to convert to Kconfig option?

Regards
Ashish

-----Original Message-----
From: Bin Meng [mailto:bmeng.cn at gmail.com]
Sent: Wednesday, September 13, 2017 2:15 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot Mailing List <[email protected]>; Amrita Kumari <[email protected]>; prabhakar.khuswaha at nxp.com
Subject: Re: [U-Boot] [PATCH 2/2] ls1088aqds: Enable USB command on QDS for qspi-boot

Quoted 32 lines · Ashish Kumar
Signed-off-by Amrita Kumari <[email protected]>
Signed-off-by Ashish Kumar <[email protected]>

---
v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 configs/ls1088aqds_qspi_defconfig | 8 ++++++++
 include/configs/ls1088aqds.h      | 5 +++++
 2 files changed, 13 insertions(+)
configs/ls1088aqds_qspi_defconfig +8 -0
index 4b0d604..a24a601 100644
@@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set  CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
(quoted diff) +0 -0

b/include/configs/ls1088aqds.h index 3547b0b..c57e1f5 100644

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 368

Quoted 6 lines
include/configs/ls1088aqds.h +3 -0
@@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);
        "mcmemsize=0x70000000 \0"
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL

Please convert this as a Kconfig option.

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 369

Quoted 1 line
include/configs/ls1088aqds.h +1 -0
+#define CONFIG_USB_MAX_CONTROLLER_COUNT                2

CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB. Please remove.

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void);

Quoted 5 lines
include/configs/ls1088aqds.h +1 -1
+
 #ifdef CONFIG_FSL_MC_ENET
 #define CONFIG_FSL_MEMAC
 #define        CONFIG_PHYLIB
--

Regards,
Bin

#4 lore raw

PATCH 2/2 ls1088aqds: Enable USB command on QDS for qspi-boot

Hi Ashish

Quoted 68 lines

-----Original Message-----
From: Ashish Kumar
Sent: Thursday, September 14, 2017 12:49 AM
To: Ran Wang <[email protected]>
Cc: U-Boot Mailing List <[email protected]>; Bin Meng <[email protected]>; prabhakar.khuswaha at nxp.com
Subject: RE: [U-Boot] [PATCH 2/2] ls1088aqds: Enable USB command on QDS for qspi-boot

Hello Ran,

Could you please help here to convert to Kconfig option?

Regards
Ashish

-----Original Message-----
From: Bin Meng [mailto:bmeng.cn at gmail.com]
Sent: Wednesday, September 13, 2017 2:15 PM
To: Ashish Kumar <[email protected]>
Cc: U-Boot Mailing List <[email protected]>; Amrita Kumari <[email protected]>; prabhakar.khuswaha at nxp.com
Subject: Re: [U-Boot] [PATCH 2/2] ls1088aqds: Enable USB command on QDS for qspi-boot

Quoted 32 lines · Ashish Kumar
Signed-off-by Amrita Kumari <[email protected]>
Signed-off-by Ashish Kumar <[email protected]>

---
v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 configs/ls1088aqds_qspi_defconfig | 8 ++++++++
 include/configs/ls1088aqds.h      | 5 +++++
 2 files changed, 13 insertions(+)
configs/ls1088aqds_qspi_defconfig +8 -0
index 4b0d604..a24a601 100644
@@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set  CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
(quoted diff) +0 -0

b/include/configs/ls1088aqds.h index 3547b0b..c57e1f5 100644

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 368

Quoted 6 lines
include/configs/ls1088aqds.h +3 -0
@@ -363,6 +363,11 @@ unsigned long get_board_ddr_clk(void);
        "mcmemsize=0x70000000 \0"
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL

Please convert this as a Kconfig option.

Quoted 4 lines

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void); · line 369

Quoted 1 line
include/configs/ls1088aqds.h +1 -0
+#define CONFIG_USB_MAX_CONTROLLER_COUNT                2

CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB. Please remove.

Sure, so I need to continue your patchwork or submit it as a new one after yours applied? BR
Ran

Quoted 9 lines

include/configs/ls1088aqds.h unsigned long get_board_ddr_clk(void);

Quoted 6 lines
include/configs/ls1088aqds.h +1 -1
+
 #ifdef CONFIG_FSL_MC_ENET
 #define CONFIG_FSL_MEMAC
 #define        CONFIG_PHYLIB
--

Regards,
Bin

#5 lore raw

PATCH 1/2 ls1088ardb: Enable USB command RDB qspi-boot

In reply to Ashish Kumar
Quoted 58 lines · Ashish Kumar
Signed-off-by Ashish Kumar <[email protected]>
Signed-off-by Amrita Kumari <[email protected]>

---

v1:
Rebased to
ba39608 ARM: DRA72x: Add support for detection of DRA71x SR 2.1

 arch/arm/dts/fsl-ls1088a.dtsi     | 14 ++++++++++++++
 configs/ls1088ardb_qspi_defconfig |  8 ++++++++
 include/configs/ls1088ardb.h      |  5 +++++
 include/linux/usb/xhci-fsl.h      |  2 +-
 4 files changed, 28 insertions(+), 1 deletion(-)
arch/arm/dts/fsl-ls1088a.dtsi +14 -0
index d943a9e..46ac475 100644
@@ -123,4 +123,18 @@
                ranges = <0x81000000 0x0 0x00000000 0x30 0x00020000 0x0 0x00010000   /* downstream I/O */
                          0x82000000 0x0 0x40000000 0x30 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
        };
+
+       usb0: usb3 at 3100000 {
+               compatible = "fsl,layerscape-dwc3";
+               reg = <0x0 0x3100000 0x0 0x10000>;
+               interrupts = <0 80 0x4>; /* Level high type */
+               dr_mode = "host";
+       };
+
+       usb1: usb3 at 3110000 {
+               compatible = "fsl,layerscape-dwc3";
+               reg = <0x0 0x3110000 0x0 0x10000>;
+               interrupts = <0 81 0x4>; /* Level high type */
+               dr_mode = "host";
+       };
 };
configs/ls1088ardb_qspi_defconfig +8 -0
index 2d5a134..3034f50 100644
@@ -31,3 +31,11 @@ CONFIG_FSL_DSPI=y
 CONFIG_EFI_LOADER_BOUNCE_BUFFER=y
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_FSL_LS_PPA=y
+CONFIG_USB=y
+CONFIG_USB_GADGET=y
+CONFIG_CMD_USB=y
+CONFIG_DM_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_STORAGE=y
include/configs/ls1088ardb.h +0 -0
index 3223278..47ee527 100644

include/configs/ls1088ardb.h line 301

Quoted 6 lines
include/configs/ls1088ardb.h +3 -0
@@ -296,6 +296,11 @@
 #define CONFIG_PHY_GIGE
 #endif
 
+/*  USB  */
+#define CONFIG_HAS_FSL_XHCI_USB
+#define CONFIG_USB_XHCI_FSL

Please convert this as a Kconfig option.

include/configs/ls1088ardb.h line 302

Quoted 1 line
include/configs/ls1088ardb.h +1 -0
+#define CONFIG_USB_MAX_CONTROLLER_COUNT                2

CONFIG_USB_MAX_CONTROLLER_COUNT is not used anywhere in DM USB. Please remove.

Quoted 9 lines
include/configs/ls1088ardb.h +1 -0
+
 /*  MMC  */
 #ifdef CONFIG_MMC
 #define CONFIG_FSL_ESDHC
include/linux/usb/xhci-fsl.h +0 -0
index bd54089..a916afb 100644

include/linux/usb/xhci-fsl.h struct fsl_xhci {

Quoted 9 lines
include/linux/usb/xhci-fsl.h +1 -2
@@ -58,7 +58,7 @@ struct fsl_xhci {
 #define CONFIG_SYS_FSL_XHCI_USB1_ADDR CONFIG_SYS_XHCI_USB1_ADDR
 #define CONFIG_SYS_FSL_XHCI_USB2_ADDR 0
 #define CONFIG_SYS_FSL_XHCI_USB3_ADDR 0
-#elif defined(CONFIG_ARCH_LS2080A)
+#elif defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LS1088A)
 #define CONFIG_SYS_FSL_XHCI_USB1_ADDR CONFIG_SYS_XHCI_USB1_ADDR
 #define CONFIG_SYS_FSL_XHCI_USB2_ADDR CONFIG_SYS_XHCI_USB2_ADDR
 #define CONFIG_SYS_FSL_XHCI_USB3_ADDR 0
--

Regards,
Bin