Skip to contentSkip to conversation

drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.

PATCH In review Allen Pais 2 participants 3 messages Sep 13, 2017 x86 platform drivers

lore
Share & tools
lore

Allen Pais

author
#0 lore raw

PATCH 1/1 drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.

---
 drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_telemetry_debugfs.c +1 -1
index d4fc42b..3ccc7ac 100644
@@ -76,7 +76,7 @@
 #define TELEM_IOSS_DX_D0IX_EVTS		25
 #define TELEM_IOSS_PG_EVTS		30
 
-#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
+#define TELEM_EVT_LEN(x) (ARRAY_SIZE(x))
 
 #define TELEM_DEBUGFS_CPU(model, data) \
 	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
Signature · 1 line
2.7.4
#1 lore raw

Hi Allen,

Quoted 21 lines

-----Original Message-----
From: [email protected] [mailto:platform-driver- [email protected]] On Behalf Of Allen Pais
Sent: Wednesday, September 13, 2017 1:33 PM
To: [email protected]
Cc: Chakravarty, Souvik K <[email protected]>; platform- [email protected]; Allen Pais <[email protected]>
Subject: [PATCH] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.

---
 drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel_telemetry_debugfs.c +0 -0
index d4fc42b..3ccc7ac 100644

drivers/platform/x86/intel_telemetry_debugfs.c line 79

Quoted 5 lines
drivers/platform/x86/intel_telemetry_debugfs.c +1 -1
@@ -76,7 +76,7 @@
 #define TELEM_IOSS_DX_D0IX_EVTS		25
 #define TELEM_IOSS_PG_EVTS		30
 
-#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
+#define TELEM_EVT_LEN(x) (ARRAY_SIZE(x))

The outer parenthesis seems redundant to me.

Quoted 6 lines
drivers/platform/x86/intel_telemetry_debugfs.c +0 -1
 #define TELEM_DEBUGFS_CPU(model, data) \
 	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned
 long)&data}
--

2.7.4

BR,
Souvik

author
#2 lore raw
Quoted 6 lines

drivers/platform/x86/intel_telemetry_debugfs.c line 79

Quoted 4 lines

#define TELEM_IOSS_PG_EVTS 30

drivers/platform/x86/intel_telemetry_debugfs.c +1 -1
-#define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
+#define TELEM_EVT_LEN(x) (ARRAY_SIZE(x))

The outer parenthesis seems redundant to me.

Will send out a v2. Thanks.

- Allen