Skip to contentSkip to conversation

configure: Allow --enable-seccomp on s390x, too

PATCH Applied Thomas Huth 5 participants 6 messages Sep 14, 2017

lore
Share & tools
lore

Thomas Huth

author
#0 lore raw

PATCH 1/1 configure: Allow --enable-seccomp on s390x, too

libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Signed-off-by Thomas Huth <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index fd7e3a5..83ba64e 100755
@@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
     arm|aarch64)
         libseccomp_minver="2.2.3"
         ;;
-    ppc|ppc64)
+    ppc|ppc64|s390x)
         libseccomp_minver="2.3.0"
         ;;
     *)
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 4 lines · Thomas Huth

libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too.

I don't have a s390x hardware to test so I'll have to trust you. Anyone from IBM interested in testing this patch as well?

Quoted 21 lines
Signed-off-by Thomas Huth <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index fd7e3a5..83ba64e 100755
@@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
     arm|aarch64)
         libseccomp_minver="2.2.3"
         ;;
-    ppc|ppc64)
+    ppc|ppc64|s390x)
         libseccomp_minver="2.3.0"
         ;;
     *)
Signature · 1 line
1.8.3.1
Signature · 2 lines
Eduardo Otubo
Senior Software Engineer @ RedHat
Acked-by on v1 1/1
#2 lore raw
In reply to Thomas Huth
Quoted 3 lines · Thomas Huth

libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Seems to work fine on s390x.

Acked-by Christian Borntraeger <[email protected]>
Quoted 20 lines
Signed-off-by Thomas Huth <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index fd7e3a5..83ba64e 100755
@@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
     arm|aarch64)
         libseccomp_minver="2.2.3"
         ;;
-    ppc|ppc64)
+    ppc|ppc64|s390x)
         libseccomp_minver="2.3.0"
         ;;
     *)
Acked-by
#3 lore raw
Quoted 7 lines · Christian Borntraeger
Quoted 3 lines · Thomas Huth

libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Seems to work fine on s390x.

Acked-by Christian Borntraeger <[email protected]>

Cool, thanks :-)

Acked-by Eduardo Otubo <[email protected]>
Quoted 22 lines
Quoted 21 lines
Signed-off-by Thomas Huth <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +1 -1
index fd7e3a5..83ba64e 100755
@@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
     arm|aarch64)
         libseccomp_minver="2.2.3"
         ;;
-    ppc|ppc64)
+    ppc|ppc64|s390x)
         libseccomp_minver="2.3.0"
         ;;
     *)
Signature · 2 lines
Eduardo Otubo
Senior Software Engineer @ RedHat
Applied
#5 lore raw
In reply to Thomas Huth
Quoted 14 lines · On Thu, 14 Sep 2017 12:36:03 +0200 Thomas Huth <[email protected]> wrote:

libseccomp supports s390x since version 2.3.0, and I was able to start a VM with "-sandbox on" without any obvious problems by using this patch, so it should be safe to allow --enable-seccomp on s390x nowadays, too.

Signed-off-by Thomas Huth <[email protected]>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure +0 -0
index fd7e3a5..83ba64e 100755

configure if test "$seccomp" != "no" ; then · line 2038

Quoted 8 lines
configure +1 -1
@@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
     arm|aarch64)
         libseccomp_minver="2.2.3"
         ;;
-    ppc|ppc64)
+    ppc|ppc64|s390x)
         libseccomp_minver="2.3.0"
         ;;
     *)

Thanks, applied.