Skip to contentSkip to conversation

Staging: lustre: obdclass: Use kcalloc instead of kzalloc

PATCH In review Srishti Sharma 2 participants 2 messages Sep 14, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: lustre: obdclass: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

---
 drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -1
index 95c7fa3..28cb8489 100644
@@ -1016,7 +1016,7 @@ int cl_global_init(void)
 {
 	int result;
 
-	cl_envs = kzalloc(sizeof(*cl_envs) * num_possible_cpus(), GFP_KERNEL);
+	cl_envs = kcalloc(num_possible_cpus(), sizeof(*cl_envs), GFP_KERNEL);
 	if (!cl_envs) {
 		result = -ENOMEM;
 		goto out;
Signature · 1 line
2.7.4
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Srishti Sharma

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

Quoted 27 lines
---
 drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -2
index 95c7fa3..28cb8489 100644
@@ -1016,7 +1016,7 @@ int cl_global_init(void)
 {
 	int result;
 
-	cl_envs = kzalloc(sizeof(*cl_envs) * num_possible_cpus(), GFP_KERNEL);
+	cl_envs = kcalloc(num_possible_cpus(), sizeof(*cl_envs), GFP_KERNEL);
 	if (!cl_envs) {
 		result = -ENOMEM;
 		goto out;
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505390789-3814-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.