Skip to contentSkip to conversation

Staging: ccree: Use kcalloc instead of kzalloc

PATCH In review Srishti Sharma 2 participants 2 messages Sep 14, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: ccree: Use kcalloc instead of kzalloc

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

---
Changes in v2:
- eliminate parentheses around the first argument

 drivers/staging/ccree/ssi_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ccree/ssi_sysfs.c +1 -1
index 0655658..f7e0c502 100644
@@ -376,7 +376,7 @@ static int sys_init_dir(struct sys_dir *sys_dir, struct ssi_drvdata *drvdata,
 		return -ENOMEM;
 	/* allocate memory for directory's attributes list */
 	sys_dir->sys_dir_attr_list =
-		kzalloc(sizeof(struct attribute *) * (num_of_attrs + 1),
+		kcalloc(num_of_attrs + 1, sizeof(struct attribute *),
 			GFP_KERNEL);
 
 	if (!(sys_dir->sys_dir_attr_list)) {
Signature · 1 line
2.7.4
Acked-by on v2 1/1
#1 lore raw
Quoted 7 lines · Srishti Sharma

Use kcalloc instead of kzalloc to check for overflow before multiplication. Done using the following semantic patch by coccinelle.

http://coccinelle.lip6.fr/rules/kzalloc.cocci

Quoted 30 lines

---
Changes in v2:
- eliminate parentheses around the first argument

 drivers/staging/ccree/ssi_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ccree/ssi_sysfs.c +1 -2
index 0655658..f7e0c502 100644
@@ -376,7 +376,7 @@ static int sys_init_dir(struct sys_dir *sys_dir, struct ssi_drvdata *drvdata,
 		return -ENOMEM;
 	/* allocate memory for directory's attributes list */
 	sys_dir->sys_dir_attr_list =
-		kzalloc(sizeof(struct attribute *) * (num_of_attrs + 1),
+		kcalloc(num_of_attrs + 1, sizeof(struct attribute *),
 			GFP_KERNEL);
 
 	if (!(sys_dir->sys_dir_attr_list)) {
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505393293-5941-1-git-send-email-srishtishar%40gmail.com.
For more options, visit https://groups.google.com/d/optout.