Skip to contentSkip to conversation

Patch "f2fs: let fill_super handle roll-forward errors" has been added to the 4.12-stable tree

PATCH [email protected] 1 participant 1 message Sep 16, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

f2fs: let fill_super handle roll-forward errors

to the 4.12-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
f2fs-let-fill_super-handle-roll-forward-errors.patch
and it can be found in the queue-4.12 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From afd2b4da40b3b567ef8d8e6881479345a2312a03 Mon Sep 17 00:00:00 2001

From: Jaegeuk Kim <[email protected]>
Date: Thu, 10 Aug 2017 17:35:04 -0700
Subject: f2fs: let fill_super handle roll-forward errors

From: Jaegeuk Kim <[email protected]>

commit afd2b4da40b3b567ef8d8e6881479345a2312a03 upstream.

If we set CP_ERROR_FLAG in roll-forward error, f2fs is no longer to proceed any IOs due to f2fs_cp_error(). But, for example, if some stale data is involved on roll-forward process, we're able to get -ENOENT, getting fs stuck. If we get any error, let fill_super set SBI_NEED_FSCK and try to recover back to stable point.

---
 fs/f2fs/recovery.c |    2 --
 1 file changed, 2 deletions(-)
fs/f2fs/recovery.c +0 -2
@@ -599,8 +599,6 @@ out:
 	}
 
 	clear_sbi_flag(sbi, SBI_POR_DOING);
-	if (err)
-		set_ckpt_flags(sbi, CP_ERROR_FLAG);
 	mutex_unlock(&sbi->cp_mutex);
 
 	/* let's drop all the directory inodes for clean checkpoint */

Patches currently in stable-queue which might be from [email protected] are

queue-4.12/f2fs-let-fill_super-handle-roll-forward-errors.patch queue-4.12/f2fs-check-hot_data-for-roll-forward-recovery.patch