Skip to contentSkip to conversation

Patch "thunderbolt: Make key root-only accessible" has been added to the 4.13-stable tree

PATCH [email protected] 1 participant 1 message Sep 16, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

thunderbolt: Make key root-only accessible

to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
thunderbolt-make-key-root-only-accessible.patch
and it can be found in the queue-4.13 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 0956e41169222822d3557871fcd1d32e4fa7e934 Mon Sep 17 00:00:00 2001

From: "Bernat, Yehezkel" <[email protected]>
Date: Tue, 15 Aug 2017 08:19:12 +0300
Subject: thunderbolt: Make key root-only accessible

From: Bernat, Yehezkel <[email protected]>

commit 0956e41169222822d3557871fcd1d32e4fa7e934 upstream.

Non-root user may read the key back after root wrote it there. This removes read access to everyone but root.

---
 drivers/thunderbolt/switch.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/switch.c +1 -1
@@ -826,7 +826,7 @@ static ssize_t key_store(struct device *
 	mutex_unlock(&switch_lock);
 	return ret;
 }
-static DEVICE_ATTR_RW(key);
+static DEVICE_ATTR(key, 0600, key_show, key_store);
 
 static ssize_t nvm_authenticate_show(struct device *dev,
 	struct device_attribute *attr, char *buf)

Patches currently in stable-queue which might be from [email protected] are

queue-4.13/thunderbolt-make-key-root-only-accessible.patch queue-4.13/thunderbolt-remove-superfluous-check.patch queue-4.13/thunderbolt-allow-clearing-the-key.patch