Patch "x86/mm, mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages" has been added to the 4.13-stable tree
Subsystems (6)
This is a note to let you know that I've just added the patch titled
x86/mm, mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
x86-mm-mm-hwpoison-clear-present-bit-for-kernel-1-1-mappings-of-poison-pages.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
ce0fa3e56ad20f04d8252353dcd24e924abdafcaMon Sep 17 00:00:00 2001
From: Tony Luck <[email protected]>
Date: Wed, 16 Aug 2017 10:18:03 -0700
Subject: x86/mm, mm/hwpoison: Clear PRESENT bit for kernel 1:1 mappings of poison pages
From: Tony Luck <[email protected]>
commit ce0fa3e56ad20f04d8252353dcd24e924abdafca upstream.
Speculative processor accesses may reference any memory that has a valid page table entry. While a speculative access won't generate a machine check, it will log the error in a machine check bank. That could cause escalation of a subsequent error since the overflow bit will be then set in the machine check bank status register.
Code has to be double-plus-tricky to avoid mentioning the 1:1 virtual address of the page we want to map out otherwise we may trigger the very problem we are trying to avoid. We use a non-canonical address that passes through the usual Linux table walking code to get to the same "pte".
Thanks to Dave Hansen for reviewing several iterations of this.
Also see:
http://marc.info/?l=linux-mm&m=149860136413338&w=2
--- arch/x86/include/asm/page_64.h | 4 +++ arch/x86/kernel/cpu/mcheck/mce.c | 43 +++++++++++++++++++++++++++++++++++++++ include/linux/mm_inline.h | 6 +++++ mm/memory-failure.c | 2 + 4 files changed, 55 insertions(+)
arch/x86/include/asm/page_64.h +4 -0
@@ -51,6 +51,10 @@ static inline void clear_page(void *pagevoid copy_page (void *to,void *from); +#ifdef CONFIG_X86_MCE +#define arch_unmap_kpfn arch_unmap_kpfn +#endif +#endif /* !__ASSEMBLY__ */ #ifdef CONFIG_X86_VSYSCALL_EMULATION
arch/x86/kernel/cpu/mcheck/mce.c +43 -0
55 lines not on this page · raw message
include/linux/mm_inline.h +6 -0
@@ -126,4 +126,10 @@ static __always_inline enum lru_list pag#define lru_to_page (head) (list_entry((head)->prev, struct page, lru)) +#ifdef arch_unmap_kpfn +extern void arch_unmap_kpfn (unsigned long pfn); +#else +static __always_inline void arch_unmap_kpfn(unsigned long pfn) { } +#endif +#endif
mm/memory-failure.c +2 -0
@@ -1146,6 +1146,8 @@ int memory_failure(unsigned long pfn, inreturn 0 ; } +arch_unmap_kpfn (pfn); + orig_head = hpage =compound_head (p);num_poisoned_pages_inc ();
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/x86-mm-mm-hwpoison-clear-present-bit-for-kernel-1-1-mappings-of-poison-pages.patch