drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
Subsystems (2)
cover drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
This patch series introduces fixes to reduce dependency for I915_MAX_PIPES and minor optimizations to reduce hardcoding.
Kahola, Mika (1):
drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation
Mika Kahola (4):
drm/i915: Don't relay on I915_MAX_PIPES
drm/i915: Fold IRQ pipe masks
drm/i915: Favor for_each_pipe() macro
drm/i915: Cleanup South Error Interrupts
drivers/gpu/drm/i915/i915_irq.c | 19 +++++++------------ drivers/gpu/drm/i915/i915_reg.h | 3 --- drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pipe_crc.c | 9 +++++---- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 7 files changed, 23 insertions(+), 24 deletions(-)
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/5 drm/i915: Don't relay on I915_MAX_PIPES
Let's remove the dependency on I915_MAX_PIPES. Instead, get the number of pipes from platform information.
--- drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_pipe_crc.c | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_audio.c +1 -1
@@ -759,7 +759,7 @@ static struct intel_encoder *get_saved_enc(struct drm_i915_private *dev_priv, {struct intel_encoder *encoder; -if (WARN_ON (pipe >=I915_MAX_PIPES )) +if (WARN_ON (pipe >=INTEL_INFO (dev_priv)->num_pipes))return NULL ;/* MST */
drivers/gpu/drm/i915/intel_pipe_crc.c +4 -3
@@ -775,11 +775,12 @@ display_crc_ctl_parse_object(const char *buf, enum intel_pipe_crc_object *o)return -EINVAL ; } -static int display_crc_ctl_parse_pipe (const char *buf,enum pipe *pipe) +static int display_crc_ctl_parse_pipe (struct drm_i915_private *dev_priv, +const char *buf,enum pipe *pipe) {const char name = buf[0 ]; -if (name <'A' || name >=pipe_name (I915_MAX_PIPES )) +if (name <'A' || name >=pipe_name (INTEL_INFO (dev_priv)->num_pipes))return -EINVAL ; *pipe = name -'A' ;
@@ -828,7 +829,7 @@ static int display_crc_ctl_parse(struct drm_i915_private *dev_priv,return -EINVAL ; } -if (display_crc_ctl_parse_pipe (words[1 ], &pipe) <0 ) { +if (display_crc_ctl_parse_pipe (dev_priv, words[1 ], &pipe) <0 ) {DRM_DEBUG_DRIVER ("unknown pipe %s\n" , words[1 ]);return -EINVAL ; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation
In reply to Mika KaholaFrom: "Kahola, Mika" <[email protected]>
Remove dependency for I915_MAX_PIPES by replacing it with for_each_pipe() macro.
--- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 3 files changed, 10 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_display.c +4 -1
@@ -12220,7 +12220,10 @@ static void skl_update_crtcs(struct drm_atomic_state *state)if (updated & cmask || !cstate->base.active)continue ; -if (skl_ddb_allocation_overlaps (entries, &cstate->wm.skl.ddb, i)) +if (skl_ddb_allocation_overlaps (dev_priv, + entries, + &cstate->wm.skl.ddb, + i))continue ; updated |= cmask;
drivers/gpu/drm/i915/intel_drv.h +2 -1
@@ -1891,7 +1891,8 @@ int intel_enable_sagv(struct drm_i915_private *dev_priv);int intel_disable_sagv (struct drm_i915_private *dev_priv);bool skl_wm_level_equals (const struct skl_wm_level *l1,const struct skl_wm_level *l2); -bool skl_ddb_allocation_overlaps (const struct skl_ddb_entry **entries, +bool skl_ddb_allocation_overlaps (struct drm_i915_private *dev_priv, +const struct skl_ddb_entry **entries,const struct skl_ddb_entry *ddb,int ignore);bool ilk_disable_lp_wm (struct drm_device *dev);
drivers/gpu/drm/i915/intel_pm.c +4 -2
@@ -4821,16 +4821,18 @@ static inline bool skl_ddb_entries_overlap(const struct skl_ddb_entry *a,return a->start < b->end && b->start < a->end; } -bool skl_ddb_allocation_overlaps (const struct skl_ddb_entry **entries, +bool skl_ddb_allocation_overlaps (struct drm_i915_private *dev_priv, +const struct skl_ddb_entry **entries,const struct skl_ddb_entry *ddb,int ignore) {int i; -for (i =0 ; i <I915_MAX_PIPES ; i++) +for_each_pipe (dev_priv, i) {if (i != ignore && entries[i] &&skl_ddb_entries_overlap (ddb, entries[i]))return true; + }return false; }
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/5] drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation
Quoted 48 lines · Mika Kahola
From: "Kahola, Mika" <[email protected]>
Remove dependency for
I915_MAX_PIPESby replacing it withfor_each_pipe()macro.Signed-off-by Ramalingam C <[email protected]>Signed-off-by Kahola, Mika <[email protected]>--- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 3 files changed, 10 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_display.c +4
-1@@ -12220,7 +12220,10 @@ static void skl_update_crtcs(struct drm_atomic_state *state)if (updated & cmask || !cstate->base.active)continue ; -if (skl_ddb_allocation_overlaps (entries, &cstate->wm.skl.ddb, i)) +if (skl_ddb_allocation_overlaps (dev_priv, + entries, + &cstate->wm.skl.ddb, + i))continue ; updated |= cmask;drivers/gpu/drm/i915/intel_drv.h +2
-1@@ -1891,7 +1891,8 @@ int intel_enable_sagv(struct drm_i915_private *dev_priv);int intel_disable_sagv (struct drm_i915_private *dev_priv);bool skl_wm_level_equals (const struct skl_wm_level *l1,const struct skl_wm_level *l2); -bool skl_ddb_allocation_overlaps (const struct skl_ddb_entry **entries, +bool skl_ddb_allocation_overlaps (struct drm_i915_private *dev_priv, +const struct skl_ddb_entry **entries,const struct skl_ddb_entry *ddb,int ignore);bool ilk_disable_lp_wm (struct drm_device *dev);drivers/gpu/drm/i915/intel_pm.c +0
-0
drivers/gpu/drm/i915/intel_pm.c static inline bool skl_ddb_entries_overlap(const struct skl_ddb_entry *a, · line 4829
Quoted 10 lines
drivers/gpu/drm/i915/intel_pm.c +2
-1@@ -4821,16 +4821,18 @@ static inline bool skl_ddb_entries_overlap(const struct skl_ddb_entry *a,return a->start < b->end && b->start < a->end; } -bool skl_ddb_allocation_overlaps (const struct skl_ddb_entry **entries, +bool skl_ddb_allocation_overlaps (struct drm_i915_private *dev_priv, +const struct skl_ddb_entry **entries,const struct skl_ddb_entry *ddb,int ignore) {int i;
I would change this to 'enum pipe pipe' for a bit of extra clarity.
Quoted 17 lines
drivers/gpu/drm/i915/intel_pm.c +2
-1-for (i =0 ; i <I915_MAX_PIPES ; i++) +for_each_pipe (dev_priv, i) {if (i != ignore && entries[i] &&skl_ddb_entries_overlap (ddb, entries[i]))return true; + }return false; }Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/5 drm/i915: Fold IRQ pipe masks
In reply to Mika KaholaFold IRQ pipe masks into one loop instead of hardcoding per pipe.
--- drivers/gpu/drm/i915/i915_irq.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +3 -4
@@ -3454,16 +3454,15 @@ static void gen8_de_irq_postinstall(struct drm_i915_private *dev_priv)else if (IS_BROADWELL (dev_priv)) de_port_enables |=GEN8_PORT_DP_A_HOTPLUG ; - dev_priv->de_irq_mask[PIPE_A ] = ~de_pipe_masked; - dev_priv->de_irq_mask[PIPE_B ] = ~de_pipe_masked; - dev_priv->de_irq_mask[PIPE_C ] = ~de_pipe_masked; +for_each_pipe (dev_priv, pipe) { + dev_priv->de_irq_mask[pipe] = ~de_pipe_masked; -for_each_pipe (dev_priv, pipe)if (intel_display_power_is_enabled (dev_priv,POWER_DOMAIN_PIPE (pipe)))GEN8_IRQ_INIT_NDX (DE_PIPE , pipe, dev_priv->de_irq_mask[pipe], de_pipe_enables); + }GEN5_IRQ_INIT (GEN8_DE_PORT_ , ~de_port_masked, de_port_enables);GEN5_IRQ_INIT (GEN8_DE_MISC_ , ~de_misc_masked, de_misc_masked);
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915: Favor for_each_pipe() macro
In reply to Mika KaholaFavor for_each_pipe() macro when looping through pipes.
--- drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pipe_crc.c +1 -1
@@ -208,7 +208,7 @@ static int display_crc_ctl_show(struct seq_file *m, void *data)struct drm_i915_private *dev_priv = m->private;int i; -for (i =0 ; i <I915_MAX_PIPES ; i++) +for_each_pipe (dev_priv, i)seq_printf (m,"%c %s\n" ,pipe_name (i),pipe_crc_source_name (dev_priv->pipe_crc[i].source));
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 4/5] drm/i915: Favor for_each_pipe() macro
Quoted 12 lines · Mika Kahola
Favor
for_each_pipe()macro when looping through pipes.Signed-off-by Mika Kahola <[email protected]>--- drivers/gpu/drm/i915/intel_pipe_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/intel_pipe_crc.c +0
-0
drivers/gpu/drm/i915/intel_pipe_crc.c static int display_crc_ctl_show(struct seq_file *m, void *data) · line 209
Quoted 2 lines
drivers/gpu/drm/i915/intel_pipe_crc.c +0
-0@@ -208,7 +208,7 @@ static int display_crc_ctl_show(struct seq_file *m, void *data)struct drm_i915_private *dev_priv = m->private;int i;
Could also do the 'enum pipe pipe' change here. Looks like it shouldn't cause too much noise in the patch.
Quoted 13 lines
drivers/gpu/drm/i915/intel_pipe_crc.c +1
-1-for (i =0 ; i <I915_MAX_PIPES ; i++) +for_each_pipe (dev_priv, i)seq_printf (m,"%c %s\n" ,pipe_name (i),pipe_crc_source_name (dev_priv->pipe_crc[i].source));Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/5 drm/i915: Cleanup South Error Interrupts
In reply to Mika KaholaCleanup and parametrize the handling of South Error Interrupts (SERR_INT).
--- drivers/gpu/drm/i915/i915_irq.c | 12 ++++-------- drivers/gpu/drm/i915/i915_reg.h | 3 --- 2 files changed, 4 insertions(+), 11 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +4 -8
@@ -2103,18 +2103,14 @@ static void ivb_err_int_handler(struct drm_i915_private *dev_priv)static void cpt_serr_int_handler (struct drm_i915_private *dev_priv) {u32 serr_int =I915_READ (SERR_INT ); +enum pipe pipe;if (serr_int &SERR_INT_POISON )DRM_ERROR ("PCH poison interrupt\n" ); -if (serr_int &SERR_INT_TRANS_A_FIFO_UNDERRUN ) -intel_pch_fifo_underrun_irq_handler (dev_priv,PIPE_A ); - -if (serr_int &SERR_INT_TRANS_B_FIFO_UNDERRUN ) -intel_pch_fifo_underrun_irq_handler (dev_priv,PIPE_B ); - -if (serr_int &SERR_INT_TRANS_C_FIFO_UNDERRUN ) -intel_pch_fifo_underrun_irq_handler (dev_priv,PIPE_C ); +for_each_pipe (dev_priv, pipe) +if (serr_int &SERR_INT_TRANS_FIFO_UNDERRUN (pipe)) +intel_pch_fifo_underrun_irq_handler (dev_priv, pipe);I915_WRITE (SERR_INT , serr_int); }
drivers/gpu/drm/i915/i915_reg.h +0 -3
@@ -7155,9 +7155,6 @@ enum {#define SERR_INT _MMIO(0xc4040)#define SERR_INT_POISON (1<<31) -#define SERR_INT_TRANS_C_FIFO_UNDERRUN (1<<6) -#define SERR_INT_TRANS_B_FIFO_UNDERRUN (1<<3) -#define SERR_INT_TRANS_A_FIFO_UNDERRUN (1<<0)#define SERR_INT_TRANS_FIFO_UNDERRUN (pipe) (1<<((pipe)*3))/* digital port hotplug */
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : success
== Summary ==
Series 30336v1 drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
https://patchwork.freedesktop.org/api/1.0/series/30336/revisions/1/mbox/
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> SKIP (fi-skl-x1585l) fdo#101781
Test kms_frontbuffer_tracking:
Subgroup basic:
dmesg-warn -> PASS (fi-bdw-5557u) fdo#102473
Test pm_rpm:
Subgroup basic-rte:
pass -> DMESG-WARN (fi-cfl-s) fdo#102294fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#102473 https://bugs.freedesktop.org/show_bug.cgi?id=102473
fdo#102294 https://bugs.freedesktop.org/show_bug.cgi?id=102294
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:456s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:452s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:375s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:530s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:268s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:509s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:502s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:497s fi-cfl-s total:289 pass:222 dwarn:35 dfail:0 fail:0 skip:32 time:560s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:455s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:596s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:432s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:410s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:441s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:491s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:463s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:496s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:572s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:586s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:552s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:459s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:520s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:500s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:460s fi-skl-x1585l total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:475s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:572s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:1 skip:39 time:426s
fd4b78812edddb5118f97329ba04f36483e16e2a drm-tip: 2017y-09m-13d-17h-15m-44s UTC integration manifest 671bf4b3994f drm/i915: Cleanup South Error Interrupts2e3314469ab9 drm/i915: Favor for_each_pipe() macro12cd8b1cdecb drm/i915: Fold IRQ pipe masksdd880f65ff15 drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation 03692826dfb0 drm/i915: Don't relay on I915_MAX_PIPES
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5692/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : warning
== Summary ==
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-crc-legacy:
pass -> SKIP (shard-hsw)
Subgroup cursor-vs-flip-atomic:
pass -> SKIP (shard-hsw)
Test kms_cursor_crc:
Subgroup cursor-128x128-random:
pass -> SKIP (shard-hsw)
Test kms_draw_crc:
Subgroup draw-method-rgb565-mmap-cpu-xtiled:
pass -> SKIP (shard-hsw)
Test kms_flip:
Subgroup wf_vblank-vs-dpms:
dmesg-warn -> PASS (shard-hsw) fdo#102614
Test gem_flink_race:
Subgroup flink_close:
fail -> PASS (shard-hsw) fdo#102655
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test gem_eio:
Subgroup in-flight:
fail -> PASS (shard-hsw) fdo#102616fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102616 https://bugs.freedesktop.org/show_bug.cgi?id=102616
shard-hsw total:2313 pass:1242 dwarn:0 dfail:0 fail:12 skip:1059 time:9338s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5692/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerRe: ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
Quoted 9 lines · Patchwork
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for
I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : warning== Summary ==
Test
kms_cursor_legacy:
Quoted 10 lines
Subgroup flip-vs-cursor-crc-legacy:
pass -> SKIP (shard-hsw)
Subgroup cursor-vs-flip-atomic:
pass -> SKIP (shard-hsw)
Test kms_cursor_crc:
Subgroup cursor-128x128-random:
pass -> SKIP (shard-hsw)
Test kms_draw_crc:
Subgroup draw-method-rgb565-mmap-cpu-xtiled:
pass -> SKIP (shard-hsw)I liked the clean-up on this series very much. And all patches looks good to me.
Only concern I have are this tests here skiping with
"Test requirement: !(n >= display.n_pipes)"
So, could you please double check and see if this is caused by any change in here?
Thanks,
Rodrigo.
Quoted 20 lines
Test
kms_flip:Subgroup wf_vblank-vs-dpms: dmesg-warn -> PASS (shard-hsw) fdo#102614 Test gem_flink_race: Subgroup flink_close: fail -> PASS (shard-hsw) fdo#102655 Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#102252 Test gem_eio: Subgroup in-flight: fail -> PASS (shard-hsw) fdo#102616fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102616 https://bugs.freedesktop.org/show_bug.cgi?id=102616shard-hsw total:2313 pass:1242 dwarn:0 dfail:0 fail:12 skip:1059 time:9338s
Quoted 7 lines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5692/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
Quoted 22 lines · Rodrigo Vivi
Quoted 10 lines · Patchwork
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for
I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : warning== Summary ==
Quoted 11 lines
Test
kms_cursor_legacy:
Subgroup flip-vs-cursor-crc-legacy:
pass -> SKIP (shard-hsw) Subgroup cursor-vs-flip-atomic:
pass -> SKIP (shard-hsw) Testkms_cursor_crc:
Subgroup cursor-128x128-random:
pass -> SKIP (shard-hsw) Testkms_draw_crc:
Subgroup draw-method-rgb565-mmap-cpu-xtiled:
pass -> SKIP (shard-hsw)
Quoted 8 lines
I liked the clean-up on this series very much. And all patches looks good to me.
Only concern I have are this tests here skiping with"Test requirement: !(n >= display.n_pipes)"
So, could you please double check and see if this is caused by any change in here?
The SKIP's are all on HSW. I'll rerun the tests just for comparison and to check if these tests systematically skip.
Quoted 34 lines
Thanks,
Rodrigo.Quoted 30 lines
Test
kms_flip:
Subgroup wf_vblank-vs-dpms:
dmesg-warn -> PASS (shard-hsw) fdo#102614 Testgem_flink_race:
Subgroupflink_close:
fail -> PASS (shard-hsw) fdo#102655 Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252 Testgem_eio:
Subgroup in-flight:
fail -> PASS (shard-hsw) fdo#102616fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102616 https://bugs.freedesktop.org/show_bug.cgi?id=102616shard-hsw total:2313 pass:1242
dwarn:0 dfail:0 fail:12 skip:1059 time:9338s== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc
hwork_5692/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.IGT: warning for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Rodrigo ViviQuoted 22 lines · Rodrigo Vivi
Quoted 10 lines · Patchwork
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for
I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : warning== Summary ==
Quoted 11 lines
Test
kms_cursor_legacy:
Subgroup flip-vs-cursor-crc-legacy:
pass -> SKIP (shard-hsw) Subgroup cursor-vs-flip-atomic:
pass -> SKIP (shard-hsw) Testkms_cursor_crc:
Subgroup cursor-128x128-random:
pass -> SKIP (shard-hsw) Testkms_draw_crc:
Subgroup draw-method-rgb565-mmap-cpu-xtiled:
pass -> SKIP (shard-hsw)
Quoted 8 lines
I liked the clean-up on this series very much. And all patches looks good to me.
Only concern I have are this tests here skiping with"Test requirement: !(n >= display.n_pipes)"
So, could you please double check and see if this is caused by any change in here?
I ran the CI tests for three times and every time I received different results. I didn't see these skips on those runs.
Quoted 34 lines
Thanks,
Rodrigo.Quoted 30 lines
Test
kms_flip:
Subgroup wf_vblank-vs-dpms:
dmesg-warn -> PASS (shard-hsw) fdo#102614 Testgem_flink_race:
Subgroupflink_close:
fail -> PASS (shard-hsw) fdo#102655 Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252 Testgem_eio:
Subgroup in-flight:
fail -> PASS (shard-hsw) fdo#102616fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102616 https://bugs.freedesktop.org/show_bug.cgi?id=102616shard-hsw total:2313 pass:1242
dwarn:0 dfail:0 fail:12 skip:1059 time:9338s== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patc
hwork_5692/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : failure
== Summary ==
Series 30336v1 drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
https://patchwork.freedesktop.org/api/1.0/series/30336/revisions/1/mbox/
Test chamelium:
Subgroup dp-edid-read:
pass -> FAIL (fi-kbl-7500u) fdo#102672
Test gem_exec_reloc:
Subgroup basic-cpu-read:
dmesg-warn -> PASS (fi-kbl-7500u)
Subgroup basic-gtt-read:
dmesg-warn -> PASS (fi-kbl-7500u)
Test gem_exec_store:
Subgroup basic-all:
dmesg-warn -> PASS (fi-kbl-7500u)
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-kbl-7500u)
Test kms_busy:
Subgroup basic-flip-c:
pass -> INCOMPLETE (fi-bxt-j4205)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
Test pm_rpm:
Subgroup basic-rte:
dmesg-warn -> PASS (fi-cfl-s) fdo#102294fdo#102672 https://bugs.freedesktop.org/show_bug.cgi?id=102672
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102294 https://bugs.freedesktop.org/show_bug.cgi?id=102294
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:446s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:469s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:422s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:521s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:277s fi-bxt-j4205 total:208 pass:186 dwarn:0 dfail:0 fail:0 skip:21 fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:492s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:489s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:542s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:419s fi-glk-2a total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:599s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:428s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:408s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:429s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:494s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:470s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:478s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:586s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:592s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:542s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:450s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:749s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:490s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:474s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:564s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:415s
0bbe2f0d6a1e69d0ee72ea0c1dcdd93269419024 drm-tip: 2017y-09m-18d-13h-52m-45s UTC integration manifest 00a0126699df drm/i915: Cleanup South Error Interrupts36d4ab76683c drm/i915: Favor for_each_pipe() macroeeb5874d6d9b drm/i915: Fold IRQ pipe masksed210993826c drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation b25327e73cdf drm/i915: Don't relay on I915_MAX_PIPES
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5733/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : failure
== Summary ==
Series 30336v1 drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
https://patchwork.freedesktop.org/api/1.0/series/30336/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test kms_addfb_basic:
Subgroup clobberred-modifier:
pass -> DMESG-WARN (fi-kbl-7500u)
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
fail -> PASS (fi-snb-2600) fdo#100215 +1
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (fi-kbl-7500u)
Test pm_rpm:
Subgroup basic-rte:
dmesg-warn -> PASS (fi-cfl-s) fdo#102294
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-WARN (fi-glk-1) fdo#102777 +1fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102294 https://bugs.freedesktop.org/show_bug.cgi?id=102294
fdo#102777 https://bugs.freedesktop.org/show_bug.cgi?id=102777
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:448s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:471s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:420s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:530s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:276s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:507s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:506s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:498s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:541s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:419s fi-glk-1 total:289 pass:259 dwarn:1 dfail:0 fail:0 skip:29 time:576s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:440s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:413s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:433s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:503s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:467s fi-kbl-7500u total:245 pass:221 dwarn:2 dfail:0 fail:1 skip:20 fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:583s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:596s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:544s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:458s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:759s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:499s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:477s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:571s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:422s
5061f6a05b703b00a832db3e53fe7a2deb15e408 drm-tip: 2017y-09m-19d-12h-08m-07s UTC integration manifest 982bf87f0f66 drm/i915: Cleanup South Error Interruptsd576b7b0ff7a drm/i915: Favor for_each_pipe() macro0a6ce9b6e029 drm/i915: Fold IRQ pipe masks2f8f3d0d3c7e drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation ae017e055d11 drm/i915: Don't relay on I915_MAX_PIPES
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5745/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : success
== Summary ==
Series 30336v1 drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
https://patchwork.freedesktop.org/api/1.0/series/30336/revisions/1/mbox/
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-WARN (fi-glk-1) fdo#102777 +2fdo#102777 https://bugs.freedesktop.org/show_bug.cgi?id=102777
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:437s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:475s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:419s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:522s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:277s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:507s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:492s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:537s fi-cnl-y total:289 pass:258 dwarn:0 dfail:0 fail:4 skip:27 time:646s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:419s fi-glk-1 total:289 pass:259 dwarn:1 dfail:0 fail:0 skip:29 time:564s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:423s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:405s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:433s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:495s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:469s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:474s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:582s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:586s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:539s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:453s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:750s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:487s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:483s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:563s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:410s
da14aaa14e584a49e94bffd3c7af6e659745bae6 drm-tip: 2017y-09m-27d-09h-50m-55s UTC integration manifest 2cf0bf3e5bfa drm/i915: Cleanup South Error Interrupts47f107830c0a drm/i915: Favor for_each_pipe() macro0ee80e3e3b54 drm/i915: Fold IRQ pipe masksf9ab202e8fde drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation 31c00b0bb91c drm/i915: Don't relay on I915_MAX_PIPES
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5830/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : success
== Summary ==
Series 30336v1 drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
https://patchwork.freedesktop.org/api/1.0/series/30336/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-FAIL (fi-kbl-7560u) fdo#103039
Subgroup basic-s4-devices:
pass -> DMESG-FAIL (fi-kbl-7560u) fdo#102846 +1
Test gem_flink_basic:
Subgroup bad-flink:
pass -> DMESG-WARN (fi-kbl-7560u) fdo#103049 +4
Test drv_module_reload:
Subgroup basic-reload:
pass -> DMESG-WARN (fi-cfl-s) k.org#196765 +1fdo#103039 https://bugs.freedesktop.org/show_bug.cgi?id=103039
fdo#102846 https://bugs.freedesktop.org/show_bug.cgi?id=102846
fdo#103049 https://bugs.freedesktop.org/show_bug.cgi?id=103049
k.org#196765 https://bugzilla.kernel.org/show_bug.cgi?id=196765
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:457s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:394s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:563s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:289s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:527s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:533s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:549s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:524s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:561s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:628s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:440s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:599s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:444s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:420s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:469s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:506s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:477s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:508s fi-kbl-7560u total:125 pass:105 dwarn:5 dfail:2 fail:0 skip:12 fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:491s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:604s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:666s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:477s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:658s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:531s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:518s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:471s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:586s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:432s
247cb84af034b8e90ecd22cd69adb13a7a305350 drm-tip: 2017y-10m-05d-06h-44m-09s UTC integration manifest 8cfe68398c52 drm/i915: Cleanup South Error Interrupts0d33f4b14e6e drm/i915: Favor for_each_pipe() macro2186fb8c0912 drm/i915: Fold IRQ pipe masks9a30dd749459 drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation c77afd8ee903 drm/i915: Don't relay on I915_MAX_PIPES
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5906/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
In reply to Mika Kahola== Series Details ==
== Series Details ==
Series: drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
URL : https://patchwork.freedesktop.org/series/30336/
State : success
== Summary ==
Series 30336v1 drm/i915: Miscellaneous fixes to reduce dependency for I915_MAX_PIPES
https://patchwork.freedesktop.org/api/1.0/series/30336/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-kbl-r)
Test pm_rpm:
Subgroup basic-pci-d3-state:
dmesg-warn -> PASS (fi-cfl-s)
Test drv_module_reload:
Subgroup basic-no-display:
pass -> DMESG-WARN (fi-cfl-s) fdo#103022 +1fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#103022 https://bugs.freedesktop.org/show_bug.cgi?id=103022
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:460s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:468s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:391s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:563s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:285s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:519s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:523s fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:542s fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:521s fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:562s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:616s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:434s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:599s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:437s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:417s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:458s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:505s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:475s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:493s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:582s fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:486s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:589s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:657s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:468s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:651s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:536s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:508s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:469s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:578s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:432s
6a08510077ad5bdbac044038138f217e413cdca2 drm-tip: 2017y-10m-10d-07h-48m-31s UTC integration manifest 22c124d1c731 drm/i915: Cleanup South Error Interrupts0faa4f41fa42 drm/i915: Favor for_each_pipe() macroccd126a01524 drm/i915: Fold IRQ pipe masksbf0c5021a39d drm/i915: Remove I915_MAX_PIPES dependency for DDB allocation ea13eae4f2c9 drm/i915: Don't relay on I915_MAX_PIPES
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5963/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Mika Kahola
This patch series introduces fixes to reduce dependency for
I915_MAX_PIPESand minor optimizations to reduce hardcoding.Kahola, Mika (1):
drm/i915: RemoveI915_MAX_PIPESdependency for DDB allocationMika Kahola (4):
drm/i915: Don't relay onI915_MAX_PIPES
drm/i915: Fold IRQ pipe masks
drm/i915: Favorfor_each_pipe()macro
drm/i915: Cleanup South Error Interrupts
I replied with a few minor nits to the individual patches. Ttoally up to you whether you want to do those changes or not.
For the series
Quoted 17 lines
drivers/gpu/drm/i915/i915_irq.c | 19 +++++++------------ drivers/gpu/drm/i915/i915_reg.h | 3 --- drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pipe_crc.c | 9 +++++---- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 7 files changed, 23 insertions(+), 24 deletions(-)Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Ville Syrjälä
Quoted 4 lines · Mika Kahola
This patch series introduces fixes to reduce dependency for
I915_MAX_PIPESand minor optimizations to reduce hardcoding.Quoted 8 lines
Kahola, Mika (1):
drm/i915: RemoveI915_MAX_PIPESdependency for DDB allocationMika Kahola (4):
drm/i915: Don't relay onI915_MAX_PIPES
drm/i915: Fold IRQ pipe masks
drm/i915: Favorfor_each_pipe()macro
drm/i915: Cleanup South Error Interrupts
Quoted 6 lines
I replied with a few minor nits to the individual patches. Ttoally up to
you whether you want to do those changes or not.For the series
Reviewed-by Ville Syrjälä <[email protected]>
Thanks Ville for review. I will change it 'enum pipe pipe'. It's cleaner that way.
Quoted 19 lines
Quoted 19 lines
drivers/gpu/drm/i915/i915_irq.c | 19 +++++++------------ drivers/gpu/drm/i915/i915_reg.h | 3 --- drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++-
drivers/gpu/drm/i915/intel_pipe_crc.c| 9 +++++---- drivers/gpu/drm/i915/intel_pm.c | 6 ++++--7 files changed, 23 insertions(+), 24 deletions(-)--
2.7.4_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · PDT Mika Kahola
This patch series introduces fixes to reduce dependency for
I915_MAX_PIPESand minor optimizations to reduce hardcoding.Kahola, Mika (1):
drm/i915: RemoveI915_MAX_PIPESdependency for DDB allocationMika Kahola (4):
Looks like you've got two email addresses going on here.
Quoted 5 lines
drm/i915: Don't relay on
I915_MAX_PIPES
drm/i915: Fold IRQ pipe masks
drm/i915: Favorfor_each_pipe()macro
drm/i915: Cleanup South Error Interrupts
Quoted 8 lines
drivers/gpu/drm/i915/i915_irq.c | 19 +++++++------------ drivers/gpu/drm/i915/i915_reg.h | 3 --- drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++- drivers/gpu/drm/i915/intel_pipe_crc.c | 9 +++++---- drivers/gpu/drm/i915/intel_pm.c | 6 ++++-- 7 files changed, 23 insertions(+), 24 deletions(-)
Series is:
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Kenneth Graunke
Quoted 8 lines · PDT Mika Kahola
This patch series introduces fixes to reduce dependency for
I915_MAX_PIPESand minor optimizations to reduce hardcoding.Kahola, Mika (1):
drm/i915: RemoveI915_MAX_PIPESdependency for DDB allocationMika Kahola (4):
Looks like you've got two email addresses going on here.
True. That's a legacy I will fix.
Thanks for the review!
Quoted 17 lines
Quoted 7 lines
drm/i915: Don't relay on
I915_MAX_PIPES
drm/i915: Fold IRQ pipe masks
drm/i915: Favorfor_each_pipe()macro
drm/i915: Cleanup South Error InterruptsQuoted 8 lines
drivers/gpu/drm/i915/i915_irq.c | 19 +++++++------------ drivers/gpu/drm/i915/i915_reg.h | 3 --- drivers/gpu/drm/i915/intel_audio.c | 2 +- drivers/gpu/drm/i915/intel_display.c | 5 ++++- drivers/gpu/drm/i915/intel_drv.h | 3 ++-
drivers/gpu/drm/i915/intel_pipe_crc.c| 9 +++++---- drivers/gpu/drm/i915/intel_pm.c | 6 ++++--7 files changed, 23 insertions(+), 24 deletions(-)Series is:
Reviewed-by Kenneth Graunke <[email protected]>
Signature · 6 lines
Mika Kahola - Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx