drm/dp: Add defines for latency in sink
Subsystems (3)
PATCH 1/2 drm/dp: Add defines for latency in sink
Add defines for dpcd register 2009 (synchronization latency in sink).
--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)
include/drm/drm_dp_helper.h +3 -0
@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf +#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 drm/i915/psr: Set frames before SU entry for psr2
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3.
--- drivers/gpu/drm/i915/intel_psr.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_psr.c +10 -2
@@ -327,6 +327,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)*/ uint32_t idle_frames =max (6 , dev_priv->vbt.psr.idle_frames);uint32_t val; +uint8_t sink_latency; val = idle_frames <<EDP_PSR_IDLE_FRAME_SHIFT ;
@@ -334,8 +335,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)* mesh at all with our frontbuffer tracking. And the hw alone isn't * good enough. */ val |=EDP_PSR2_ENABLE | -EDP_SU_TRACK_ENABLE | -EDP_FRAMES_BEFORE_SU_ENTRY ; +EDP_SU_TRACK_ENABLE ; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_SINK_SYNCHRONIZATION_LATENCY , + &sink_latency)) { + sink_latency = sink_latency &DP_MAX_RESYNC_FRAME_CNT_MASK ; + val |= (sink_latency +1 ) <<EDP_PSR2_FRAME_BEFORE_SU_SHIFT ; + }else { + val |=EDP_FRAMES_BEFORE_SU_ENTRY ; + }if (dev_priv->vbt.psr.tp2_tp3_wakeup_time >5 ) val |=EDP_PSR2_TP2_TIME_2500 ;
Signature · 6 lines
1.9.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH 2/2] drm/i915/psr: Set frames before SU entry for psr2
Quoted 23 lines · vathsala nagaraju
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3.
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>--- drivers/gpu/drm/i915/intel_psr.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_psr.c +1
-0@@ -327,6 +327,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)*/ uint32_t idle_frames =max (6 , dev_priv->vbt.psr.idle_frames);uint32_t val; +uint8_t sink_latency; val = idle_frames <<EDP_PSR_IDLE_FRAME_SHIFT ;
drivers/gpu/drm/i915/intel_psr.c static void hsw_activate_psr2(struct intel_dp *intel_dp) · line 341
Quoted 9 lines
drivers/gpu/drm/i915/intel_psr.c +4
-2@@ -334,8 +335,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)* mesh at all with our frontbuffer tracking. And the hw alone isn't * good enough. */ val |=EDP_PSR2_ENABLE | -EDP_SU_TRACK_ENABLE | -EDP_FRAMES_BEFORE_SU_ENTRY ; +EDP_SU_TRACK_ENABLE ; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_SINK_SYNCHRONIZATION_LATENCY , + &sink_latency)) {
== 1
Quoted 15 lines
drivers/gpu/drm/i915/intel_psr.c +5
-0+ sink_latency = sink_latency &DP_MAX_RESYNC_FRAME_CNT_MASK ; + val |= (sink_latency +1 ) <<EDP_PSR2_FRAME_BEFORE_SU_SHIFT ; + }else { + val |=EDP_FRAMES_BEFORE_SU_ENTRY ; + }if (dev_priv->vbt.psr.tp2_tp3_wakeup_time >5 ) val |=EDP_PSR2_TP2_TIME_2500 ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Vivi, Rodrigo
maintainerRe: [PATCH 2/2] drm/i915/psr: Set frames before SU entry for psr2
In reply to vathsala nagarajuQuoted 27 lines · Vathsala
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3.
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>---
drivers/gpu/drm/i915/intel_psr.c| 12 ++++++++++--1 file changed, 10 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_psr.c +1
-0@@ -327,6 +327,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)*/ uint32_t idle_frames =max (6 , dev_priv->vbt.psr.idle_frames);uint32_t val; +uint8_t sink_latency; val = idle_frames <<EDP_PSR_IDLE_FRAME_SHIFT ;
drivers/gpu/drm/i915/intel_psr.c static void hsw_activate_psr2(struct intel_dp *intel_dp) · line 338
Quoted 5 lines
drivers/gpu/drm/i915/intel_psr.c +0
-2@@ -334,8 +335,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)* mesh at all with our frontbuffer tracking. And the hw alone isn't * good enough. */ val |= EDP_PSR2_ENABLE | -EDP_SU_TRACK_ENABLE | -EDP_FRAMES_BEFORE_SU_ENTRY ;
Please also remove the definition of this su_entry since it was not following the new standards anyway... Probably good to replace with function macro style for better use below...
drivers/gpu/drm/i915/intel_psr.c static void hsw_activate_psr2(struct intel_dp *intel_dp) · line 343
Quoted 6 lines
drivers/gpu/drm/i915/intel_psr.c +6
-0+EDP_SU_TRACK_ENABLE ; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_SINK_SYNCHRONIZATION_LATENCY , + &sink_latency)) { + sink_latency = sink_latency &DP_MAX_RESYNC_FRAME_CNT_MASK ; + val |= (sink_latency +1 ) <<EDP_PSR2_FRAME_BEFORE_SU_SHIFT ;
... so you could use
val |= EDP_PSR2_FRAME_BEFORE_SU(sink_latency +1);
Quoted 9 lines
drivers/gpu/drm/i915/intel_psr.c +3
-0+ }else { + val |=EDP_FRAMES_BEFORE_SU_ENTRY ; + }if (dev_priv->vbt.psr.tp2_tp3_wakeup_time >5 ) val |=EDP_PSR2_TP2_TIME_2500 ;Signature · 1 line
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH 2/2 drm/i915/psr: Set frames before SU entry for psr2
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3.
v2 :
- add macro EDP_PSR2_FRAME_BEFORE_SU (Rodrigo)
- remove EDP_FRAMES_BEFORE_SU_ENTRY (Rodrigo)
- add check ==1 for dpcd_read call (ville)
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_psr.c | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -170,6 +170,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) (mask) << 16 | (value); })#define _MASKED_BIT_ENABLE (a) ({ typeof(a) _a = (a); _MASKED_FIELD(_a, _a); })#define _MASKED_BIT_DISABLE (a) (_MASKED_FIELD((a), 0)) +#define EDP_PSR2_FRAME_BEFORE_SU (a) ((a) << EDP_PSR2_FRAME_BEFORE_SU_SHIFT)/* Engine ID */
@@ -4047,7 +4048,6 @@ enum {#define EDP_PSR2_FRAME_BEFORE_SU_SHIFT 4#define EDP_PSR2_FRAME_BEFORE_SU_MASK (0xf<<4)#define EDP_PSR2_IDLE_MASK 0xf -#define EDP_FRAMES_BEFORE_SU_ENTRY (1<<4)#define EDP_PSR2_STATUS_CTL _MMIO(0x6f940)#define EDP_PSR2_STATUS_STATE_MASK (0xf<<28)
drivers/gpu/drm/i915/intel_psr.c +10 -2
@@ -327,6 +327,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)*/ uint32_t idle_frames =max (6 , dev_priv->vbt.psr.idle_frames);uint32_t val; +uint8_t sink_latency; val = idle_frames <<EDP_PSR_IDLE_FRAME_SHIFT ;
@@ -334,8 +335,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)* mesh at all with our frontbuffer tracking. And the hw alone isn't * good enough. */ val |=EDP_PSR2_ENABLE | -EDP_SU_TRACK_ENABLE | -EDP_FRAMES_BEFORE_SU_ENTRY ; +EDP_SU_TRACK_ENABLE ; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_SINK_SYNCHRONIZATION_LATENCY , + &sink_latency) ==1 ) { + sink_latency = sink_latency &DP_MAX_RESYNC_FRAME_CNT_MASK ; + }else { + sink_latency =0 ; + } + val |=EDP_PSR2_FRAME_BEFORE_SU (sink_latency +1 );if (dev_priv->vbt.psr.tp2_tp3_wakeup_time >5 ) val |=EDP_PSR2_TP2_TIME_2500 ;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915/psr: Set frames before SU entry for psr2
Quoted 21 lines · vathsala nagaraju
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3.
v2 :
- add macroEDP_PSR2_FRAME_BEFORE_SU(Rodrigo)
- removeEDP_FRAMES_BEFORE_SU_ENTRY(Rodrigo)
- add check ==1 fordpcd_readcall (ville)Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_psr.c | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_reg.h +0
-0
drivers/gpu/drm/i915/i915_reg.h static inline bool i915_mmio_reg_valid(i915_reg_t reg) · line 173
Quoted 4 lines
drivers/gpu/drm/i915/i915_reg.h +1
-0@@ -170,6 +170,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) (mask) << 16 | (value); })#define _MASKED_BIT_ENABLE (a) ({ typeof(a) _a = (a); _MASKED_FIELD(_a, _a); })#define _MASKED_BIT_DISABLE (a) (_MASKED_FIELD((a), 0)) +#define EDP_PSR2_FRAME_BEFORE_SU (a) ((a) << EDP_PSR2_FRAME_BEFORE_SU_SHIFT)
not here
drivers/gpu/drm/i915/i915_reg.h enum { · line 4050
Quoted 8 lines
drivers/gpu/drm/i915/i915_reg.h +0
-1/* Engine ID */ @@ -4047,7 +4048,6 @@ enum {#define EDP_PSR2_FRAME_BEFORE_SU_SHIFT 4#define EDP_PSR2_FRAME_BEFORE_SU_MASK (0xf<<4)#define EDP_PSR2_IDLE_MASK 0xf -#define EDP_FRAMES_BEFORE_SU_ENTRY (1<<4)
move here
Quoted 16 lines
drivers/gpu/drm/i915/i915_reg.h +0
-0#define EDP_PSR2_STATUS_CTL _MMIO(0x6f940)#define EDP_PSR2_STATUS_STATE_MASK (0xf<<28)drivers/gpu/drm/i915/intel_psr.c +1
-0@@ -327,6 +327,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)*/ uint32_t idle_frames =max (6 , dev_priv->vbt.psr.idle_frames);uint32_t val; +uint8_t sink_latency; val = idle_frames <<EDP_PSR_IDLE_FRAME_SHIFT ;
drivers/gpu/drm/i915/intel_psr.c static void hsw_activate_psr2(struct intel_dp *intel_dp) · line 342
Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +5
-2@@ -334,8 +335,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)* mesh at all with our frontbuffer tracking. And the hw alone isn't * good enough. */ val |=EDP_PSR2_ENABLE | -EDP_SU_TRACK_ENABLE | -EDP_FRAMES_BEFORE_SU_ENTRY ; +EDP_SU_TRACK_ENABLE ; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_SINK_SYNCHRONIZATION_LATENCY , + &sink_latency) ==1 ) { + sink_latency = sink_latency &DP_MAX_RESYNC_FRAME_CNT_MASK ;
sink_latency &= DP_MAX_RESYNC_FRAME_CNT_MASK;
with those changes
Quoted 10 lines
drivers/gpu/drm/i915/intel_psr.c +4
-0+ }else { + sink_latency =0 ; + } + val |=EDP_PSR2_FRAME_BEFORE_SU (sink_latency +1 );if (dev_priv->vbt.psr.tp2_tp3_wakeup_time >5 ) val |=EDP_PSR2_TP2_TIME_2500 ;Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerRe: [PATCH 2/2] drm/i915/psr: Set frames before SU entry for psr2
In reply to vathsala nagarajuQuoted 11 lines · vathsala nagaraju
Set frames before SU entry value for max resync frame count of dpcd register 2009, bit field 0:3.
v2 :
- add macroEDP_PSR2_FRAME_BEFORE_SU(Rodrigo)
- removeEDP_FRAMES_BEFORE_SU_ENTRY(Rodrigo)
- add check ==1 fordpcd_readcall (ville)Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>
Merged both patches to dinq. Thanks for the patches.
I'm anxiously waiting the PSR2 related workaroud(s)! ;)
Thanks,
Rodrigo.
Quoted 58 lines
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_psr.c | 12 ++++++++++-- 2 files changed, 11 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/i915_reg.h +1
-1@@ -170,6 +170,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg) (mask) << 16 | (value); })#define _MASKED_BIT_ENABLE (a) ({ typeof(a) _a = (a); _MASKED_FIELD(_a, _a); })#define _MASKED_BIT_DISABLE (a) (_MASKED_FIELD((a), 0)) +#define EDP_PSR2_FRAME_BEFORE_SU (a) ((a) << EDP_PSR2_FRAME_BEFORE_SU_SHIFT)/* Engine ID */ @@ -4047,7 +4048,6 @@ enum {#define EDP_PSR2_FRAME_BEFORE_SU_SHIFT 4#define EDP_PSR2_FRAME_BEFORE_SU_MASK (0xf<<4)#define EDP_PSR2_IDLE_MASK 0xf -#define EDP_FRAMES_BEFORE_SU_ENTRY (1<<4)#define EDP_PSR2_STATUS_CTL _MMIO(0x6f940)#define EDP_PSR2_STATUS_STATE_MASK (0xf<<28)drivers/gpu/drm/i915/intel_psr.c +10
-2@@ -327,6 +327,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)*/ uint32_t idle_frames =max (6 , dev_priv->vbt.psr.idle_frames);uint32_t val; +uint8_t sink_latency; val = idle_frames <<EDP_PSR_IDLE_FRAME_SHIFT ;@@ -334,8 +335,15 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)* mesh at all with our frontbuffer tracking. And the hw alone isn't * good enough. */ val |=EDP_PSR2_ENABLE | -EDP_SU_TRACK_ENABLE | -EDP_FRAMES_BEFORE_SU_ENTRY ; +EDP_SU_TRACK_ENABLE ; + +if (drm_dp_dpcd_readb (&intel_dp->aux,DP_SINK_SYNCHRONIZATION_LATENCY , + &sink_latency) ==1 ) { + sink_latency = sink_latency &DP_MAX_RESYNC_FRAME_CNT_MASK ; + }else { + sink_latency =0 ; + } + val |=EDP_PSR2_FRAME_BEFORE_SU (sink_latency +1 );if (dev_priv->vbt.psr.tp2_tp3_wakeup_time >5 ) val |=EDP_PSR2_TP2_TIME_2500 ;Signature · 1 line
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula
maintainerRe: [PATCH 2/2] drm/i915/psr: Set frames before SU entry for psr2
Quoted 1 line · Rodrigo Vivi
Merged both patches to dinq. Thanks for the patches.
While patch 1 was a simple addition of a few DP macros, we need to get ack from Dave or (preferrably non-Intel) drm-misc maintainers before queuing non-i915 patches through drm-intel.
Dave, Sean, ack after the fact...?
The patch is [1].
BR,
Jani.
[1] http://patchwork.freedesktop.org/patch/msgid/[email protected]
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: Add defines for latency in sink
In reply to vathsala nagaraju== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/dp: Add defines for latency in sink
URL : https://patchwork.freedesktop.org/series/30658/
State : success
== Summary ==
Series 30658v1 series starting with [1/2] drm/dp: Add defines for latency in sink
https://patchwork.freedesktop.org/api/1.0/series/30658/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-kbl-7500u) fdo#102850
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
Test kms_force_connector_basic:
Subgroup force-connector-state:
skip -> PASS (fi-ivb-3520m)
Subgroup force-edid:
skip -> PASS (fi-ivb-3520m)
Subgroup force-load-detect:
skip -> PASS (fi-ivb-3520m)
Subgroup prune-stale-modes:
skip -> PASS (fi-ivb-3520m)
Test pm_rpm:
Subgroup basic-rte:
dmesg-warn -> PASS (fi-cfl-s) fdo#102294fdo#102850 https://bugs.freedesktop.org/show_bug.cgi?id=102850
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102294 https://bugs.freedesktop.org/show_bug.cgi?id=102294
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:440s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:469s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:420s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:515s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:277s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:502s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:488s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:493s fi-cfl-s total:289 pass:223 dwarn:34 dfail:0 fail:0 skip:32 time:548s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:425s fi-glk-1 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:568s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:423s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:405s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:434s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:484s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:467s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:475s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:568s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:590s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:540s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:441s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:749s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:491s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:470s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:567s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:411s
ed7a99bf23cea2276e77ba26d219e58e069d1e32 drm-tip: 2017y-09m-20d-11h-03m-37s UTC integration manifest 8dc01494eee9 drm/i915/psr: Set frames before SU entry for psr2568cf132cf88 drm/dp: Add defines for latency in sink
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5765/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for series starting with [1/2] drm/dp: Add defines for latency in sink
In reply to vathsala nagaraju== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/dp: Add defines for latency in sink
URL : https://patchwork.freedesktop.org/series/30658/
State : warning
== Summary ==
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252 +1
Test kms_plane:
Subgroup plane-panning-bottom-right-suspend-pipe-A-planes:
pass -> DMESG-WARN (shard-hsw)fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
shard-hsw total:2317 pass:1244 dwarn:3 dfail:0 fail:13 skip:1057 time:9583s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5765/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 15 lines · vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink).
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)include/drm/drm_dp_helper.h +0
-0
include/drm/drm_dp_helper.h line 739
Quoted 5 lines
include/drm/drm_dp_helper.h +2
-0@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf
where did you get that?
eDP 1.4 teels 2009h is a debug register.
Quoted 7 lines
include/drm/drm_dp_helper.h +1
-0+#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)Signature · 1 line
1.9.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink).
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>
I keep forgetting to update my eDP spec 1.4 to this 1.4b...
Quoted 21 lines
--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)include/drm/drm_dp_helper.h +3
-0@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf +#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)Signature · 1 line
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 9 lines · Rodrigo Vivi
Quoted 6 lines · vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink).
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>I keep forgetting to update my eDP spec 1.4 to this 1.4b...
Maybe the patch should then make this clear, by annotating it with /* eDP 1.4b */ That's missing, which isn't all that great really, since it makes specs hunts like yours necessary.
Please fix up before applying.
-Daniel
Quoted 31 lines
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 21 lines
--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)include/drm/drm_dp_helper.h +3
-0@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf +#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)Signature · 1 line
1.9.1_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 52 lines · Daniel Vetter
Quoted 9 lines · Rodrigo Vivi
Quoted 6 lines · vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink).
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>I keep forgetting to update my eDP spec 1.4 to this 1.4b...
Maybe the patch should then make this clear, by annotating it with /* eDP 1.4b */ That's missing, which isn't all that great really, since it makes specs hunts like yours necessary.
It's actually in eDP 1.4 spec, table 5-6 page 86
Please fix up before applying.
-DanielQuoted 24 lines
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 18 lines
--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)include/drm/drm_dp_helper.h +3
-0@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf +#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0)Quoted 7 lines
Quoted 3 lines
--
1.9.1_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Puthikorn Voravootivat
Quoted 9 lines · Daniel Vetter
Quoted 8 lines · Rodrigo Vivi
Quoted 6 lines · vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink).
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>
Quoted 8 lines
Quoted 7 lines
Quoted 1 line
I keep forgetting to update my eDP spec 1.4 to this 1.4b...
Maybe the patch should then make this clear, by annotating it with /* eDP 1.4b */ That's missing, which isn't all that great really, since it makes specs hunts like yours necessary.
It's actually in eDP 1.4 spec, table 5-6 page 86
Copy and paste the wrong one.0x2009 is actually in eDP 1.4 spec, Table 6-7: DPCD – Sink Device PSR Status Field page 124
Quoted 36 lines
Quoted 36 lines
Please fix up before applying.
-DanielQuoted 31 lines
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 19 lines
--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)include/drm/drm_dp_helper.h +3
-1@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf +#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) --Quoted 2 lines
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines
Quoted 5 lines
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 25 lines · Puthikorn Voravootivat
Quoted 21 lines · Puthikorn Voravootivat
Quoted 17 lines · Daniel Vetter
Quoted 9 lines · Rodrigo Vivi
Quoted 6 lines · vathsala nagaraju
Add defines for dpcd register 2009 (synchronization latency in sink).
Cc Rodrigo Vivi <[email protected]>CC Puthikorn Voravootivat <[email protected]>Signed-off-by Vathsala Nagaraju <[email protected]>I keep forgetting to update my eDP spec 1.4 to this 1.4b...
Maybe the patch should then make this clear, by annotating it with /* eDP 1.4b */ That's missing, which isn't all that great really, since it
makes specs hunts like yours necessary.
Quoted 5 lines
Quoted 1 line
It's actually in eDP 1.4 spec, table 5-6 page 86
Copy and paste the wrong one.
0x2009is actually in eDP 1.4 spec, Table 6-7: DPCD – Sink Device PSR Status Field page 124
you are absolutely right! eDP 1.4 has it. even the eDP 1.4a had... I definitely had a strange version here... All updated locally here.
For the patch I will update when merging. No need to send a newer version. I intend to merge patches tomorrow if no one has any other comment or concern on those.
Quoted 52 lines
Quoted 39 lines
Quoted 39 lines
Please fix up before applying.
-DanielQuoted 32 lines
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 20 lines
--- include/drm/drm_dp_helper.h | 3 +++ 1 file changed, 3 insertions(+)include/drm/drm_dp_helper.h +3
-1@@ -735,6 +735,9 @@# define DP_PSR_SINK_INTERNAL_ERROR 7# define DP_PSR_SINK_STATE_MASK 0x07 +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf +#define DP_RECEIVER_ALPM_STATUS 0x200b/* eDP 1.4 */ # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) --Quoted 2 lines
1.9.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-develQuoted 6 lines
Quoted 4 lines
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel