patch "usb: gadget: core: fix ->udc_set_speed() logic" added to usb-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
usb: gadget: core: fix ->udc_set_speed() logic
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
97e133d54c1ca8948b191e5721a145a76c4db33dMon Sep 17 00:00:00 2001
From: Roger Quadros <[email protected]>
Date: Tue, 19 Sep 2017 11:46:16 +0300
Subject: usb: gadget: core: fix ->udc_set_speed() logic
Consider the following case: udc controller supports SuperSpeed. If we first load a HighSpeed gadget followed by a SuperSpeed gadget, the SuperSpeed gadget will be limited to HighSpeed as UDC core driver doesn't call ->udc_set_speed() in the second case.
Call ->udc_set_speed() unconditionally to fix this issue.
This will also fix the case for dwc3 controller driver when SuperSpeed gadget is loaded first and works in HighSpeed only as udc_set_speed() was never being called.
--- drivers/usb/gadget/udc/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/gadget/udc/core.c +1 -2
@@ -1320,8 +1320,7 @@ static int udc_bind_to_driver(struct usb_udc *udc, struct usb_gadget_driver *dri udc->dev.driver = &driver->driver; udc->gadget->dev.driver = &driver->driver; -if (driver->max_speed < udc->gadget->max_speed) -usb_gadget_udc_set_speed (udc, driver->max_speed); +usb_gadget_udc_set_speed (udc, driver->max_speed); ret = driver->bind (udc->gadget, driver);if (ret)
Signature · 1 line
2.14.1