Skip to contentSkip to conversation

igt/kms_psr_sink_crc: Fix regression in psr_drrs subtest

igt Radhakrishna Sripada 4 participants 5 messages Sep 21, 2017

lore
Share & tools
lore
#0 lore raw

The substring to be matched is modified to reflect kernel code.

Fixes 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
Cc Rodrigo Vivi <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
---
 tests/kms_psr_sink_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_psr_sink_crc.c +1 -1
index 1c25f2c81a34..f023b12c0131 100644
@@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
 
 	igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
 
-	return strstr(buf, "DRRS Support: No\n");
+	return !strstr(buf, "DRRS Supported: Yes\n");
 }
 
 static void run_test(data_t *data)
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: warning for igt/kms_psr_sink_crc: Fix regression in psr_drrs subtest

== Series Details ==

== Series Details ==

Series: igt/kms_psr_sink_crc: Fix regression in psr_drrs subtest
URL : https://patchwork.freedesktop.org/series/30683/
State : warning

== Summary ==

IGT patchset tested on top of latest successful build 6e2622564dc85875ee9e2f22874f9607cf0cdd9c meson: share the configuration_data object

with latest DRM-Tip kernel build CI_DRM_3117
bed15796ff69 drm-tip: 2017y-09m-20d-20h-05m-31s UTC integration manifest

Test gem_ringfill:

        Subgroup basic-default-hang:
                pass       -> DMESG-WARN (fi-pnv-d510) fdo#101600
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                fail       -> PASS       (fi-snb-2600) fdo#100215
Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (fi-snb-2520m)

fdo#101600 https://bugs.freedesktop.org/show_bug.cgi?id=101600
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:445s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:473s
fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0   fail:0   skip:64  time:421s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:525s
fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0   fail:0   skip:105 time:277s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:514s
fi-byt-j1900     total:289  pass:254  dwarn:1   dfail:0   fail:0   skip:34  time:504s
fi-byt-n2820     total:289  pass:250  dwarn:1   dfail:0   fail:0   skip:38  time:497s
fi-cfl-s         total:289  pass:222  dwarn:35  dfail:0   fail:0   skip:32  time:544s
fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0   fail:0   skip:59  time:416s
fi-glk-1         total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:568s
fi-hsw-4770      total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:440s
fi-hsw-4770r     total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:411s
fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:444s
fi-ivb-3520m     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:489s
fi-ivb-3770      total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:464s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:477s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:575s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:594s
fi-pnv-d510      total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:540s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:457s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:755s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:497s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:470s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:568s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:1   skip:39  time:417s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_235/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Radhakrishna Sripada
Quoted 1 line · Radhakrishna Sripada

The substring to be matched is modified to reflect kernel code.

Well, technically it is not a regression on psr_drrs because it has this bug since the beginning ;)

Also this commit message doesn't explain the false positive case that DK pointed out.

Also this doesn't explain that is safe to use the reverse logic of !yes because DRRS is only enabled for eDP. Otherwise we would have to parse specifically the eDP block.

What brings me the question of why do we list all that useless information on debugfs? :)

Quoted 5 lines
Fixes 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
Cc Rodrigo Vivi <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>

Please also CC other folks that are currently working on DRRS..

Quoted 20 lines
---
 tests/kms_psr_sink_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_psr_sink_crc.c +1 -1
index 1c25f2c81a34..f023b12c0131 100644
@@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
 
 	igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
 
-	return strstr(buf, "DRRS Support: No\n");
+	return !strstr(buf, "DRRS Supported: Yes\n");
 }
 
 static void run_test(data_t *data)
Signature · 1 line
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
Quoted 34 lines · Rodrigo Vivi
Quoted 1 line · Radhakrishna Sripada

The substring to be matched is modified to reflect kernel code.

Well, technically it is not a regression on psr_drrs because it has this bug since the beginning ;)

Also this commit message doesn't explain the false positive case that DK pointed out.

Also this doesn't explain that is safe to use the reverse logic of !yes because DRRS is only enabled for eDP. Otherwise we would have to parse specifically the eDP block.

What brings me the question of why do we list all that useless information on debugfs? :)

Quoted 5 lines
Fixes 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
Cc Rodrigo Vivi <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>

Please also CC other folks that are currently working on DRRS..

Quoted 10 lines
---
 tests/kms_psr_sink_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_psr_sink_crc.c +0 -0
index 1c25f2c81a34..f023b12c0131 100644
@@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
 
Quoted 4 lines

tests/kms_psr_sink_crc.c static bool drrs_disabled(data_t *data) · line 293

Quoted 4 lines
tests/kms_psr_sink_crc.c +1 -1
 	igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
 
-	return strstr(buf, "DRRS Support: No\n");
+	return !strstr(buf, "DRRS Supported: Yes\n");

Neat and simple. Please send a patch to change the debugfs output that Rodrigo pointed out.

Quoted 10 lines
Quoted 6 lines
tests/kms_psr_sink_crc.c +0 -0
 }
 
 static void run_test(data_t *data)
Signature · 1 line
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
In reply to Rodrigo Vivi
Quoted 16 lines

-----Original Message-----
From: Vivi, Rodrigo
Sent: Thursday, September 21, 2017 7:54 AM
To: Sripada, Radhakrishna <[email protected]>
Cc: [email protected]; Pandiyan, Dhinakaran <[email protected]>
Subject: Re: [igt] igt/kms_psr_sink_crc: Fix regression in psr_drrs subtest

Quoted 1 line · Radhakrishna Sripada

The substring to be matched is modified to reflect kernel code.

Well, technically it is not a regression on psr_drrs because it has this bug since the beginning ;)

Quoted 7 lines

Also this commit message doesn't explain the false positive case that DK pointed out.

Also this doesn't explain that is safe to use the reverse logic of !yes because DRRS is only enabled for eDP. Otherwise we would have to parse specifically the eDP block.

I will update the commit message in the next version of the patch.

Quoted 2 lines

What brings me the question of why do we list all that useless information on debugfs? :)

I will send in a cleanup patch of the debugfs output.

-Radhakrishna

Quoted 21 lines
Quoted 6 lines
Fixes 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
Cc Rodrigo Vivi <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>

Please also CC other folks that are currently working on DRRS..

Quoted 12 lines
---
 tests/kms_psr_sink_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_psr_sink_crc.c index renamed from tests/kms_psr_sink_crc.c +0 -0

1c25f2c81a34..f023b12c0131 100644

tests/kms_psr_sink_crc.c +0 -0
@@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
 
 	igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
 
Quoted 8 lines
Quoted 8 lines
tests/kms_psr_sink_crc.c +1 -2
-	return strstr(buf, "DRRS Support: No\n");
+	return !strstr(buf, "DRRS Supported: Yes\n");
 }
 
 static void run_test(data_t *data)
--

2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx