Skip to contentSkip to conversation

libnvdimm fixes for 4.14-rc2

GIT PULL Williams, Dan J 1 participant 1 message Sep 21, 2017 libnvdimm: non-volatile memory device

lore
Share & tools
lore

Williams, Dan J

author Tested-by Maurice A. Saldivar
#0 lore raw

Hi Linus, please pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes

...to receive a crash fix and corresponding regression test enabling for the crash scenario. The unit test for this crash is available in ndctl-v58.2. This branch has received a build success notification from the 0day-kbuild robot over 148 configs. The fix is tagged for -stable / backport to 4.13.

---

The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e:

Linux 4.14-rc1 (2017-09-16 15:47:51 -0700)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes

for you to fetch changes up to 33a56086712561b8b9cdc881e0317f4c36861f72:

libnvdimm, namespace: fix btt claim class crash (2017-09-18 17:29:01 -0700)

----------------------------------------------------------------
Dan Williams (2):
tools/testing/nvdimm: disable labels for nfit_test.1 libnvdimm, namespace: fix btt claim class crash

 drivers/nvdimm/namespace_devs.c  | 9 +-+-+-+-+-+-+-+-+-
 tools/testing/nvdimm/test/nfit.c | 3 ---
 2 files changed, 9 insertions(+-), 3 deletions(-)

commit 5e75fe3927559505682b0053b5745e3f42d66e8c

Author: Dan Williams <[email protected]>
Date:   Mon Sep 18 17:19:10 2017 -0700

tools/testing/nvdimm: disable labels for nfit_test.1

Improve coverage of NVDIMM-N test scenarios by providing a test bus incapable of label operations.

commit 33a56086712561b8b9cdc881e0317f4c36861f72

Author: Dan Williams <[email protected]>
Date:   Mon Sep 18 14:48:58 2017 -0700

libnvdimm, namespace: fix btt claim class crash

Maurice reports:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000028
IP: holder_class_store+-0x253/0x2b0 [libnvdimm]

...while trying to reconfigure an NVDIMM-N namespace into 'sector' / 'btt' mode. The crash points to this line:

(gdb) li *(holder_class_store+-0x253)
0x7773 is in holder_class_store (drivers/nvdimm/namespace_devs.c:1420).
1415 for (i = 0; i < nd_region->ndr_mappings; i+-+-) {
1416 struct nd_mapping *nd_mapping = &nd_region->mapping[i];
1417 struct nvdimm_drvdata *ndd = to_ndd(nd_mapping);
1418 struct nd_namespace_index *nsindex;
1419
1420 nsindex = to_namespace_index(ndd, ndd->ns_current);

...where we are failing because ndd is NULL due to NVDIMM-N dimms not supporting labels.

Long story short, default to the BTTv1 format in the label-less / NVDIMM-N case.

Fixes 14e494542636 ("libnvdimm, btt: BTT updates for UEFI 2.7 format")
Cc Vishal Verma <[email protected]>

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm