Patch "regulator: cpcap: Fix standby mode" has been added to the 4.13-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
regulator: cpcap: Fix standby mode
to the 4.13-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
regulator-cpcap-fix-standby-mode.patch
and it can be found in the queue-4.13 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
91a024e80336528d12b67b5a2e636b9e4467d3ecMon Sep 17 00:00:00 2001
From: Sebastian Reichel <[email protected]>
Date: Mon, 10 Jul 2017 16:33:39 +0200
Subject: regulator: cpcap: Fix standby mode
From: Sebastian Reichel <[email protected]>
commit 91a024e80336528d12b67b5a2e636b9e4467d3ec upstream.
The original patch from Tony uses standby mode bit inverted, which is not correct. This fixes all instances in the driver code for get & set mode. This did not yet make problems, since mode has not been changed by any mainline driver so far.
--- drivers/regulator/cpcap-regulator.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/regulator/cpcap-regulator.c +5 -3
@@ -77,6 +77,8 @@#define CPCAP_BIT_VAUDIO_MODE0 BIT(1)#define CPCAP_BIT_V_AUDIO_EN BIT(0) +#define CPCAP_BIT_AUDIO_NORMAL_MODE 0x00 +/* * Off mode configuration bit. Used currently only by SW5 on omap4. There's * the following comment in Motorola Linux kernel tree for it:
@@ -217,7 +219,7 @@ static unsigned int cpcap_regulator_get_regmap_read (rdev->regmap, rdev->desc->enable_reg, &value); -if (!(value &CPCAP_BIT_AUDIO_LOW_PWR )) +if (value &CPCAP_BIT_AUDIO_LOW_PWR )return REGULATOR_MODE_STANDBY ;return REGULATOR_MODE_NORMAL ;
@@ -230,10 +232,10 @@ static int cpcap_regulator_set_mode(struswitch (mode) {case REGULATOR_MODE_NORMAL : - value =CPCAP_BIT_AUDIO_LOW_PWR ; + value =CPCAP_BIT_AUDIO_NORMAL_MODE ;break ;case REGULATOR_MODE_STANDBY : - value =0 ; + value =CPCAP_BIT_AUDIO_LOW_PWR ;break ;default :return -EINVAL ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.13/regulator-cpcap-fix-standby-mode.patch