Patch "scsi: sg: off by one in sg_ioctl()" has been added to the 3.18-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
scsi: sg: off by one in sg_ioctl()
to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
scsi-sg-off-by-one-in-sg_ioctl.patch
and it can be found in the queue-3.18 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
bd46fc406b30d1db1aff8dabaff8d18bb423fdcfMon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Thu, 17 Aug 2017 10:09:54 +0300
Subject: scsi: sg: off by one in sg_ioctl()
From: Dan Carpenter <[email protected]>
commit bd46fc406b30d1db1aff8dabaff8d18bb423fdcf upstream.
If "val" is SG_MAX_QUEUE then we are one element beyond the end of the "rinfo" array so the > should be >=.
--- drivers/scsi/sg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/sg.c +1 -1
@@ -1056,7 +1056,7 @@ sg_ioctl(struct file *filp, unsigned intread_lock_irqsave (&sfp->rq_list_lock, iflags); val =0 ;list_for_each_entry (srp, &sfp->rq_list, entry) { -if (val >SG_MAX_QUEUE ) +if (val >=SG_MAX_QUEUE )break ;memset (&rinfo[val],0 ,SZ_SG_REQ_INFO ); rinfo[val].req_state = srp->done +1 ;
Patches currently in stable-queue which might be from [email protected] are
queue-3.18/scsi-sg-off-by-one-in-sg_ioctl.patch queue-3.18/scsi-qla2xxx-fix-an-integer-overflow-in-sysfs-code.patch